Skip to main content

All Questions

Tagged with
Filter by
Sorted by
Tagged with
3 votes
5 answers
563 views

How do I find indicators to show that code review is improving quality of a code base?

I was asked to review and handle merge request for a code base, which has been contributed by dozens of programmer with basically no regulation (or perhaps there was but nobody follows), so I set up ...
Rahn's user avatar
  • 147
0 votes
1 answer
333 views

Code review patterns for multiple teams working on a single product

We're scaling out development on a single product from a single team to multiple teams. What are the patterns to ensure coding style, patterns and technology is used consistently? Is there one person ...
LazyCoder's user avatar
  • 617
27 votes
4 answers
4k views

How to handle a TODO in a pull request?

When I review the changes in a pull request, I sometimes stumble upon a comment with a "TODO" note which may be there for different reasons, in our case mostly because of: the solution used to solve ...
alecxe's user avatar
  • 341
0 votes
1 answer
298 views

Shall I use low quality insecure software if I'm asked to?

I work for a finance startup managing the technical stuff. The COO decided to create a new web site using a contract developer and the owner of the company paid for it ($9k). I'm asked to use the new ...
Chloe's user avatar
  • 448
103 votes
13 answers
18k views

How to deal with 'almost good' code from a junior developer? [closed]

I got a question about team managing. Right now I'm dealing with a junior developer who's working remotely from a coding factory. The guy is open to criticism and willing to learn, but I got some ...
Zalomon's user avatar
  • 1,200
35 votes
6 answers
5k views

How can I write unit tests that simplify feature implementation? [duplicate]

I'm a newbie to working in software development and I read a lot about how cool unit tests are. Now, I've made my first steps into a project where I'm working with a number of equally unexperienced ...
Gerome Bochmann's user avatar
30 votes
11 answers
4k views

What factors should influence how I determine when to abandon a small project with a friend? [closed]

I've found myself in a tough spot as of late. Been working on a game with a programming buddy for nearly 8 months now. We both started off as newcomers to programming around August of last year, he is ...
Douglas Gaskell's user avatar
0 votes
1 answer
288 views

how to introduce a culture of quality into the work environment? [duplicate]

Currently we're not doing any code reviews and we have effectively zero unit tests (we have some but they are never run by anyone else other than myself) and there's no coding standards for style and ...
user avatar
10 votes
2 answers
1k views

How to deal with too much pragmatism in the project? [duplicate]

My team and I took over a medium sized codebase over a year ago when the previous tech lead left the company. Originating from the lack of man power I fear we favored pragmatic solutions over best ...
Andreas Eisele's user avatar
7 votes
6 answers
1k views

what is the best way to ensure accountability in code checkins?

Note: after writing this I realize that this question is perhaps philosophical, but I'm interested in how the industry handles this scenario regardless. I have recently been working with a code base ...
user376456's user avatar
13 votes
4 answers
1k views

How should code "Goal Tending" be handled by a Development Manager?

First allow me to coin a term: code goal-tending: Checking out code in the morning, then silently reviewing all of the changes made by the other developers the previous day file by file, (...
Kevin McCormick's user avatar
8 votes
4 answers
244 views

Advice/Approach for distilling homogenous code and building common code for a team

I work for the State of California. Our programming team in my opinion is not really a 'team' in that we usually work solo on projects throughout the application/systems complete life-cycle. The end ...
one.beat.consumer's user avatar
9 votes
15 answers
3k views

Are software developers who ignore quality/standards better for the company? [closed]

Do software developers who choose not to put code optimization, standards and best practices as a top priority, create more useful code than those developers who want to worry about optimization, ...
Jitendra Vyas's user avatar
25 votes
9 answers
6k views

My coworker is a nice guy, but his performance is sub-par. Do I tell my boss? [closed]

I was placed on a project about three months ago that was until then under development by a single, newly hired developer because it was falling behind. To be fair, the project is an interface to a ...
LostInCode's user avatar
39 votes
11 answers
4k views

At what point does "constructive" criticism of your code become unhelpful?

I recently started as a junior developer. As well as being one of the least experienced people on the team, I'm also a woman, which comes with all sorts of its own challenges working in a male-...
user15859's user avatar
  • 401
33 votes
17 answers
5k views

Dealing with co-workers who do not have a consistent coding style?

What do you when you're working with someone who tends to write stylistically bad code? The code I'm talking about is usually technically correct, reasonably structured, and may even be ...
JSBձոգչ's user avatar
  • 1,440
4 votes
6 answers
782 views

When is it right to edit the code written by a co-worker? [duplicate]

For which issues is it right to edit the code written by a co-worker? For which issues is it wrong?
Tamara Wijsman's user avatar