Change 632290 abandoned by Ammarpad:

[mediawiki/core@master] ApiEditPage: Inject dependencies

Reason:

https://gerrit.wikimedia.org/r/632290

In T268834#6739312, @Amorymeltzer wrote:

Just to confirm @MusikAnimal, am I right that this change has also tweaked (corrected?) the return value of watched when using format=json&formatversion=2? Without this change, a title I'm not watching returns "watched": false while after this change, it does not return watched. That's seems more correct, but just wanted to confirm since it wasn't mentioned.

Just to confirm @MusikAnimal, am I right that this change has also tweaked (corrected?) the return value of watched when using format=json&formatversion=2? Without this change, a title I'm not watching returns "watched": false while after this change, it does not return watched. That's seems more correct, but just wanted to confirm since it wasn't mentioned.

PR: https://github.com/wsexport/tool/pull/308

In T266190#6731986, @dom_walden wrote:

MusikAnimal Following the Docker steps in the README.md. When I ran docker-compose exec wsexport ./bin/console doctrine:database:create I got:

SQLSTATE[HY000]: General error: 1007 Can't create database 'wsexport'; database exists

I am assuming because the mariadb image in the docker compose already creates the wsexport database.

It works if instead I run docker-compose exec wsexport ./bin/console doctrine:migrations:migrate --no-interaction.

Should we change the docker-compose.yml, the README or the code?

This is ready for QA.

Should this new alias be announced to the wikisource communities? (I guess the same question goes for epub -> epub-3)

When looking up information for a page via the api, you can now return the watch expiry.

PR https://github.com/wsexport/tool/pull/306

The patch for T256392 (now merged) does the actual work of removing the PDF link, and the above patch adds some comments to the config about the two extensions needing to stay being loaded in that order.

It looks like we've either never set up autodeployment on prod, or we removed it at some point. I think we should set it up again. Or were we purposefully sticking at 2.0.0 for a reason (sorry, I know I should remember…)?

I have also tested http://wsexport.wmflabs.org/tool/book.php?format=mobi&lang=pl&page=Dziady%20cz%C4%99%C5%9B%C4%87%20III%2FScena%20V and it exports correctly. I am marking this as Done.

This change has been on production for a while now, and it seems to have resolved the issue. Users can now see valid expiry values in the dropdown. If there are invalid translations, they can still watch pages permanently. I'm marking this work as Done.

Correction: This is on the test server, but not on production yet. While it appeared to be released, as per https://github.com/wsexport/tool/releases, this wasn't the case when we actually logged into the prod server to check. So I'll move it back to sign-off & mark it as Done when it's released to prod.

I now see the invalid format message (see screenshot example below). Furthermore, if an invalid format is submitted, it defaults to epub. I'm marking this work as Done.

This is now on production. As noted by Dom, there are some minor formatting issues for us to analyze, as a result of this work. However, these issues can be addressed in separate tickets: T270367, T270372, T270373, T270395. For this reason, I am marking this work as Done.

This has been merged & has passed QA. It only impacts developers (not production), as noted by Dom. For this reason, I'm marking this work as Done.

Change 640867 merged by jenkins-bot:
[mediawiki/extensions/Wikisource@master] Add sidebar links to Wikisource Export tool

Okay, thanks, @dmaza. I've added this information to the follow-up ticket (T271336), so it doesn't get lost. We'll discuss it in a future meeting.

In T266190#6708413, @MusikAnimal wrote:

...So I guess the main thing we're testing is if anything broke as far as storing exports in the the books_generated table.

Yeah, there are a lot, it's unfortunate. There's a tag, Bad markup applied by the AbuseFIlter at enWS: https://en.wikisource.org/wiki/Special:RecentChanges?hidebots=1&hidecategorization=1&hideWikibase=1&tagfilter=bad_markup&limit=1000&days=30&urlversion=2

I was going to say that this should be fixed at the source, but it looks like there are lots of table align attributes. And anyway, we are currently "fixing" them wrongly!

PR: https://github.com/wsexport/tool/pull/305

Change 649736 merged by jenkins-bot:
[mediawiki/core@master] ApiQueryInfo: Return watchlist expiry when applicable for inprop=watched

PR: https://github.com/wsexport/tool/pull/304

Sorry about this!

In T267079#6729305, @ifried wrote:

Just to clarify, @Samwilson: There's no way we can get data on the ebook exports that time out? Or is there a way? Just want to understand the options for handling this. Thanks in advance!