Page MenuHomePhabricator
Create Task
Maniphest T96906

Refactor UploadWizard to be maintainable
Open, Needs TriagePublic
Actions

Description

See blocking tasks for more.

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT49145 Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core
 OpenNoneT100270 Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core
 OpenNoneT96911 Improve UploadWizard UX (tracking)
 OpenNoneT96906 Refactor UploadWizard to be maintainable
 ResolvedmatthiasmullieT93895 Remove this.uploads from the UploadWizard class
 ResolvedMarkTraceurT93893 Move startUploads into the upload step controller
 ResolvedMarkTraceurT93892 Move showNext into the step controllers (and simplify it)
 ResolvedMarkTraceurT93891 Change isComplete to query step objects instead of upload objects
 ResolvedmatthiasmullieT93888 Move setUploadFilled to the file step controller
 ResolvedMarkTraceurT93099 Have step controllers drive the process and be linked together
 ResolvedMarkTraceurT91650 Refactor UploadWizard to make step controllers truly independent
 ResolvedMarkTraceurT91514 Make uploads and details use promises for their transitions, and change transition methods to use them
 OpenNoneT90741 Move file metadata copy handling to describe step, change UX
 ResolvedmatthiasmullieT89855 Move the interface for adding new files to a new UI class and refactor things around it
 ResolvedmatthiasmullieT96916 Move checkFile out of the Upload object and into the upload step controller
 ResolvedmatmarexT126712 Kill moveFileInputToCover
 OpenNoneT88880 Make a real, bonafide Flickr UI class
 DuplicateMarkTraceurT77672 Remove jquery.pubsub from UploadWizard
 ResolvedmatmarexT51988 Use Deferred/Promise and generally async-friendly code paths instead of jquery.pubsub
 ResolvedmatthiasmullieT94099 Rewrite mw.FormDataTransport.js to make use of mw.Api
 ResolvedmatthiasmullieT96915 Move error/warning handling out of setTransported and into the upload handler
 ResolvedMarkTraceurT96918 Move UI creation into JavaScript
 DeclinedmatmarexT96520 Rewrite UploadWizard with mustache templates
 ResolvedmatmarexT97169 [EPIC] Enable UploadWizard on mobile
 ResolvedmatmarexT97202 Enable various core modules for mobile to make UploadWizard work
 ResolvedphuedxT98874 Remove upload interface code from MobileFrontend
 ResolvedmatmarexT96914 Migrate UploadWizard UI elements to OOjs UI
 ResolvedmatmarexT112764 Replace CoolCats with mw.widgets.CategorySelector
 Resolved• PrtksxnaT111791 Create mw.widgets.CategorySelector
 ResolvedAnomieT88250 Create tag list / tokenizer / capsule controls widget
 ResolvedMarkTraceurT112117 Replace jquery dialogs in UploadWizard with OOUI dialogs
 ResolvedmatmarexT34606 duplicate link: is not HTML-linked to file page, not red and points to the wrong URL
 ResolvedMarkTraceurT112907 Remove image preview dialog from UploadWizard
 ResolvedmatmarexT97426 Use OOUI datepicker input widget in UploadWizard
 ResolvedmatmarexT97425 Create a datepicker input widget
 ResolvedmatmarexT96917 Split up the details class into multiple OOjs UI widgets in separate files
 ResolvedmatmarexT118906 Migrate deed chooser forms to OOjs UI
 ResolvedMarkTraceurT113371 Migrate text fields in UploadWizard deed step to OO.ui.TextInputWidget
 ResolvedmatmarexT117833 Use OOUI 'required' indicator for required fields
 ResolvedmatmarexT140581 Stop using jQuery UI Selectable for Flickr uploads
 ResolvedmatmarexT140582 Stop relying on jQuery UI styles in UploadWizard
 ResolvedJdlrobsonT97188 Mustache templates in core do not support partials (client side)
 ResolvedmatthiasmullieT291 Make removeUpload and removeMatchingUploads etc. into UploadWizardUpload and UploadWizardUploadList, respectively
 ResolvedNoneT292 Make newUpload much smaller, move most upload init into UWU() and move interface code to UWUI()
 InvalidMarkTraceurT289 Make setUploadFilled into an event from UWUI, do things in UWU and UW
 ResolvedMarkTraceurT293 Make UploadWizardUpload and UploadWizardUploadInterface EventEmitter inheriters.
 DuplicateNoneT285 Kill jquery.pubsub.js, use promises
 DuplicateMarkTraceurT287 Use promises for image info getter methods in UploadWizardUpload
 InvalidMarkTraceurT286 Rebase, review, merge: Massive refactor...
 ResolvedNoneT294 Super epic: Refactor moveToStep into a smaller function, make controllers for each step
 ResolvedmatmarexT131248 Remove old code for browsers not supporting HTML5 File API from UploadWizard
 ResolvedmatmarexT126763 Remove support for browsers not supporting HTML5 File API from UploadWizard
 DeclinedmatmarexT127371 When UW loads, log whether `mw.fileApi.isAvailable()` is true or false via EventLogging
 ResolvedmatmarexT130167 Special:UploadWizard spins forever on Grade C browsers
 ResolvedmatmarexT131202 Use jquery.makeCollapsible for collapsible stuff instead of our own code

Event Timeline

MarkTraceur created this task.Apr 22 2015, 8:07 PM
MarkTraceur raised the priority of this task from to Medium.
MarkTraceur updated the task description. (Show Details)
MarkTraceur added a project: UploadWizard.
MarkTraceur subscribed.
Restricted Application added a project: Multimedia. · View Herald TranscriptApr 22 2015, 8:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
MarkTraceur added subtasks: T93893: Move startUploads into the upload step controller, T93895: Remove this.uploads from the UploadWizard class, T93892: Move showNext into the step controllers (and simplify it), T93891: Change isComplete to query step objects instead of upload objects, T93888: Move setUploadFilled to the file step controller, T93099: Have step controllers drive the process and be linked together, T91650: Refactor UploadWizard to make step controllers truly independent, T91514: Make uploads and details use promises for their transitions, and change transition methods to use them, T90741: Move file metadata copy handling to describe step, change UX, T89855: Move the interface for adding new files to a new UI class and refactor things around it, T88880: Make a real, bonafide Flickr UI class, T77672: Remove jquery.pubsub from UploadWizard, T287: Use promises for image info getter methods in UploadWizardUpload, T51988: Use Deferred/Promise and generally async-friendly code paths instead of jquery.pubsub.Apr 22 2015, 8:08 PM
MarkTraceur added a subtask: T94099: Rewrite mw.FormDataTransport.js to make use of mw.Api.Apr 22 2015, 8:22 PM
Jdforrester-WMF subscribed.Apr 22 2015, 9:33 PM
matmarex subscribed.Apr 22 2015, 9:45 PM
matmarex unsubscribed.Apr 22 2015, 9:59 PM
Aklapper added a comment.Apr 22 2015, 10:19 PM

Hmm, how is this task different from the project UploadWizard-Refactoring ?

MarkTraceur closed subtask T93892: Move showNext into the step controllers (and simplify it) as Resolved.Apr 23 2015, 2:56 PM
matmarex closed subtask T93893: Move startUploads into the upload step controller as Resolved.Apr 24 2015, 6:33 PM
matmarex closed subtask T93891: Change isComplete to query step objects instead of upload objects as Resolved.
matmarex closed subtask T93099: Have step controllers drive the process and be linked together as Resolved.
matmarex closed subtask T91514: Make uploads and details use promises for their transitions, and change transition methods to use them as Resolved.
matmarex mentioned this in UploadWizard-Refactoring.Apr 24 2015, 6:58 PM
matmarex subscribed.

UploadWizard-Refactoring was for Mark's work last year. I archived it now, we will no longer be using it. There are enough projects already. :)

matmarex added subtasks: T96520: Rewrite UploadWizard with mustache templates, T91717: Be able to embed an upload dialog so that other extensions (e.g. WikiEditor, VisualEditor) can provide it to users, T291: Make removeUpload and removeMatchingUploads etc. into UploadWizardUpload and UploadWizardUploadList, respectively, T292: Make newUpload much smaller, move most upload init into UWU() and move interface code to UWUI(), T286: Rebase, review, merge: Massive refactor..., T289: Make setUploadFilled into an event from UWUI, do things in UWU and UW, T285: Kill jquery.pubsub.js, use promises, T294: Super epic: Refactor moveToStep into a smaller function, make controllers for each step.Apr 24 2015, 7:03 PM
Ricordisamoa subscribed.Apr 24 2015, 7:24 PM
matmarex closed subtask T286: Rebase, review, merge: Massive refactor... as Invalid.Apr 24 2015, 8:08 PM
MarkTraceur closed subtask T294: Super epic: Refactor moveToStep into a smaller function, make controllers for each step as Resolved.Apr 28 2015, 4:00 PM
Jdforrester-WMF moved this task from Untriaged to Next up on the Multimedia board.Apr 30 2015, 4:13 PM
MarkTraceur closed subtask T289: Make setUploadFilled into an event from UWUI, do things in UWU and UW as Invalid.May 1 2015, 4:15 PM
intracer subscribed.Aug 16 2015, 10:19 AM
Restricted Application added subscribers: Steinsplitter, Matanya. · View Herald TranscriptAug 16 2015, 10:19 AM
Jdforrester-WMF closed subtask T91717: Be able to embed an upload dialog so that other extensions (e.g. WikiEditor, VisualEditor) can provide it to users as Resolved.Sep 29 2015, 4:15 PM
matmarex closed subtask T96520: Rewrite UploadWizard with mustache templates as Declined.Oct 16 2015, 6:05 PM
matmarex removed a subtask: T91717: Be able to embed an upload dialog so that other extensions (e.g. WikiEditor, VisualEditor) can provide it to users.
matmarex closed subtask T51988: Use Deferred/Promise and generally async-friendly code paths instead of jquery.pubsub as Resolved.Nov 3 2015, 3:38 PM
Jdforrester-WMF closed subtask T96917: Split up the details class into multiple OOjs UI widgets in separate files as Resolved.Nov 20 2015, 7:07 PM
matmarex closed subtask T96918: Move UI creation into JavaScript as Resolved.Dec 3 2015, 3:39 PM
MarkTraceur closed subtask T91650: Refactor UploadWizard to make step controllers truly independent as Resolved.Dec 3 2015, 7:59 PM
MarkTraceur lowered the priority of this task from Medium to Low.Dec 3 2015, 8:03 PM
MarkTraceur added a project: Technical-Debt.
Danny_B moved this task from Unsorted to Needs refactor on the Technical-Debt board.Jan 23 2016, 12:04 AM
matmarex added subtasks: T126763: Remove support for browsers not supporting HTML5 File API from UploadWizard, T126712: Kill moveFileInputToCover.Feb 12 2016, 5:10 PM
matmarex closed subtask T126712: Kill moveFileInputToCover as Resolved.Feb 18 2016, 9:08 PM
matmarex closed subtask T292: Make newUpload much smaller, move most upload init into UWU() and move interface code to UWUI() as Resolved.Feb 18 2016, 9:26 PM
Antanana subscribed.Mar 20 2016, 12:39 AM
matmarex added a subtask: T131248: Remove old code for browsers not supporting HTML5 File API from UploadWizard.Mar 30 2016, 2:07 PM
matmarex closed subtask T126763: Remove support for browsers not supporting HTML5 File API from UploadWizard as Resolved.Mar 30 2016, 2:40 PM
matmarex closed subtask T131248: Remove old code for browsers not supporting HTML5 File API from UploadWizard as Resolved.Mar 31 2016, 4:49 PM
matmarex added a subtask: T131202: Use jquery.makeCollapsible for collapsible stuff instead of our own code.Mar 31 2016, 8:01 PM
matmarex closed subtask T131202: Use jquery.makeCollapsible for collapsible stuff instead of our own code as Resolved.Apr 25 2016, 11:47 PM
Jdforrester-WMF added a subtask: T97169: [EPIC] Enable UploadWizard on mobile.Jul 18 2016, 10:07 PM
matmarex closed subtask T97169: [EPIC] Enable UploadWizard on mobile as Resolved.Aug 3 2016, 5:20 PM
matmarex closed subtask T93895: Remove this.uploads from the UploadWizard class as Resolved.Nov 16 2016, 10:26 AM
matthiasmullie closed subtask T93888: Move setUploadFilled to the file step controller as Resolved.Dec 1 2016, 1:05 PM
matthiasmullie closed subtask T89855: Move the interface for adding new files to a new UI class and refactor things around it as Resolved.Dec 1 2016, 1:11 PM
matmarex closed subtask T291: Make removeUpload and removeMatchingUploads etc. into UploadWizardUpload and UploadWizardUploadList, respectively as Resolved.Dec 7 2016, 3:26 PM
matmarex closed subtask T94099: Rewrite mw.FormDataTransport.js to make use of mw.Api as Resolved.Dec 27 2016, 11:10 PM
MarkTraceur unsubscribed.Jan 27 2017, 10:18 PM
MarkTraceur subscribed.Jan 27 2017, 10:53 PM
matthiasmullie closed subtask T96916: Move checkFile out of the Upload object and into the upload step controller as Resolved.Feb 6 2017, 11:41 AM
matthiasmullie mentioned this in T51990: More tightly couple object model and interface model in UploadWizard.Mar 30 2017, 11:53 AM
MarkTraceur closed subtask T96915: Move error/warning handling out of setTransported and into the upload handler as Resolved.May 8 2017, 5:36 PM
MarkTraceur raised the priority of this task from Low to Needs Triage.Sep 7 2017, 4:12 PM
MarkTraceur moved this task from Next up to Desired epics on the Multimedia board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits