Page MenuHomePhabricator
Create Task
Maniphest T96520

Rewrite UploadWizard with mustache templates
Closed, DeclinedPublic
Actions

Description

After looking at UploadWizard I can see a lot of the code involves string stitching. Moving a lot of this into templates will help make the code a lot easier to read/maintain and make it much easier for us to rewrite this in oojs ui (removing jquery ui dependencies) and eventually make this work on mobile.

Details

SubjectRepoBranchLines +/-
WIP: Commence introducing templating to UploadWizardmediawiki/extensions/UploadWizardmaster+516 -482
Commence introducing templating to UploadWizardmediawiki/extensions/UploadWizardmaster+182 -120
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT96906 Refactor UploadWizard to be maintainable
 DeclinedmatmarexT96520 Rewrite UploadWizard with mustache templates
 ResolvedmatmarexT97169 [EPIC] Enable UploadWizard on mobile
 ResolvedmatmarexT97202 Enable various core modules for mobile to make UploadWizard work
 ResolvedphuedxT98874 Remove upload interface code from MobileFrontend
 ResolvedmatmarexT96914 Migrate UploadWizard UI elements to OOjs UI
 ResolvedmatmarexT112764 Replace CoolCats with mw.widgets.CategorySelector
 Resolved• PrtksxnaT111791 Create mw.widgets.CategorySelector
 ResolvedAnomieT88250 Create tag list / tokenizer / capsule controls widget
 ResolvedMarkTraceurT112117 Replace jquery dialogs in UploadWizard with OOUI dialogs
 ResolvedmatmarexT34606 duplicate link: is not HTML-linked to file page, not red and points to the wrong URL
 ResolvedMarkTraceurT112907 Remove image preview dialog from UploadWizard
 ResolvedmatmarexT97426 Use OOUI datepicker input widget in UploadWizard
 ResolvedmatmarexT97425 Create a datepicker input widget
 ResolvedmatmarexT96917 Split up the details class into multiple OOjs UI widgets in separate files
 ResolvedmatmarexT118906 Migrate deed chooser forms to OOjs UI
 ResolvedMarkTraceurT113371 Migrate text fields in UploadWizard deed step to OO.ui.TextInputWidget
 ResolvedmatmarexT117833 Use OOUI 'required' indicator for required fields
 ResolvedmatmarexT140581 Stop using jQuery UI Selectable for Flickr uploads
 ResolvedmatmarexT140582 Stop relying on jQuery UI styles in UploadWizard
 ResolvedJdlrobsonT97188 Mustache templates in core do not support partials (client side)

Event Timeline

Jdlrobson created this task.Apr 19 2015, 6:59 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: UploadWizard.
Jdlrobson subscribed.
Restricted Application added a project: Multimedia. · View Herald TranscriptApr 19 2015, 6:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdlrobson set Security to None.Apr 19 2015, 7:28 PM
Jdlrobson added a subscriber: kaldari.
Aklapper added a comment.Apr 20 2015, 9:10 AM

Might also be UploadWizard-Refactoring ?

gerritbot subscribed.Apr 20 2015, 3:45 PM

Change 205269 had a related patch set uploaded (by Jdlrobson):
Commence introducing templating to UploadWizard

https://gerrit.wikimedia.org/r/205269

gerritbot added a project: Patch-For-Review.Apr 20 2015, 3:45 PM
Jdlrobson added a project: UploadWizard-Refactoring.Apr 20 2015, 4:53 PM
Florian subscribed.Apr 20 2015, 5:11 PM
matmarex added a parent task: T96906: Refactor UploadWizard to be maintainable.Apr 24 2015, 7:03 PM
Ricordisamoa subscribed.Apr 24 2015, 7:30 PM
Jdlrobson added a subtask: T97188: Mustache templates in core do not support partials (client side).Apr 24 2015, 9:53 PM
gerritbot added a comment.Apr 25 2015, 12:50 AM

Change 206493 had a related patch set uploaded (by Jdlrobson):
WIP: Commence introducing templating to UploadWizard

https://gerrit.wikimedia.org/r/206493

gerritbot added a comment.Apr 30 2015, 12:24 AM

Change 205269 abandoned by Jdlrobson:
Commence introducing templating to UploadWizard

Reason:
See https://gerrit.wikimedia.org/r/#/c/206493/ still working on it though.
Yes Bartosz this will make your life a loadddd easier in moving to oojs ui.

https://gerrit.wikimedia.org/r/205269

matmarex removed a project: UploadWizard-Refactoring.Apr 30 2015, 7:39 AM
matmarex subscribed.
gerritbot added a comment.May 24 2015, 12:39 PM

Change 206493 abandoned by Jdlrobson:
WIP: Commence introducing templating to UploadWizard

https://gerrit.wikimedia.org/r/206493

MarkTraceur subscribed.Jul 29 2015, 5:00 PM

Should close WONTFIX?

Restricted Application added subscribers: Steinsplitter, Matanya. · View Herald TranscriptJul 29 2015, 5:00 PM
Jdforrester-WMF triaged this task as Low priority.Sep 4 2015, 6:55 PM
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 7:02 PM
matmarex closed this task as Declined.Oct 16 2015, 6:05 PM
matmarex claimed this task.
kaldari changed the status of subtask T97188: Mustache templates in core do not support partials (client side) from Open to Stalled.Dec 2 2015, 2:14 AM
Jdlrobson closed subtask T97188: Mustache templates in core do not support partials (client side) as Resolved.Dec 22 2015, 8:24 PM
matmarex closed subtask T97169: [EPIC] Enable UploadWizard on mobile as Resolved.Aug 3 2016, 5:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits