Page MenuHomePhabricator
Create Task
Maniphest T73163

Cannot edit old revisions if the content model of those revisions are different from the page's current revision
Closed, ResolvedPublic
Actions

Description

2014-09-23 02:55:34 mw1020 mediawikiwiki: [acd305b3] /w/index.php?title=Project:Sandbox&action=edit&oldid=1176667 Exception from line 594 of /srv/mediawiki/php-1.24wmf22/includes/content/ContentHandler.php: Format text/x-wiki is not supported for content model css
#0 /srv/mediawiki/php-1.24wmf22/includes/content/TextContentHandler.php(49): ContentHandler->checkFormat()
#1 /srv/mediawiki/php-1.24wmf22/includes/content/AbstractContent.php(151): TextContentHandler->serializeContent()
#2 /srv/mediawiki/php-1.24wmf22/includes/EditPage.php(2246): AbstractContent->serialize()
#3 /srv/mediawiki/php-1.24wmf22/includes/EditPage.php(938): EditPage->toEditText()
#4 /srv/mediawiki/php-1.24wmf22/includes/EditPage.php(532): EditPage->initialiseForm()
#5 /srv/mediawiki/php-1.24wmf22/includes/actions/EditAction.php(56): EditPage->edit()
#6 /srv/mediawiki/php-1.24wmf22/includes/MediaWiki.php(414): EditAction->show()
#7 /srv/mediawiki/php-1.24wmf22/includes/MediaWiki.php(282): MediaWiki->performAction()
#8 /srv/mediawiki/php-1.24wmf22/includes/MediaWiki.php(584): MediaWiki->performRequest()
#9 /srv/mediawiki/php-1.24wmf22/includes/MediaWiki.php(435): MediaWiki->main()
#10 /srv/mediawiki/php-1.24wmf22/index.php(46): MediaWiki->run()
#11 /srv/mediawiki/w/index.php(3): include()
#12 {main}

Version: unspecified
Severity: normal
URL: https://www.mediawiki.org/w/index.php?title=Project:Sandbox&action=edit&oldid=1176667
See Also:
{73490}
T72901: Users can change the content model of other users' user pages to CSS or JS

Details

Reference
bz71163
SubjectRepoBranchLines +/-
Handle revisions with different content models in EditPagemediawiki/coremaster+41 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 3:48 AM
• bzimport added a project: MediaWiki-ContentHandler.
• bzimport set Reference to bz71163.
• bzimport added a subscriber: Unknown Object (MLST).
Jackmcbarn created this task.Sep 23 2014, 3:01 AM
Legoktm added a comment.Nov 11 2014, 12:10 AM

Reproduction case:

Create a page with JSON content model
Make a few edits
Convert page to wikitext content model
Try going to action=edit&oldid=### where the oldid you use is from where the revision is JSON
Exception is thrown.

https://www.mediawiki.org/w/index.php?title=User%3ALegoktm%2Ftest&diff=1257300&oldid=1236737

Pressing undo or edit (on the left edit) throws a fatal as well.

EBernhardson mentioned this in T51193: Set $wgContentHandlerUseDB = true on all WMF wikis.Dec 5 2014, 7:14 PM
EBernhardson subscribed.

@daniel You would be most familiar with ContentHandler, what needs to happen to support this use case?

jayvdb subscribed.Dec 27 2014, 10:24 AM
• Spage mentioned this in T85874: [3] O5. managing Flow boards outside $wgFlowOccupyPages (spike).Jan 5 2015, 10:31 PM
Ricordisamoa subscribed.Jan 12 2015, 3:19 PM
He7d3r updated the task description. (Show Details)Jan 23 2015, 12:02 PM
He7d3r set Security to None.
• RobLa-WMF mentioned this in T92794: Remove 'editcontentmodel' user right and restriction on editing content models.Mar 16 2015, 3:59 AM
Legoktm added a comment.Jun 30 2015, 10:47 PM

This is related to T104033: Populate rev_content_model and rev_content_format when saving. We do not set a rev_content_model/rev_content_format when saving if they are the default, and when the page's model is changed, the revisions need to be updated to explicitly reference the old model.

Legoktm added a comment.Jul 1 2015, 12:53 AM

Ignore what I said. This is unrelated...

We try to serialize the Content into text using the current default format of the page. If the revision is JavaScript and the page is currently JSON, it will try serializing JavaScript as application/json, which will fail. I think we should just show a read only "View source" page and serialize using the revision's content format. Thoughts?

• MZMcBride subscribed.Jul 1 2015, 4:46 AM
He7d3r subscribed.Jul 21 2015, 9:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 21 2015, 9:07 PM
wctaiwan subscribed.Aug 24 2015, 6:20 AM
Glaisher subscribed.Sep 3 2015, 4:20 PM
Glaisher merged a task: T104498: action=edit on a revision of a page whose content model is different than the current content model fails with "Fatal exception of type MWException".Sep 3 2015, 4:27 PM
Glaisher added subscribers: Mvolz, • jcrespo, Nnemo and 4 others.
gerritbot subscribed.Sep 13 2015, 9:20 PM

Change 237988 had a related patch set uploaded (by Legoktm):
Handle revisions with different content models in EditPage

https://gerrit.wikimedia.org/r/237988

gerritbot added a project: Patch-For-Review.Sep 13 2015, 9:20 PM
Glaisher mentioned this in T108663: Exception error occurs when editing JSON pages on th.wp/th.wikt.Sep 27 2015, 5:32 PM
gerritbot added a comment.Oct 21 2015, 4:08 AM

Change 237988 merged by jenkins-bot:
Handle revisions with different content models in EditPage

https://gerrit.wikimedia.org/r/237988

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2015-10-27_(1.27.0-wmf.4)).Oct 21 2015, 5:00 AM
Legoktm closed this task as Resolved.Oct 21 2015, 5:46 AM
Legoktm assigned this task to wctaiwan.
• RobLa-WMF mentioned this in T85847: Grant editcontentmodel right to all logged in users.Mar 8 2016, 6:46 PM
• MZMcBride mentioned this in T72901: Users can change the content model of other users' user pages to CSS or JS.Sep 10 2016, 8:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits