Set $wgContentHandlerUseDB = true on all WMF wikis
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	greg
	Jun 5 2013, 5:10 PM

Description

The schema change to add the content handler DB columns completed in October 2014 (details below).
This bug is now about turning on $wgContentHandlerUseDB on all WMF wikis

https://meta.wikimedia.org/wiki/Wikidata/Notes/ContentHandler: "Model and format may both change from revision to revision, though this may be confusing"
But T72901 addressed this: users can't change the content model of other users' pages unless they have editcontentmodel right (and we have not yet handed out this right).

http://lists.wikimedia.org/pipermail/wikitech-l/2012-March/059358.html

Version: unspecified
Severity: enhancement

DB change (completed)

gerrit change Id4e0f40c added the content model columns, @Springle completed the DB changes in October 2014.

All wikis
tables: page, revision, archive
changes: Content handler columns

MediaWiki cannot operate without these columns (fatal error) unless their use in core is disabled with wgContentHandlerUseDB (will be in wmf-production starting 1.21wmf2)
So gerrit 30068 disabled it pre-emptively in InitializeSettings.php --reedy

Adding rev_content_format field to table revision...
Adding rev_content_model field to table revision...
Adding ar_content_format field to table archive...
Adding ar_content_model field to table archive...
Adding page_content_model field to table page...

Details

Reference: bz49193

	Subject	Repo	Branch	Lines +/-
	$wgContentHandlerUseDB true everywhere	operations/mediawiki-config	master	+0 -14

Customize query in gerrit

Revisions and Commits

rOMWC Wikimedia - MediaWiki Config
	rOMWCb3e33fd92d4c $wgContentHandlerUseDB true everywhere
	rOMWCd480fc57f28d $wgContentHandlerUseDB true everywhere

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		Trizek-WMF	T115110 Track Flow activation
Open		None	T63747 Flow should be able to enumerate all flow enabled pages on a wiki
Resolved		None	T67604 Flow: enabling Flow on a LiquidThreads talk page doesn't work (LQT conversion)
Declined		EBernhardson	T63730 MediaWiki delete action doesn't work with pages that have been occupied by Flow
Resolved		SBisson	T72073 U4. Special page to enable Flow on existing wikitext talk pages, auto-archiving the wikitext page (v2)
Resolved		• Mattflaschen-WMF	T76781 future of wgFlowOccupyNamespaces
Resolved		EBernhardson	T76778 Co-op: respect contentmodel in the page DB.
Resolved		wctaiwan	T63255 Use ContentHandler based spamlist for MassMessage instead of parserfunction
Invalid		None	T51188 [DO NOT USE] Schema changes for Wikimedia wikis (tracking) [superseded by #Blocked-on-schema-change]
Duplicate		None	T64780 XML import problem in Page namespace
Resolved		Glaisher	T65885 Please enable $wgContentHandlerUseDB at Bengali Wikisource
Open	Feature	None	T70846 Flow: support Topic:OldPagename as a #REDIRECT
Declined		None	T78640 Co-op: bot can create a Flow board for each new mentored editor (tracking)
Resolved		None	T51193 Set $wgContentHandlerUseDB = true on all WMF wikis
Resolved		• csteipp	T72901 Users can change the content model of other users' user pages to CSS or JS

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:51 AM

• bzimport added a project: WMF-General-or-Unknown.

• bzimport set Reference to bz49193.

greg created this task.Jun 5 2013, 5:10 PM

Setting to enhancement/lowest as this is mostly a MediaWiki 2.0 thing :-)

(In reply to Greg Grossmeier from comment #1)

Setting to enhancement/lowest as this is mostly a MediaWiki 2.0 thing :-)

I don't think so. Flow and MassMessage will probably want/need to start using these fields soon, so it would be nice if we could get these columns added, or at least start the process. It's been about 3 MW versions now...

Sean: Bumping priority a bit on this one because as legoktm just said on IRC:
"we're going to need it for Flow at some point and the MassMessage GSoC project which will be ready by the end of the summer"

From June 11 SAL: 05:04 springle: beginning schema changes bug 49193 page_content_model

<springle> legoktm: page_content_model done, ar_content_* started, rev_content_* todo

There have been a couple of implicit and explicit requests for this, so I added bug 63885 and bug 62780. And Flow needs it to improve the way we enable Flow on a page, bug 70073.

How will WMF roll out the second part (the $wgContentHandlerUseDB = true config change)? We should test on Beta labs before production (InitialiseSettings-labs.php); will we then enable all production wikis at once or start with e.g. mediawikiwiki and the wikisource wikis whose users asked for it?

$wgContentHandlerUseDB is already set to true on testwikidatawiki and wikidatawiki, so I think we can just turn it on once the schema changes are finished, no need to do it wiki by wiki,

[05:29:18] <springle> legoktm: s3 content model fields are complete

That'll let us turn it on testwiki, test2wiki, and mediawikiwiki to start with.

Change 159089 had a related patch set uploaded by Legoktm:
Enable $wgContentHandlerUseDB on mediawikiwiki, testwiki, & test2wiki

https://gerrit.wikimedia.org/r/159089

Change 159089 merged by jenkins-bot:
Enable $wgContentHandlerUseDB on mediawikiwiki, testwiki, & test2wiki

https://gerrit.wikimedia.org/r/159089

Deployed by Erik, thanks!

Change 159457 had a related patch set uploaded by Spage:
Set wgContentHandlerDB true for enwiki-labs

https://gerrit.wikimedia.org/r/159457

Change 159457 merged by jenkins-bot:
Set wgContentHandlerDB true for enwiki-labs

https://gerrit.wikimedia.org/r/159457

Schema change is done on all wikis.

Change 170124 had a related patch set uploaded by Spage:
Typo in labs wgContentHandlerUseDB config

https://gerrit.wikimedia.org/r/170124

Change 170129 had a related patch set uploaded by Spage:
$wgContentHandlerUseDB true everywhere

https://gerrit.wikimedia.org/r/170129

Change 170124 merged by jenkins-bot:
Typo in labs wgContentHandlerUseDB config

https://gerrit.wikimedia.org/r/170124

• Mattflaschen-WMF merged a task: T1217: Enable $wgContentHandlerUseDB everywhere (bug 49193).Nov 25 2014, 8:48 PM

• Mattflaschen-WMF updated the task description. (Show Details)

• Mattflaschen-WMF set Security to None.

• Mattflaschen-WMF updated the task description. (Show Details)

• Mattflaschen-WMF added subscribers: Reedy, daniel, bd808.

Now that Scrum of Scrums and what used to be Bugzilla are both on Phabricator, I've merged in T1217: Enable $wgContentHandlerUseDB everywhere (bug 49193).

• Mattflaschen-WMF added projects: Scrum-of-Scrums, MediaWiki-Core-Team, Collaboration-Team-Triage.Nov 25 2014, 9:01 PM

• Spage changed the task status from Open to Stalled.Nov 26 2014, 10:26 PM

What's stalled here?

• Spage changed the task status from Stalled to Open.Dec 2 2014, 12:00 AM

• Spage moved this task from Untriaged to Scrum-of-scrums interdependencies on the Collaboration-Team-Triage board.Dec 3 2014, 12:30 PM

• Spage mentioned this in T76778: Co-op: respect contentmodel in the page DB..Dec 4 2014, 11:50 PM

• Spage merged a task: T1217: Enable $wgContentHandlerUseDB everywhere (bug 49193).Dec 5 2014, 1:36 AM

• Spage added a subscriber: EBernhardson.

• csteipp closed subtask T72901: Users can change the content model of other users' user pages to CSS or JS as Resolved.Dec 5 2014, 5:59 PM

Basically it seems T73163 is what is stalled here, to solve that I think requires rearchitecting parts of ContentHandler as it is a bit of a break from how ContentHandler currently works.

EBernhardson changed the task status from Open to Stalled.Dec 8 2014, 10:49 PM

• Spage moved this task from Scheduled to blocked by Services on the Scrum-of-Scrums board.Dec 12 2014, 11:01 PM

• Spage moved this task from blocked by Services to blocked by MediaWiki Core on the Scrum-of-Scrums board.Dec 13 2014, 12:44 AM

• Spage renamed this task from Add ContentHandler columns to Wikimedia wikis, and set $wgContentHandlerUseDB = true to Set $wgContentHandlerUseDB = true on all WMF wikis.Dec 15 2014, 10:52 PM

• Spage removed • Springle as the assignee of this task.

• Spage updated the task description. (Show Details)

bd808 removed a project: MediaWiki-Core-Team.Dec 22 2014, 10:41 PM

• Spage mentioned this in T62808: Flow: Core API actions succeed on Flow-enabled page.Dec 23 2014, 7:17 AM

jayvdb subscribed.Dec 27 2014, 10:25 AM

• Spage removed subtasks: T75490: Edits that change contentmodel cannot be reverted, T73163: Cannot edit old revisions if the content model of those revisions are different from the page's current revision.Jan 5 2015, 8:37 PM

If no one has the editcontentmodel right then this config change (which has been live on mediawiki.org for months) has no security implications, so I moved the tasks blocking this to the new task T85847.