Page MenuHomePhabricator
Create Task
Maniphest T282800

[wmf.5-regression] Help panel displays "growthexperiments-help-panel-suggested-edits-switch-editor-to-undefined"
Closed, ResolvedPublic
Actions

Description

Found when verifying T281716: [BUG] Add a link: Help panel incorrectly detects that user is in the source editor. The issue is in production - testwiki wmf.5.

(1)

  1. A user with a default option for an editor ("Remember my last editor") selects any task type (except Add link).
  2. A user goes to an article and switches to "Edit source". The Help panel will display a label, not a message:

Screen Shot 2021-05-13 at 9.53.02 AM.png (1×818 px, 167 KB)

wmf.4 displays the message correctly:

Screen Shot 2021-05-13 at 10.34.19 AM.png (1×786 px, 140 KB)

(2) mobile only for suggested Add link task

<div class="suggested-edits-panel-switch-editor-panel"><p>⧼growthexperiments-help-panel-suggested-edits-switch-editor-to-machineSuggestions⧽</p></div>

Screen Shot 2021-05-13 at 2.24.55 PM.png (1×734 px, 136 KB)

Details

SubjectRepoBranchLines +/-
Help panel: SwitchEditorPanel fixesmediawiki/extensions/GrowthExperimentsmaster+35 -3
Avoid session loading when loading task types in help panel RL datamediawiki/extensions/GrowthExperimentswmf/1.37.0-wmf.7+8 -2
Help panel: SwitchEditorPanel fixesmediawiki/extensions/GrowthExperimentswmf/1.37.0-wmf.7+35 -3
Avoid session loading when loading task types in help panel RL datamediawiki/extensions/GrowthExperimentswmf/1.37.0-wmf.6+8 -2
Help panel: SwitchEditorPanel fixesmediawiki/extensions/GrowthExperimentswmf/1.37.0-wmf.6+35 -3
Avoid session loading when loading task types in help panel RL datamediawiki/extensions/GrowthExperimentsmaster+8 -2
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.May 13 2021, 5:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 13 2021, 5:29 PM
Etonkovidova renamed this task from [betalabs-regression] Help panel displays messages as "growthexperiments-help-panel-suggested-edits-switch-editor-to-undefined" to [wmf.5-regression] Help panel displays messages as "growthexperiments-help-panel-suggested-edits-switch-editor-to-undefined".May 13 2021, 5:32 PM
Etonkovidova updated the task description. (Show Details)
Etonkovidova renamed this task from [wmf.5-regression] Help panel displays messages as "growthexperiments-help-panel-suggested-edits-switch-editor-to-undefined" to [wmf.5-regression] Help panel displays "growthexperiments-help-panel-suggested-edits-switch-editor-to-undefined".May 13 2021, 5:35 PM
Etonkovidova updated the task description. (Show Details)
Etonkovidova updated the task description. (Show Details)May 13 2021, 9:29 PM
Etonkovidova moved this task from Inbox to Upcoming Work on the Growth-Team board.May 13 2021, 9:58 PM
Etonkovidova triaged this task as High priority.May 13 2021, 10:06 PM
Etonkovidova edited projects, added Growth-Team (Sprint 0 (Growth Team)), Regression; removed Growth-Team.
Etonkovidova moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
Etonkovidova mentioned this in T281716: [BUG] Add a link: Help panel incorrectly detects that user is in the source editor.May 13 2021, 11:19 PM
• mewoph claimed this task.May 14 2021, 6:57 PM
• mewoph moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
• mewoph added a comment.May 14 2021, 7:05 PM

There are two issues here:

  1. The values for GENewcomerTasksTaskTypeHandlers can now be template-based, link-recommendation or null. When SuggestedEditsPanel is constructed, preferredEditor is using the task type as the key name. This works for link recommendation since the task type is the same as the task type handler ID, but for other task types, the handler ID is template-based.
  2. For mobile, currentEditor is visualeditor while preferredEditor is machineSuggestions. SwichEditorPanel shouldn't be shown in this case since machineSuggestions is a mode of visual editor.
gerritbot added a comment.May 14 2021, 8:37 PM

Change 691276 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Help panel: fixes of SwitchEditorPanel

https://gerrit.wikimedia.org/r/691276

gerritbot added a project: Patch-For-Review.May 14 2021, 8:37 PM
• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.May 14 2021, 8:37 PM
gerritbot added a comment.May 27 2021, 8:49 AM

Change 695833 had a related patch set uploaded (by Kosta Harlan; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.6] Help panel: SwitchEditorPanel fixes

https://gerrit.wikimedia.org/r/695833

gerritbot added a comment.May 27 2021, 8:49 AM

Change 695834 had a related patch set uploaded (by Kosta Harlan; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.7] Help panel: SwitchEditorPanel fixes

https://gerrit.wikimedia.org/r/695834

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.May 27 2021, 8:56 AM
gerritbot added a comment.May 27 2021, 9:10 AM

Change 691276 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Help panel: SwitchEditorPanel fixes

https://gerrit.wikimedia.org/r/691276

gerritbot added a comment.May 27 2021, 11:28 AM

Change 696329 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Avoid session loading when loading task types in help panel RL data

https://gerrit.wikimedia.org/r/696329

gerritbot added a comment.May 27 2021, 12:03 PM

Change 696329 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Avoid session loading when loading task types in help panel RL data

https://gerrit.wikimedia.org/r/696329

gerritbot added a comment.May 27 2021, 12:07 PM

Change 695841 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.6] Avoid session loading when loading task types in help panel RL data

https://gerrit.wikimedia.org/r/695841

gerritbot added a comment.May 27 2021, 12:08 PM

Change 695842 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.7] Avoid session loading when loading task types in help panel RL data

https://gerrit.wikimedia.org/r/695842

gerritbot added a comment.May 27 2021, 6:32 PM

Change 695833 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.6] Help panel: SwitchEditorPanel fixes

https://gerrit.wikimedia.org/r/695833

gerritbot added a comment.May 27 2021, 6:32 PM

Change 695841 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.6] Avoid session loading when loading task types in help panel RL data

https://gerrit.wikimedia.org/r/695841

gerritbot added a comment.May 27 2021, 6:32 PM

Change 695834 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.7] Help panel: SwitchEditorPanel fixes

https://gerrit.wikimedia.org/r/695834

gerritbot added a comment.May 27 2021, 6:32 PM

Change 695842 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.7] Avoid session loading when loading task types in help panel RL data

https://gerrit.wikimedia.org/r/695842

Stashbot mentioned this in T283765: link_suggestion_interaction schema: `close` action token is different from token in preceding action `editsummary_save`.May 27 2021, 6:49 PM

Mentioned in SAL (#wikimedia-operations) [2021-05-27T18:49:04Z] <tgr@deploy1002> Synchronized php-1.37.0-wmf.7/extensions/GrowthExperiments: Backport: [[gerrit:695834|Help panel: SwitchEditorPanel fixes (T282800)]] [[gerrit:695842|Avoid session loading when loading task types in help panel RL data (T282800)]] [[gerrit:696527|Add Link: Fix homepage PV token and newcomer task token logging (T283765)]] (duration: 01m 06s)

Stashbot added a comment.May 27 2021, 7:03 PM

Mentioned in SAL (#wikimedia-operations) [2021-05-27T19:03:22Z] <tgr@deploy1002> Synchronized php-1.37.0-wmf.6/extensions/GrowthExperiments: Backport: [[gerrit:695833|Help panel: SwitchEditorPanel fixes (T282800)]] [[gerrit:695841|Avoid session loading when loading task types in help panel RL data (T282800)]] [[gerrit:696530|Add Link: Fix homepage PV token and newcomer task token logging (T283765)]] (duration: 01m 05s)

Maintenance_bot removed a project: Patch-For-Review.May 27 2021, 7:10 PM
Etonkovidova closed this task as Resolved.Jun 8 2021, 1:36 AM

Checked in wmf.7 - the issue is fixed.

Etonkovidova mentioned this in T285283: [beta cluster-regression] Several controls display MediaWiki labels not text.Jun 21 2021, 11:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits