[BUG] Add a link: Help panel incorrectly detects that user is in the source editor
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	RHo
	May 3 2021, 2:27 PM

Description

List of steps to reproduce

Enable link recommendation on desktop.
Click on an Add a link task card from Special:Homepage
When link inspector loads tap to open the help panel and navigate to the "Add a link" guidance section

What happens?:
The guidance shows the message (incorrectly) warning that it is currently in the source editor mode

What should have happened instead?:
This message about being in the source editor should not appear

Details

	Subject	Repo	Branch	Lines +/-
	HelpPanel: Allow setting preferredEditor per task-type handler	mediawiki/extensions/GrowthExperiments	master	+11 -5

Customize query in gerrit

Related Objects

Mentioned In: T282800: [wmf.5-regression] Help panel displays "growthexperiments-help-panel-suggested-edits-switch-editor-to-undefined"
Mentioned Here: T282800: [wmf.5-regression] Help panel displays "growthexperiments-help-panel-suggested-edits-switch-editor-to-undefined"

Event Timeline

RHo created this task.May 3 2021, 2:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 3 2021, 2:27 PM

RHo updated the task description. (Show Details)May 3 2021, 2:28 PM

Change 684818 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] HelpPanel: Allow setting preferredEditor per task-type handler

https://gerrit.wikimedia.org/r/684818

gerritbot added a project: Patch-For-Review.May 4 2021, 1:07 PM

kostajh claimed this task.May 4 2021, 1:07 PM

kostajh triaged this task as Medium priority.

kostajh moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 684818 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] HelpPanel: Allow setting preferredEditor per task-type handler

https://gerrit.wikimedia.org/r/684818

Maintenance_bot removed a project: Patch-For-Review.May 6 2021, 11:10 PM

Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.May 13 2021, 12:10 PM

Etonkovidova mentioned this in T282800: [wmf.5-regression] Help panel displays "growthexperiments-help-panel-suggested-edits-switch-editor-to-undefined".May 13 2021, 5:29 PM

On mobile the message ⧼growthexperiments-help-panel-suggested-edits-switch-editor-to-machineSuggestions⧽ is still present. It's reproducible in a browser mobile emulator. The desktop works fine.

Steps to reproduce

on mobile (or in a browser mobile emulator) with a default option "Remember my last editor", go to a suggested Add link article
click on the help icon - the ⧼growthexperiments-help-panel-suggested-edits-switch-editor-to-machineSuggestions⧽

The incorrectly displayed raw label is reported as a part of T282800.