Page MenuHomePhabricator
Create Task
Maniphest T278118

Instrumentation: Edit summary
Closed, ResolvedPublic
Actions

Description

Associated features: T269657: Add a link: edit summary and publish, T269658: Add a link: skipped all suggestions dialog

We need to record when the user attempts to advance to the edit summary screen, which can be done either through selecting the explicit “Publish/Submit” button or by advancing/skipping from the last link suggestion. When they do this, we should record which route they took.

If the user has skipped all suggestions, they’ll get the “skipped all suggestion dialog”. We should record:

  • Impression for the dialog.
  • An event for which button the user selects.

If the user has not skipped all suggestions, they’ll go to the edit summary screen. We need to record:

  • Impression for the screen, along with counts for its contents, e.g. “7 accepted, 2 rejected, 1 skipped”
  • An event when the user selects the option to “Review your changes”
  • An event when the user selects the arrow to return to the article.
  • An event when the user selects the Publish/Submit button.

Details

SubjectRepoBranchLines +/-
AddLink: Instrumentation for edit summary dialogmediawiki/extensions/GrowthExperimentswmf/1.37.0-wmf.5+24 -0
AddLink: Instrumentation for skipall_dialogmediawiki/extensions/GrowthExperimentswmf/1.37.0-wmf.5+8 -1
AddLink: Instrumentation for edit summary dialogmediawiki/extensions/GrowthExperimentsmaster+24 -0
AddLink: Instrumentation for skipall_dialogmediawiki/extensions/GrowthExperimentsmaster+8 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

kostajh created this task.Mar 22 2021, 12:33 PM
kostajh mentioned this in T273827: Add a link: instrumentation.
kostajh mentioned this in T269657: Add a link: edit summary and publish.
kostajh moved this task from Backlog to Post-release backlog on the Add-Link board.
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh updated the task description. (Show Details)Mar 24 2021, 10:29 AM
kostajh moved this task from Post-release backlog to April 19 - April 23 on the Add-Link board.Mar 29 2021, 11:32 AM
kostajh moved this task from Ready for Development to Incoming on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 30 2021, 7:12 AM
kostajh triaged this task as Medium priority.Apr 14 2021, 12:53 PM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:47 PM
kostajh updated the task description. (Show Details)Apr 19 2021, 10:56 AM
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Apr 20 2021, 9:21 AM
• Rileych removed a project: Growth-Team-Filtering.Apr 20 2021, 4:28 PM
leila unsubscribed.Apr 20 2021, 4:51 PM
kostajh moved this task from April 19 - April 23 to April 26 - April 30 on the Add-Link board.Apr 26 2021, 9:40 AM
MBinder_WMF unsubscribed.Apr 26 2021, 5:37 PM
kostajh moved this task from April 26 - April 30 to May 3 - May 7 on the Add-Link board.May 3 2021, 2:42 PM
kostajh claimed this task.May 7 2021, 7:16 AM
kostajh moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh moved this task from May 3 - May 7 to May 10 - May 14 on the Add-Link board.May 10 2021, 3:45 PM
gerritbot added a comment.May 11 2021, 12:26 PM

Change 689016 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] AddLink: Instrumentation for skipall_dialog

https://gerrit.wikimedia.org/r/689016

gerritbot added a project: Patch-For-Review.May 11 2021, 12:26 PM

Change 689017 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] AddLink: Instrumentation for edit summary dialog

https://gerrit.wikimedia.org/r/689017

kostajh moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.May 11 2021, 12:28 PM
gerritbot added a comment.May 13 2021, 10:54 AM

Change 690072 had a related patch set uploaded (by Gergő Tisza; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.5] AddLink: Instrumentation for skipall_dialog

https://gerrit.wikimedia.org/r/690072

gerritbot added a comment.May 13 2021, 10:56 AM

Change 690073 had a related patch set uploaded (by Gergő Tisza; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.5] AddLink: Instrumentation for edit summary dialog

https://gerrit.wikimedia.org/r/690073

gerritbot added a comment.May 13 2021, 11:18 AM

Change 689016 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] AddLink: Instrumentation for skipall_dialog

https://gerrit.wikimedia.org/r/689016

gerritbot added a comment.May 13 2021, 11:18 AM

Change 689017 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] AddLink: Instrumentation for edit summary dialog

https://gerrit.wikimedia.org/r/689017

Tgr moved this task from May 10 - May 14 to Done / QA on the Add-Link board.May 13 2021, 12:03 PM
Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.May 13 2021, 12:13 PM

Change 690072 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.5] AddLink: Instrumentation for skipall_dialog

https://gerrit.wikimedia.org/r/690072

gerritbot added a comment.May 13 2021, 12:13 PM

Change 690073 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.5] AddLink: Instrumentation for edit summary dialog

https://gerrit.wikimedia.org/r/690073

Stashbot mentioned this in T278487: Instrumentation: Number of phrases not found in document.May 13 2021, 12:40 PM
Stashbot mentioned this in T278116: Instrumentation: Link inspector.
Stashbot mentioned this in T278114: Instrumentation: Suggestions mode.
Stashbot mentioned this in T278117: Instrumentation: Rejection dialog.
Stashbot mentioned this in T278112: Instrumentation: dialog for no suggestions available.
Stashbot mentioned this in T278111: Instrumentation: Onboarding.
Stashbot mentioned this in T278177: Add a link: create new Schema.

Mentioned in SAL (#wikimedia-operations) [2021-05-13T12:40:40Z] <tgr@deploy1002> Synchronized php-1.37.0-wmf.5/extensions/GrowthExperiments: Backport: instrumentation patches ([[gerrit:690070|]] [[gerrit:690071|]] [[gerrit:690072|]] [[gerrit:690073|]]) (T278116 T278117 T278114 T278177 T278487 T278112 T278111 T278118) (duration: 01m 09s)

Maintenance_bot removed a project: Patch-For-Review.May 13 2021, 1:10 PM
Etonkovidova closed this task as Resolved.Jun 18 2021, 10:44 PM

If the user has skipped all suggestions, they’ll get the “skipped all suggestion dialog”. We should record:

  • Impression for the dialog.
  • An event for which button the user selects.

The events seem to be in place:

{action: "impression", action_data: "", is_mobile: false, active_interface: "skipall_dialog", newcomer_task_token: "87c2ddde0c8d19cc7fe3", …}
$schema: "/analytics/mediawiki/structured_task/article/link_suggestion_interaction/1.0.0"
action: "impression"
action_data: ""
active_interface: "skipall_dialog"
dt: "2021-06-16T20:40:17.524Z"
homepage_pageview_token: "9rqpa1ttbgpn4ddqsm3btsh5oifks3d4"
is_mobile: false
meta: {stream: "mediawiki.structured_task.article.link_suggestion_interaction", domain: "test.wikipedia.org"}
newcomer_task_token: "87c2ddde0c8d19cc7fe3"
page_id: 114747
page_title: "Julian Wilson (surfer)"
  • Skip all
{action: "confirm_skip_all_suggestions", action_data: "", is_mobile: false, active_interface: "skipall_dialog", newcomer_task_token: "87c2ddde0c8d19cc7fe3", …}
$schema: "/analytics/mediawiki/structured_task/article/link_suggestion_interaction/1.0.0"
action: "confirm_skip_all_suggestions"
action_data: ""
active_interface: "skipall_dialog"
dt: "2021-06-16T20:41:46.305Z"
homepage_pageview_token: "9rqpa1ttbgpn4ddqsm3btsh5oifks3d4"
is_mobile: false
meta: {stream: "mediawiki.structured_task.article.link_suggestion_interaction", domain: "test.wikipedia.org"}
newcomer_task_token: "87c2ddde0c8d19cc7fe3"
page_id: 114747
page_title: "Julian Wilson (surfer)"
  • Review again (for a different user, hence newcomer_task_token is different).
{action: "review_again", action_data: "", is_mobile: false, active_interface: "skipall_dialog", newcomer_task_token: "48358dda58799341c9c5", …}
$schema: "/analytics/mediawiki/structured_task/article/link_suggestion_interaction/1.0.0"
action: "review_again"
action_data: ""
active_interface: "skipall_dialog"
dt: "2021-06-16T20:45:29.140Z"
homepage_pageview_token: "e0jlquiq4dsstkrq1lvl7lqmo9vifen4"
is_mobile: false
meta: {stream: "mediawiki.structured_task.article.link_suggestion_interaction", domain: "test.wikipedia.org"}
newcomer_task_token: "48358dda58799341c9c5"
page_id: 114946
page_title: "Victorious Boxers 2: Fighting Spirit"

If the user has not skipped all suggestions, they’ll go to the edit summary screen. We need to record:

  • Impression for the screen, along with counts for its contents, e.g. “7 accepted, 2 rejected, 1 skipped”
{action: "impression", action_data: "accepted_count=2;rejected_count=0;skipped_count=7", is_mobile: false, active_interface: "editsummary_dialog", newcomer_task_token: "40127ae6673420d1f256", …}
$schema: "/analytics/mediawiki/structured_task/article/link_suggestion_interaction/1.0.0"
action: "impression"
action_data: "accepted_count=2;rejected_count=0;skipped_count=7"
active_interface: "editsummary_dialog"
dt: "2021-06-18T22:38:38.123Z"
homepage_pageview_token: "sblnikp33cf4986ml4qjof74uun72b1u"
is_mobile: false
meta: {stream: "mediawiki.structured_task.article.link_suggestion_interaction", domain: "test.wikipedia.org"}
newcomer_task_token: "40127ae6673420d1f256"
page_id: 113872
page_title: "Gibraltar Hockey Association"
  • An event when the user selects the option to “Review your changes”
{action: "editsummary_review", action_data: "", is_mobile: false, active_interface: "editsummary_dialog", newcomer_task_token: "40127ae6673420d1f256", …}
$schema: "/analytics/mediawiki/structured_task/article/link_suggestion_interaction/1.0.0"
action: "editsummary_review"
action_data: ""
active_interface: "editsummary_dialog"
dt: "2021-06-18T22:39:59.501Z"
homepage_pageview_token: "sblnikp33cf4986ml4qjof74uun72b1u"
is_mobile: false
meta: {stream: "mediawiki.structured_task.article.link_suggestion_interaction", domain: "test.wikipedia.org"}
newcomer_task_token: "40127ae6673420d1f256"
page_id: 113872
page_title: "Gibraltar Hockey Association"
  • An event when the user selects the arrow to return to the article.
{action: "editsummary_approve", action_data: "", is_mobile: false, active_interface: "editsummary_dialog", newcomer_task_token: "40127ae6673420d1f256", …}
$schema: "/analytics/mediawiki/structured_task/article/link_suggestion_interaction/1.0.0"
action: "editsummary_approve"
action_data: ""
active_interface: "editsummary_dialog"
dt: "2021-06-18T22:41:09.724Z"
homepage_pageview_token: "sblnikp33cf4986ml4qjof74uun72b1u"
is_mobile: false
meta: {stream: "mediawiki.structured_task.article.link_suggestion_interaction", domain: "test.wikipedia.org"}
newcomer_task_token: "40127ae6673420d1f256"
page_id: 113872
page_title: "Gibraltar Hockey Association"
  • An event when the user selects the Publish/Submit button.
{action: "editsummary_save", action_data: "", is_mobile: false, active_interface: "editsummary_dialog", newcomer_task_token: "40127ae6673420d1f256", …}
$schema: "/analytics/mediawiki/structured_task/article/link_suggestion_interaction/1.0.0"
action: "editsummary_save"
action_data: ""
active_interface: "editsummary_dialog"
dt: "2021-06-18T22:41:40.213Z"
homepage_pageview_token: "sblnikp33cf4986ml4qjof74uun72b1u"
is_mobile: false
meta: {stream: "mediawiki.structured_task.article.link_suggestion_interaction", domain: "test.wikipedia.org"}
newcomer_task_token: "40127ae6673420d1f256"
page_id: 113872
page_title: "Gibraltar Hockey Association"
{action: "close", action_data: "", is_mobile: false, active_interface: "editsummary_dialog", newcomer_task_token: "40127ae6673420d1f256", …}
$schema: "/analytics/mediawiki/structured_task/article/link_suggestion_interaction/1.0.0"
action: "close"
action_data: ""
active_interface: "editsummary_dialog"
dt: "2021-06-18T22:41:40.505Z"
homepage_pageview_token: "sblnikp33cf4986ml4qjof74uun72b1u"
is_mobile: false
meta: {stream: "mediawiki.structured_task.article.link_suggestion_interaction", domain: "test.wikipedia.org"}
newcomer_task_token: "40127ae6673420d1f256"
page_id: 113872
page_title: "Gibraltar Hockey Association"
MMiller_WMF mentioned this in T294672: Image instrumentation: edit summary.Oct 29 2021, 11:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits