Add a link: skipped all suggestions dialog
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	MMiller_WMF
	Dec 8 2020, 6:02 AM

Description

If the user skips all the offered link suggestions, their "Publish/Submit" button is never activated (per T269638). But they may still skip all the way to the end of the list of suggested links. If they select "Skip" on the final suggestion, without having selected "Yes" or "No" on any of the previous ones, then this dialog appears.

Header: "You've skipped all suggestions for this article."
Body: "Are you sure you don't want to accept or reject any suggestions?"
First button: "Skip all"
- This button takes the user to the "no changes post-edit state" described in T269659: Add a link: post-edit dialog.
Second button: "Review again".
- This button closes the dialog and the user is back on the final suggestion, which is where they tapped/clicked that last skip button that opened the dialog.

Mobile mockups as of 2021-01-12:

Desktop mockups as of 2021-01-12:

NOTE: Refer to Figma for up-to-date detailed redline mocks and specs:
Mobile: https://www.figma.com/file/2SONd8P1tsexIB5coMOp8h/Growth-Structured-tasks?node-id=181%3A65
Desktop: https://www.figma.com/file/2SONd8P1tsexIB5coMOp8h/Growth-Structured-tasks?node-id=112%3A0

Instrumentation

See T273827: Add a link: instrumentation for details.

If the user has skipped all suggestions, they’ll get the “skipped all suggestion dialog”. We should record:

Impression for the dialog.
An event for which button the user selects.

Details

	Subject	Repo	Branch	Lines +/-
	Add GENDER to skip dialog messages	mediawiki/extensions/GrowthExperiments	master	+2 -2
	Add Link: "skipped all suggestions" dialog	mediawiki/extensions/GrowthExperiments	master	+44 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	MMiller_WMF	T252822 [EPIC] Growth: "add a link" structured task 1.0
Resolved	kostajh	T268704 Add a link: frontend product specifications
Resolved	Tgr	T269658 Add a link: skipped all suggestions dialog

Event Timeline

MMiller_WMF created this task.Dec 8 2020, 6:02 AM

@MMiller_WMF sometime this week or next could you add specifications here please?

MMiller_WMF updated the task description. (Show Details)Jan 22 2021, 2:06 AM

MMiller_WMF updated the task description. (Show Details)Feb 19 2021, 4:02 AM

kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 25 2021, 9:50 PM

Tgr claimed this task.Mar 1 2021, 7:28 PM

Tgr moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

MMiller_WMF updated the task description. (Show Details)Mar 13 2021, 2:02 AM

MMiller_WMF updated the task description. (Show Details)Mar 15 2021, 8:40 PM

Tgr mentioned this in T277519: Add Links: answer cannot be unselected.Mar 16 2021, 11:42 AM

kostajh moved this task from Backlog to Post-release backlog on the Add-Link board.Mar 22 2021, 10:45 AM

kostajh updated the task description. (Show Details)Mar 24 2021, 11:20 AM

kostajh moved this task from Post-release backlog to March 29 - April 2 on the Add-Link board.Mar 29 2021, 11:22 AM

My changes for link inspector (T269644) may impact the work here. I updated next button action on the link inspector of the last recommendation to save the article if user has decided on any of the recommendations and to currently no-op if the user skipped all the recommendations (with the idea that the dialog from this task would be shown). This might not be needed depending on how this dialog is implemented (if it's shown as part of the ArticleTarget's save command, the logic in the next button action is probably not needed).

/**
 * Move the selection to the next suggestion if it exists, if the user is on the last recommendation:
 * fire an event to save the article if user decided on any of the recommendations
 * show skipped all suggestions dialog if user didn't decide on any of the recommendations
 *
 * @param {number} nextIndex Zero-based index of the next suggestion in the linkRecommendationFragments array
 */
RecommendedLinkContextItem.prototype.onNextActionClicked = function ( nextIndex ) {
	if ( nextIndex === this.getRecommendationInfo().total ) {
		if ( this.allRecommendationsSkipped() ) {
			// TODO: Show skip all suggestions dialog (T269658)
		} else {
			mw.hook( 'growthExperiments.contextItem.saveArticle' ).fire();
		}
	} else {
		this.moveToSuggestion( nextIndex );
	}
};

kostajh moved this task from March 29 - April 2 to April 5 - April 9 on the Add-Link board.Apr 6 2021, 12:36 PM

kostajh triaged this task as Medium priority.Apr 13 2021, 2:10 PM

kostajh moved this task from April 5 - April 9 to April 12 - April 16 on the Add-Link board.

MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:48 PM

kostajh moved this task from April 12 - April 16 to April 19 - April 23 on the Add-Link board.Apr 19 2021, 9:51 AM

kostajh mentioned this in T278118: Instrumentation: Edit summary.Apr 19 2021, 10:56 AM

• Rileych removed a project: Growth-Team-Filtering.Apr 20 2021, 4:34 PM

leila unsubscribed.Apr 20 2021, 4:50 PM

kostajh moved this task from April 19 - April 23 to April 26 - April 30 on the Add-Link board.Apr 26 2021, 9:38 AM

MBinder_WMF unsubscribed.Apr 26 2021, 5:37 PM

Change 683296 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Add Link: "skipped all suggestions" dialog

https://gerrit.wikimedia.org/r/683296

gerritbot added a project: Patch-For-Review.Apr 28 2021, 2:30 PM

I used the standard OOUI confirmation dialog, which looks slighly different from the design (the dialog title is styled a bit differently; also since the task description had shorter button texts, the buttons end up next to each other). Let me know if that's an issue.

• mewoph moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Apr 28 2021, 5:55 PM

Change 683296 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add Link: "skipped all suggestions" dialog

https://gerrit.wikimedia.org/r/683296

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).Apr 28 2021, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 28 2021, 7:10 PM

• mewoph moved this task from April 26 - April 30 to Done / QA on the Add-Link board.Apr 28 2021, 11:21 PM

Etonkovidova updated the task description. (Show Details)Apr 29 2021, 11:44 PM

Note: the instrumentation is not done yet.

for @RHo review - there is @Tgr comment above explains that the standard OOUI confirmation dialog was implemented. The screenshots below show how the dialog looks now:

Desktop (betalabs)	Mobile (betalabs)

Change 683828 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Add GENDER to skip dialog messages

https://gerrit.wikimedia.org/r/683828

gerritbot added a project: Patch-For-Review.Apr 30 2021, 10:40 AM

Change 683828 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add GENDER to skip dialog messages

https://gerrit.wikimedia.org/r/683828

Maintenance_bot removed a project: Patch-For-Review.Apr 30 2021, 11:10 AM

In T269658#7047708, @Etonkovidova wrote:

Note: the instrumentation is not done yet.

for @RHo review - there is @Tgr comment above explains that the standard OOUI confirmation dialog was implemented. The screenshots below show how the dialog looks now:

Desktop (betalabs) Mobile (betalabs)

Thanks @Etonkovidova, and @Tgr, that's fine. I have checked on cswiki what happens if the button text is long and it overflows correctly to two full-width buttons so fine to resolve

Catrope unsubscribed.May 3 2021, 4:15 PM

MMiller_WMF mentioned this in T290910: Add an image: skip button functionality for image inspector.Oct 2 2021, 12:26 AM

	F34434864: Screen Shot 2021-04-28 at 11.54.47 AM.png
	Apr 29 2021, 11:52 PM

	F34434866: Screen Shot 2021-04-29 at 12.55.40 PM.png
	Apr 29 2021, 11:52 PM

	F34439080: image.png
	May 3 2021, 3:56 PM

	F34011498: image.png
	Jan 22 2021, 2:06 AM

	F34011500: image.png
	Jan 22 2021, 2:06 AM

Add a link: skipped all suggestions dialogClosed, ResolvedPublicActions