Page MenuHomePhabricator
Create Task
Maniphest T145736

Article::doEdit() and WikiPage::doEdit() are deprecated
Closed, ResolvedPublic
Actions

Description

Once all subtasks are resolved, we should enable deprecation warnings for this function.

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm created this task.Sep 15 2016, 8:23 AM
Legoktm created subtask T145737: API unit tests should not call WikiPage::doEdit().
Legoktm created subtask T145738: CentralNotice should not call WikiPage::doEdit().Sep 15 2016, 8:26 AM
Legoktm created subtask T145739: FlaggedRevs should not call WikiPage::doEdit().
Legoktm created subtask T145740: NewUserMessage should not call WikiPage::doEdit().Sep 15 2016, 8:30 AM
Legoktm created subtask T145741: OpenStackManager should not call WikiPage::doEdit().
Legoktm created subtask T145743: Wikibase unit tests should not call WikiPage::doEdit().Sep 15 2016, 8:34 AM
Legoktm created subtask T145744: addWiki.php should not call WikiPage::doEdit().
Legoktm created subtask T145745: SpamBlacklist's cleanup.php should not call WikiPage::doEdit.
Legoktm closed subtask T145744: addWiki.php should not call WikiPage::doEdit() as Resolved.Sep 15 2016, 4:38 PM
Legoktm closed subtask T145741: OpenStackManager should not call WikiPage::doEdit() as Resolved.
Legoktm closed subtask T145745: SpamBlacklist's cleanup.php should not call WikiPage::doEdit as Resolved.Sep 15 2016, 10:56 PM
Legoktm closed subtask T145739: FlaggedRevs should not call WikiPage::doEdit() as Resolved.
Legoktm closed subtask T145737: API unit tests should not call WikiPage::doEdit() as Resolved.Sep 15 2016, 10:58 PM
Reedy closed subtask T145740: NewUserMessage should not call WikiPage::doEdit() as Resolved.Sep 16 2016, 10:08 AM
daniel closed subtask T145743: Wikibase unit tests should not call WikiPage::doEdit() as Resolved.Sep 20 2016, 5:01 PM
gerritbot subscribed.Sep 21 2016, 7:49 PM

Change 312085 had a related patch set uploaded (by Reedy):
Replace WikiPage::doEdit()

https://gerrit.wikimedia.org/r/312085

gerritbot added a project: Patch-For-Review.Sep 21 2016, 7:49 PM
gerritbot added a comment.Sep 21 2016, 7:52 PM

Change 312088 had a related patch set uploaded (by Reedy):
Replace WikiPage::doEdit()

https://gerrit.wikimedia.org/r/312088

gerritbot added a comment.Sep 21 2016, 7:53 PM

Change 312090 had a related patch set uploaded (by Reedy):
Remove WikiPage::doEdit() call

https://gerrit.wikimedia.org/r/312090

gerritbot added a comment.Sep 21 2016, 7:56 PM

Change 312092 had a related patch set uploaded (by Reedy):
Replace WikiPage::doEdit()

https://gerrit.wikimedia.org/r/312092

Reedy subscribed.Sep 21 2016, 7:57 PM

That's commits for all WikiPage::doEdit(), bar one guarded call in SMW

gerritbot added a comment.Sep 21 2016, 8:08 PM

Change 312095 had a related patch set uploaded (by Reedy):
Replace Article::doEdit()

https://gerrit.wikimedia.org/r/312095

Reedy mentioned this in T146316: LqtView::postEditUpdates still used in import-parsed-discussions.php.Sep 21 2016, 8:09 PM
gerritbot added a comment.Sep 21 2016, 8:14 PM

Change 312098 had a related patch set uploaded (by Reedy):
Add deprecated comment to Article::doEdit()

https://gerrit.wikimedia.org/r/312098

gerritbot added a comment.Sep 21 2016, 8:19 PM

Change 312099 had a related patch set uploaded (by Reedy):
Replace Article::doEdit()

https://gerrit.wikimedia.org/r/312099

gerritbot added a comment.Sep 21 2016, 8:28 PM

Change 312103 had a related patch set uploaded (by Reedy):
Replace Article::doEdit()

https://gerrit.wikimedia.org/r/312103

gerritbot added a comment.Sep 21 2016, 8:32 PM

Change 312106 had a related patch set uploaded (by Reedy):
Replace Article::doEdit()

https://gerrit.wikimedia.org/r/312106

gerritbot added a comment.Sep 21 2016, 8:52 PM

Change 312111 had a related patch set uploaded (by Reedy):
Remove old Article::doEdit() call

https://gerrit.wikimedia.org/r/312111

gerritbot added a comment.Sep 22 2016, 4:32 AM

Change 312098 merged by jenkins-bot:
Add deprecated comment to Article::doEdit()

https://gerrit.wikimedia.org/r/312098

ReleaseTaggerBot added projects: MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)).Sep 22 2016, 5:00 AM
gerritbot added a comment.Sep 22 2016, 6:02 AM

Change 312106 merged by jenkins-bot:
Replace Article::doEdit()

https://gerrit.wikimedia.org/r/312106

gerritbot added a comment.Sep 22 2016, 6:02 AM

Change 312103 merged by jenkins-bot:
Replace Article::doEdit()

https://gerrit.wikimedia.org/r/312103

Nemo_bis triaged this task as Medium priority.Sep 22 2016, 1:49 PM
gerritbot added a comment.Sep 23 2016, 8:01 AM

Change 312095 merged by jenkins-bot:
Replace Article::doEdit()

https://gerrit.wikimedia.org/r/312095

enigmaeth closed subtask T145738: CentralNotice should not call WikiPage::doEdit() as Resolved.Sep 27 2016, 2:23 PM
gerritbot added a comment.Sep 27 2016, 3:13 PM

Change 313021 had a related patch set uploaded (by Enigmaeth):
Emit deprecation warnings for Article::doEdit and WikiPage::doEdit

https://gerrit.wikimedia.org/r/313021

gerritbot added a comment.Sep 28 2016, 7:49 PM

Change 313248 had a related patch set uploaded (by Reedy):
One more doEdit() -> doEditContent()

https://gerrit.wikimedia.org/r/313248

gerritbot added a comment.Sep 28 2016, 9:12 PM

Change 312099 merged by jenkins-bot:
Replace Article::doEdit()

https://gerrit.wikimedia.org/r/312099

gerritbot added a comment.Sep 28 2016, 9:22 PM

Change 313248 merged by jenkins-bot:
One more doEdit() -> doEditContent()

https://gerrit.wikimedia.org/r/313248

gerritbot added a comment.Sep 29 2016, 7:33 AM

Change 313021 merged by jenkins-bot:
Emit deprecation warnings for Article::doEdit and WikiPage::doEdit

https://gerrit.wikimedia.org/r/313021

enigmaeth closed this task as Resolved.Sep 29 2016, 9:47 AM
enigmaeth claimed this task.
gerritbot added a comment.Oct 2 2016, 3:49 AM

Change 312085 merged by jenkins-bot:
Replace WikiPage::doEdit()

https://gerrit.wikimedia.org/r/312085

gerritbot added a comment.Oct 2 2016, 3:49 AM

Change 312088 merged by jenkins-bot:
Replace WikiPage::doEdit()

https://gerrit.wikimedia.org/r/312088

gerritbot added a comment.Oct 6 2016, 10:58 PM

Change 312111 merged by jenkins-bot:
Remove old Article::doEdit() call

https://gerrit.wikimedia.org/r/312111

gerritbot added a comment.Dec 11 2016, 12:37 AM

Change 312090 merged by Reedy:
Remove WikiPage::doEdit() call

https://gerrit.wikimedia.org/r/312090

gerritbot added a comment.Dec 11 2016, 12:37 AM

Change 312092 merged by Reedy:
Replace WikiPage::doEdit()

https://gerrit.wikimedia.org/r/312092

gerritbot added a comment.Jan 18 2017, 10:18 PM

Change 332881 had a related patch set uploaded (by Reedy):
Fix remaining usage of doEdit in SemanticComments

https://gerrit.wikimedia.org/r/332881

gerritbot added a comment.Jan 19 2017, 12:47 AM

Change 332881 merged by jenkins-bot:
Fix remaining usage of doEdit in SemanticComments

https://gerrit.wikimedia.org/r/332881

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits