Page MenuHomePhabricator
Create Task
Maniphest T145728

Clean up ContentHandler deprecated functions and hooks
Closed, ResolvedPublic
Actions

Description

The ContentHandler project deprecated a bunch of stuff. Many of those functions and hooks are still in active use and don't emit deprecation warnings. Given that we have another large refactoring planned (MCR), we should clean up this technical debt first.

This task should be closed once all hooks and functions deprecated by ContentHandler are emitting deprecation warnings (e.g. using wfDeprecated). That means updating at least all Wikimedia-deployed extensions.

functiondeprecated noticedeprecated func doccomment
Article::getContent()noyestasks filed
Article::fetchContent()yesyestasks filed
Article::doEdit() / WikiPage::doEdit()yesyestasks filed
Article::getText()yesyesno apparent usages
Revision::getText()yesyesused by WikiPage::getText() and various extensions (Echo, MobileFrontend, MWSearch, SpamBlacklist...).
WikiPage::getText()yesyestasks filed
WikiRevision::getText()yesyesno apparent uses
WikiPage::getAutosummary()yesyestasks filed
Article::getAutosummary()(done in WikiPage)yesonly used in ArticleTest::testStaticFunctions()
Article::prepareTextForEdit()(done in WikiPage)yestasks filed
WikiPage::prepareTextForEdit()yesyestasks filed

Hooks (crossed out means marked as deprecated when called):

  • ArticleAfterFetchContent
  • ArticleInsertComplete
  • ArticleSave
  • ArticleSaveComplete
  • ArticleViewCustom
  • EditFilterMerged
  • EditPageGetDiffText
  • EditPageGetPreviewText
  • ShowRawCssJs
  • TitleIsCssOrJsPage
  • TitleIsWikitextPage

Details

Show related patches Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedFilipT145728 Clean up ContentHandler deprecated functions and hooks
 ResolvedReedyT145729 Article::getContent() is deprecated
 ResolvedReedyT145730 DynamicSidebar should not call Article::getContent()
 ResolvedReedyT145731 LiquidThreads should not call Article::getContent()
 ResolvedReedyT145732 TimedMediaHandler should not call Article::getContent()
 ResolvedReedyT145733 TitleBlacklist should not call Article::getContent()
 ResolvedReedyT147713 Collection shouldn't call Article::getContent()
 ResolvedReedyT147714 OpenStackManager should not call Article::getContent()
 ResolvedReedyT147715 SecurePoll shouldn't call Article::getContent()
 ResolvedReedyT145734 Article::fetchContent() is deprecated
 ResolveddanielT145735 RSS should not call Article::fetchContent()
 ResolvedenigmaethT146191 AccessControl should not use Article::fetchContent() anymore
 ResolvedYaron_KorenT146192 ApprovedRevs should not use Article::fetchContent() anymore
 ResolvedNoneT146193 BibManager should not use Article::fetchContent() anymore
 ResolvedrohittT146194 BlueSpiceFoundation should not use Article::fetchContent() anymore
 ResolvedrohittT146195 Contest should not use Article::fetchContent() anymore
 DeclinedNoneT146196 ConventionExtension should not use Article::fetchContent() anymore
 ResolvedReedyT146197 EtherEditor should not use Article::fetchContent() anymore
 ResolvedenigmaethT146198 ExternalData should not use Article::fetchContent() anymore
 ResolvedFilipT146199 OracleTextSearch should not use Article::fetchContent() anymore
 ResolvedReedyT146200 PdfBook should not use Article::fetchContent() anymore
 InvalidNoneT146201 ReplaceText should not use Article::fetchContent() anymore
 ResolvedFlorianT146203 Wikilog should not use Article::fetchContent() anymore
 ResolvedenigmaethT145736 Article::doEdit() and WikiPage::doEdit() are deprecated
 ResolvedReedyT145737 API unit tests should not call WikiPage::doEdit()
 ResolvedenigmaethT145738 CentralNotice should not call WikiPage::doEdit()
 ResolvedReedyT145739 FlaggedRevs should not call WikiPage::doEdit()
 ResolvedReedyT145740 NewUserMessage should not call WikiPage::doEdit()
 ResolvedReedyT145741 OpenStackManager should not call WikiPage::doEdit()
 ResolvedReedyT145743 Wikibase unit tests should not call WikiPage::doEdit()
 ResolvedReedyT145744 addWiki.php should not call WikiPage::doEdit()
 ResolvedReedyT145745 SpamBlacklist's cleanup.php should not call WikiPage::doEdit
 ResolveddanielT145747 Article::getText() is deprecated
 ResolvedenigmaethT145750 WikiPage::getText() is deprecated
 Resolved• Mattflaschen-WMFT145751 PageTriage should not call WikiPage::getText()
 ResolvedenigmaethT145753 OpenStackManager should not call WikiPage::getText()
 ResolvedenigmaethT146994 Echo's ContainmentSet::getValues should not use deprecated $article->getText()
ResolvedrafidaslamT179532 Call to undefined method WikiPage::getText()
 ResolveddanielT146161 Article::getAutosummary() is deprecated and unused, should emit warnings.
 ResolveddanielT146164 WikiPage::getAutosummary() is deprecated and should emit warnings once unused by known code
 ResolveddanielT146162 WikiRevision::getText() is deprecated and unused, should emit warnings
 ResolvedReedyT146168 WikiPage::prepareTextForEdit() is deprecated and should emit warnings once unused in known code
 ResolvedJdforrester-WMFT146166 Article::prepareTextForEdit() is deprecated and should emit warnings once unused by known code
 ResolvedReedyT146167 BlueSpice should not call deprecated Article::prepareTextForEdit()
 ResolvedNoneT146170 SMW should not use deprecated WikiPage::prepareTextForEdit()
ResolvedReedyT147380 Revision::getText() is deprecated
 ResolvedReedyT147382 Hook ArticleViewCustom is deprecated
 ResolvedLegoktmT147383 Hook EditPageGetDiffText is deprecated
 ResolvedReedyT147384 Hook EditPageGetPreviewText is deprecated
 ResolvedLegoktmT147385 Hook TitleIsCssOrJsPage is deprecated
 ResolvedLegoktmT147386 Hook TitleIsWikitextPage is deprecated
 ResolvedReedyT147387 Hook ArticleAfterFetchContent is deprecated
 ResolvedReedyT147388 Hook ArticleInsertComplete is deprecated
 ResolvedReedyT147554 PageTriage uses ArticleInsertComplete hook
 ResolvedReedyT147389 Hook ArticleSave is deprecated
 ResolvedReedyT147390 Hook ArticleSaveComplete is deprecated
 ResolvedLegoktmT147556 Gadgets extension uses ArticleSaveComplete hook
 ResolvedReedyT147560 LiquidThreads uses deprecated ArticleSaveComplete hook
 ResolvedReedyT147561 ProofreadPage extension uses deprecated ArticleSaveComplete hook
 ResolvedReedyT147555 FeaturedFeeds uses deprecated ArticleSaveComplete hook
 ResolvedReedyT147559 Echo extension uses deprecated ArticleSaveComplete hook
 ResolvedReedyT147558 TitleBlacklist extension uses ArticleSaveComplete hook
 ResolvedReedyT147391 Hook EditFilterMerged is deprecated
 ResolvedLegoktmT147564 EventLogging uses deprecated EditFilterMerged hook
 ResolvedLegoktmT147565 Scribunto uses deprecated EditFilterMerged hook
 ResolvedReedyT147566 UploadWizard uses deprecated EditFilterMerged hook
 ResolvedReedyT147392 Hook ShowRawCssJs is deprecated
 ResolvedReedyT151973 Cleanup ContentHandler deprecated function calls in other Extensions
 InvalidNoneT153009 EditFilterMerged hook still used in Wikidata
 ResolvedFilipT154498 Remove remaining ContentHandler deprecated functions and hooks
 ResolvedFilipT147924 Identify/Cleanup ContentHandler deprecated calls (and hook subscribers) in Wikitech specific extensions branches

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a project: Patch-For-Review.Oct 5 2016, 12:22 AM
Reedy created subtask T147387: Hook ArticleAfterFetchContent is deprecated.Oct 5 2016, 12:25 AM
Reedy created subtask T147388: Hook ArticleInsertComplete is deprecated.
Reedy created subtask T147389: Hook ArticleSave is deprecated.
Reedy created subtask T147390: Hook ArticleSaveComplete is deprecated.
Reedy created subtask T147391: Hook EditFilterMerged is deprecated.
Reedy created subtask T147392: Hook ShowRawCssJs is deprecated.
Reedy updated the task description. (Show Details)Oct 5 2016, 12:30 AM
Liuxinyu970226 subscribed.Oct 5 2016, 2:25 AM
Jdforrester-WMF triaged this task as Medium priority.Oct 5 2016, 4:51 PM
Reedy added a comment.Oct 5 2016, 11:17 PM

Heads up.. We're getting close to the the end of the 1.28 development cycle... So if we want to get stuff marked as deprecated in this release, we've only got a few more weeks to get it really done (else we're backporting to the 1.28 branch etc)

I'll evaluate those hooks I created tasks for (87-92) and see about making some more patches...

From the core side, we're mostly there, just a couple more deprecation notices to bring in... Extensions, well, hopefully the deprecated notices will help out there

gerritbot added a comment.Oct 6 2016, 12:42 AM

Change 314208 merged by jenkins-bot:
Mark 3 hooks deprecated by ContentHandler as such

https://gerrit.wikimedia.org/r/314208

Legoktm closed subtask T147383: Hook EditPageGetDiffText is deprecated as Resolved.Oct 6 2016, 12:50 AM
Legoktm closed subtask T147385: Hook TitleIsCssOrJsPage is deprecated as Resolved.
Legoktm closed subtask T147386: Hook TitleIsWikitextPage is deprecated as Resolved.
Reedy closed subtask T147382: Hook ArticleViewCustom is deprecated as Resolved.Oct 6 2016, 9:43 AM
Reedy closed subtask T147384: Hook EditPageGetPreviewText is deprecated as Resolved.Oct 6 2016, 9:49 AM
Reedy closed subtask T147380: Revision::getText() is deprecated as Resolved.Oct 6 2016, 11:30 AM
Reedy updated the task description. (Show Details)Oct 6 2016, 1:17 PM
Reedy updated the task description. (Show Details)
Reedy updated the task description. (Show Details)Oct 6 2016, 1:24 PM
Reedy updated the task description. (Show Details)
Reedy updated the task description. (Show Details)Oct 6 2016, 1:34 PM

So, for functions, just https://gerrit.wikimedia.org/r/#/c/314548/ for prepareTextForEdit and that's them all done...

gerritbot added a comment.Oct 6 2016, 2:21 PM

Change 314565 had a related patch set uploaded (by Reedy):
Final deprecation of ContentHandler hooks

https://gerrit.wikimedia.org/r/314565

gerritbot added a comment.Oct 6 2016, 10:50 PM

Change 314556 had a related patch set uploaded (by Reedy):
Make more ContentHandler replaced hooks emit deprecation warnings

https://gerrit.wikimedia.org/r/314556

gerritbot added a comment.Oct 6 2016, 10:58 PM

Change 314556 merged by jenkins-bot:
Make more ContentHandler replaced hooks emit deprecation warnings

https://gerrit.wikimedia.org/r/314556

Jdforrester-WMF updated the task description. (Show Details)Oct 6 2016, 11:03 PM
Jdforrester-WMF closed subtask T147392: Hook ShowRawCssJs is deprecated as Resolved.
Reedy updated the task description. (Show Details)Oct 6 2016, 11:21 PM
Reedy closed subtask T147389: Hook ArticleSave is deprecated as Resolved.Oct 6 2016, 11:23 PM
Reedy closed subtask T147387: Hook ArticleAfterFetchContent is deprecated as Resolved.
gerritbot added a comment.Oct 6 2016, 11:30 PM

Change 314630 had a related patch set uploaded (by Reedy):
Deprecation of 2 more ContentHandler hooks

https://gerrit.wikimedia.org/r/314630

gerritbot added a comment.Oct 6 2016, 11:50 PM

Change 314630 merged by jenkins-bot:
Deprecation of 2 more ContentHandler hooks

https://gerrit.wikimedia.org/r/314630

Reedy closed subtask T147390: Hook ArticleSaveComplete is deprecated as Resolved.Oct 7 2016, 12:03 AM
Reedy closed subtask T147388: Hook ArticleInsertComplete is deprecated as Resolved.
Reedy updated the task description. (Show Details)
Reedy updated the task description. (Show Details)Oct 8 2016, 11:47 AM
Reedy added a subtask: T111651: Convert TimedText to make use of ContentHandler.Oct 8 2016, 12:11 PM
gerritbot added a comment.Oct 8 2016, 12:31 PM

Change 314821 had a related patch set uploaded (by Reedy):
Remove ContentHandler::deprecated()

https://gerrit.wikimedia.org/r/314821

Paladox subscribed.Oct 9 2016, 5:29 PM
gerritbot added a comment.Oct 10 2016, 5:31 PM

Change 315137 had a related patch set uploaded (by Paladox):
Mark 1 hooks deprecated by ContentHandler as such

https://gerrit.wikimedia.org/r/315137

gerritbot added a comment.Oct 10 2016, 5:33 PM

Change 315137 abandoned by Paladox:
Mark 1 hooks deprecated by ContentHandler as such

Reason:
https://gerrit.wikimedia.org/r/#/c/314565/2

https://gerrit.wikimedia.org/r/315137

Paladox added a comment.Oct 10 2016, 6:03 PM

Should we also deprecate it here https://github.com/wikimedia/mediawiki-debian/blob/6a4a101a0091a8684784156635058a6f532cbfe7/includes/page/Article.php#L826

Reedy added a comment.Oct 10 2016, 6:35 PM
In T145728#2704097, @Paladox wrote:

Should we also deprecate it here https://github.com/wikimedia/mediawiki-debian/blob/6a4a101a0091a8684784156635058a6f532cbfe7/includes/page/Article.php#L826

No, that's 1.27

Reedy created subtask T147924: Identify/Cleanup ContentHandler deprecated calls (and hook subscribers) in Wikitech specific extensions branches.Oct 12 2016, 11:46 AM
Jdforrester-WMF closed subtask T146166: Article::prepareTextForEdit() is deprecated and should emit warnings once unused by known code as Resolved.Oct 12 2016, 11:02 PM
Jdforrester-WMF closed subtask T146168: WikiPage::prepareTextForEdit() is deprecated and should emit warnings once unused in known code as Resolved.
Jdforrester-WMF updated the task description. (Show Details)
Reedy closed subtask T145729: Article::getContent() is deprecated as Resolved.Oct 12 2016, 11:47 PM
gerritbot added a comment.Oct 12 2016, 11:48 PM

Change 314821 merged by jenkins-bot:
Remove ContentHandler::deprecated()

https://gerrit.wikimedia.org/r/314821

ReleaseTaggerBot added projects: MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)).Oct 13 2016, 12:00 AM
Reedy created subtask T148137: Deprecate $wgContentHandlerUseDB.Oct 14 2016, 11:41 AM
gerritbot added a comment.Oct 15 2016, 6:41 AM

Change 314565 merged by jenkins-bot:
Deprecate EditFilterMerged hook, final ContentHandler replaced hook

https://gerrit.wikimedia.org/r/314565

Legoktm closed subtask T147391: Hook EditFilterMerged is deprecated as Resolved.Oct 15 2016, 6:42 AM
TheDJ removed a subtask: T111651: Convert TimedText to make use of ContentHandler.Oct 20 2016, 9:39 AM
Reedy updated the task description. (Show Details)Nov 30 2016, 12:54 AM
Reedy removed projects: MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)), Patch-For-Review.
Reedy mentioned this in T151973: Cleanup ContentHandler deprecated function calls in other Extensions.Nov 30 2016, 12:59 AM
Reedy created subtask T151973: Cleanup ContentHandler deprecated function calls in other Extensions.
gerritbot added a comment.Dec 1 2016, 12:41 PM

Change 324703 had a related patch set uploaded (by Reedy):
Remove ContentHandler functions with no usages at all

https://gerrit.wikimedia.org/r/324703

gerritbot added a project: Patch-For-Review.Dec 1 2016, 12:41 PM
gerritbot added a comment.Dec 1 2016, 12:47 PM

Change 324705 had a related patch set uploaded (by Reedy):
Article::getAutosummary() and WikiPage::getAutosummary() were removed

https://gerrit.wikimedia.org/r/324705

gerritbot added a comment.Dec 1 2016, 1:13 PM

Change 324710 had a related patch set uploaded (by Reedy):
ArticleViewCustom, EditPageGetDiffText and ShowRawCssJs were removed

https://gerrit.wikimedia.org/r/324710

Reedy mentioned this in T152282: WikiRevision::getText() needs fixing up.Dec 3 2016, 12:21 PM
gerritbot added a comment.Dec 3 2016, 12:57 PM

Change 324703 merged by jenkins-bot:
Remove ContentHandler functions with no usages at all

https://gerrit.wikimedia.org/r/324703

gerritbot added a comment.Dec 3 2016, 12:59 PM

Change 324705 merged by jenkins-bot:
Article::getAutosummary() and WikiPage::getAutosummary() were removed

https://gerrit.wikimedia.org/r/324705

ReleaseTaggerBot added projects: MW-1.29-release (WMF-deploy-2016-12-06_(1.29.0-wmf.5)), MW-1.29-release-notes.Dec 3 2016, 1:00 PM
gerritbot added a comment.Dec 3 2016, 1:01 PM

Change 324710 merged by jenkins-bot:
ArticleViewCustom, EditPageGetDiffText and ShowRawCssJs were removed

https://gerrit.wikimedia.org/r/324710

Reedy added a subtask: T152282: WikiRevision::getText() needs fixing up.Dec 10 2016, 12:25 AM
gerritbot added a comment.Dec 12 2016, 1:12 AM

Change 326382 had a related patch set uploaded (by Reedy):
WikiPage::prepareTextForEdit() was removed

https://gerrit.wikimedia.org/r/326382

gerritbot added a comment.Dec 12 2016, 2:45 PM

Change 326382 merged by jenkins-bot:
WikiPage::prepareTextForEdit() was removed

https://gerrit.wikimedia.org/r/326382

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)).Dec 12 2016, 3:00 PM
gerritbot added a comment.Dec 12 2016, 6:52 PM

Change 326498 had a related patch set uploaded (by Reedy):
WikiPage::getText() was removed

https://gerrit.wikimedia.org/r/326498

gerritbot added a comment.Dec 12 2016, 7:10 PM

Change 326498 merged by jenkins-bot:
WikiPage::getText() was removed

https://gerrit.wikimedia.org/r/326498

gerritbot added a comment.Dec 12 2016, 7:21 PM

Change 326507 had a related patch set uploaded (by Reedy):
Article::fetchContent() was removed

https://gerrit.wikimedia.org/r/326507

gerritbot added a comment.Dec 12 2016, 8:14 PM

Change 326507 merged by jenkins-bot:
Article::fetchContent() was removed

https://gerrit.wikimedia.org/r/326507

Reedy created subtask T153009: EditFilterMerged hook still used in Wikidata.Dec 12 2016, 8:49 PM
Reedy closed subtask T153009: EditFilterMerged hook still used in Wikidata as Invalid.Dec 13 2016, 2:13 PM
Reedy closed subtask T151973: Cleanup ContentHandler deprecated function calls in other Extensions as Resolved.Jan 3 2017, 4:53 PM
Reedy closed subtask T145734: Article::fetchContent() is deprecated as Resolved.
Reedy mentioned this in T147924: Identify/Cleanup ContentHandler deprecated calls (and hook subscribers) in Wikitech specific extensions branches.Jan 3 2017, 5:01 PM
Reedy created subtask T154498: Remove remaining ContentHandler deprecated functions and hooks.Jan 3 2017, 5:28 PM
Reedy mentioned this in T154498: Remove remaining ContentHandler deprecated functions and hooks.Jan 3 2017, 9:57 PM
SamanthaNguyen moved this task from Unsorted to Cleanup on the Technical-Debt board.Jan 3 2017, 10:05 PM
gerritbot added a comment.Jan 7 2017, 10:39 AM

Change 331118 had a related patch set uploaded (by Filip):
Removed deprecated function 'Article::getContent()'

https://gerrit.wikimedia.org/r/331118

Filip closed subtask T147924: Identify/Cleanup ContentHandler deprecated calls (and hook subscribers) in Wikitech specific extensions branches as Resolved.Jan 10 2017, 7:13 PM
Filip subscribed.Jan 15 2017, 11:07 AM

We only need to resolve T154498 , and everything will be done.

Jdforrester-WMF removed a subtask: T152282: WikiRevision::getText() needs fixing up.Jan 19 2017, 3:16 AM
Reedy closed subtask T154498: Remove remaining ContentHandler deprecated functions and hooks as Resolved.Jan 19 2017, 3:17 AM
Jdforrester-WMF removed a subtask: T148137: Deprecate $wgContentHandlerUseDB.Jan 19 2017, 4:26 PM

OK, all child tasks are now Resolved (or moved away)… so can we close this?

Filip added a comment.Jan 19 2017, 4:27 PM

@Reedy: So its done? All subtasks are gone

Filip closed this task as Resolved.Jan 19 2017, 4:28 PM
Filip claimed this task.
Liuxinyu970226 unsubscribed.Jan 20 2017, 1:35 AM
Florian awarded a token.Jan 21 2017, 6:48 PM
gerritbot added a comment.Feb 8 2017, 2:44 AM

Change 331118 abandoned by Reedy:
Removed deprecated function 'Article::getContent()'

https://gerrit.wikimedia.org/r/331118

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits