Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially refactors map manager and moves a lot of the logic into the map system. Half of the changes are just updates to unit tests to avoid obsolete warnings and to get rid of explicit map Ids.
IMO all the map code should eventually be moved to the system as I don't know of any reason not to, its nice being able to use all the entity system convenience methods, and having the functionality split between a manager & system is just kind of awkward.
Requires space-wizards/space-station-14/pull/26994
Changes:
IMapManager
toMapSystem
IMapManagerInternal.CreateMap()
IMapManager.RemoveMapId()
IMapManager.NextMapId()
IMapManager.GetGridComp()
IMapManager.GetAllGrids()
IEntityManager.InitializeAndStartEntity
override that allows you to specify whether the entity should get map-initialized