Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python): Switch over some of the custom Python date/time conversions to native PyO3 conversions #16203

Merged
merged 9 commits into from
May 14, 2024
Merged

chore(python): Switch over some of the custom Python date/time conversions to native PyO3 conversions #16203

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
39c1b3f
Start converting to native PyO3 chrono support.
pythonspeed May 10, 2024
2451201
Convert more functions to PyO3 conversion instead of custom Polars co…
pythonspeed May 13, 2024
5aea1ea
Another replacement of Python conversion with PyO3 conversion.
pythonspeed May 13, 2024
2c69743
Start switching away from to-Python serialization.
pythonspeed May 13, 2024
b9cc590
Pacify clippy.
pythonspeed May 13, 2024
84a2141
Merge remote-tracking branch 'origin/main' into 16158-native-pyo3-dat…
pythonspeed May 13, 2024
30fdd5b
Ended up not using chrono-tz in this iteration.
pythonspeed May 13, 2024
07b5252
cargo fmt
pythonspeed May 13, 2024
e65955a
Merge branch 'main' into 16158-native-pyo3-datetime-support
itamarst May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Pacify clippy.
  • Loading branch information
@pythonspeed
pythonspeed committed May 13, 2024
commit b9cc59099ab64a107ebf455eb7df822f33b76746
16 changes: 8 additions & 8 deletions py-polars/src/conversion/chunked_array.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ use pyo3::intern;
use pyo3::prelude::*;
use pyo3::types::{PyBytes, PyList, PyTuple};

use super::datetime::elapsed_offset_to_timedelta;
use super::datetime::nanos_since_midnight_to_naivetime;
use super::datetime::timestamp_to_naive_datetime;
use super::datetime::{
elapsed_offset_to_timedelta, nanos_since_midnight_to_naivetime, timestamp_to_naive_datetime,
};
use super::{decimal_to_digits, struct_dict};
use crate::prelude::*;
use crate::py_modules::UTILS;
Expand Down Expand Up @@ -90,19 +90,19 @@ impl ToPyObject for Wrap<&TimeChunked> {
}
}

pub(crate) fn time_to_pyobject_iter<'a>(
ca: &'a TimeChunked,
) -> impl 'a + ExactSizeIterator<Item = Option<NaiveTime>> {
pub(crate) fn time_to_pyobject_iter(
ca: &TimeChunked,
) -> impl '_ + ExactSizeIterator<Item = Option<NaiveTime>> {
ca.0.into_iter()
.map(move |opt_v| opt_v.map(|v| nanos_since_midnight_to_naivetime(v)))
.map(move |opt_v| opt_v.map(nanos_since_midnight_to_naivetime))
}

impl ToPyObject for Wrap<&DateChunked> {
fn to_object(&self, py: Python) -> PyObject {
let iter = self
.0
.into_iter()
.map(|opt_v| opt_v.map(|v| date32_to_date(v)));
.map(|opt_v| opt_v.map(date32_to_date));
PyList::new_bound(py, iter).into_py(py)
}
}
Expand Down