chore(python): Switch over some of the custom Python date/time conversions to native PyO3 conversions #16203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itamarst
commented
May 13, 2024
| Ok(av) | ||
| }) | ||
| let timedelta = ob.extract::<TimeDelta>()?; | ||
| if let Some(micros) = timedelta.num_microseconds() { |
There was a problem hiding this comment.
Tried nanoseconds here, it broke the tests, so stuck to micro/milliseconds only.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16203 +/- ##
==========================================
+ Coverage 80.93% 81.03% +0.10%
==========================================
Files 1393 1393
Lines 179559 178941 -618
Branches 2907 2907
==========================================
- Hits 145331 145013 -318
+ Misses 33722 33423 -299
+ Partials 506 505 -1 ☔ View full report in Codecov by Sentry. |
|
Thanks! Can you rebase? |
|
@ritchie46 I fixed the conflict. If you literally want a rebase I can do that too. |
|
Nope, the conflict is fine. ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16158
This should probably give a performance boost for relevant code, but I didn't check.
Things I didn't touch: