Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observable field initialization and dyn refactor #6

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Observable field initialization and dyn refactor #6

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
ec84eae
Add validation to initial value so it behaves like a set. All init v…
AlexMouton Nov 28, 2024
b2bd59a
Rewrite FieldVector makeDynInner dyn to scan instead of using combine…
AlexMouton Dec 9, 2024
01ab796
Remove logs from FieldParse
AlexMouton Dec 11, 2024
0aeaf01
Fix UseField dyn construction to use switchSequence on init and dyn f…
AlexMouton Dec 11, 2024
126fd51
Prepend init observable to front of dyn when adding a channel to an e…
AlexMouton Dec 11, 2024
1d7d763
Add small #Void hack to tickle dyns to get initial state editable.
AlexMouton Dec 13, 2024
6c41d99
replace #Void hack with a startsWith
AlexMouton Dec 14, 2024
d0a25b3
Remove unused x
AlexMouton Dec 14, 2024
d902bb2
Silence warnings
AlexMouton Dec 14, 2024
385756f
Added key management to FieldArray.
AlexMouton Dec 14, 2024
35a7f96
Specify type on key mutable ref.
AlexMouton Dec 17, 2024
70b1515
Comment
AlexMouton Dec 17, 2024
945559c
Silence Warning?
AlexMouton Dec 17, 2024
31de471
Rename x.
AlexMouton Dec 17, 2024
a100e73
Fix Addition of successive array elements resetting value. etc.
AlexMouton Dec 18, 2024
176d2f7
Reexpand Everything example
AlexMouton Dec 18, 2024
421aa6a
Remove some logs.
AlexMouton Dec 18, 2024
d3b76bb
Add key to state options.
AlexMouton Dec 18, 2024
1639d39
Fix Array reset
AlexMouton Dec 18, 2024
8272954
Added init consideration to Array reset.
AlexMouton Dec 18, 2024
98d428e
Improve tests with Test.chain...avoids multiple changes in the same t…
AlexMouton Dec 19, 2024
f0a5d14
Repair local rescript-rxjs import.
AlexMouton Dec 19, 2024
bfd8298
DRY out makeDyn testing scaffolding.
AlexMouton Dec 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Comment
  • Loading branch information
@AlexMouton
AlexMouton committed Dec 17, 2024
commit 70b1515b72f7ed156b70d0f812c0809d8764b341
2 changes: 1 addition & 1 deletion src/FieldArray.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ type actions<'finput, 'factions, 'out> = {
module type Make = (F: Field.T, I: IArray with type t = F.t ) => T
with type input = array<F.input>
and type inputElement = F.input
// Array maintains keys for elements here
// Array maintains keys for elements here, to help React know when to unmount
and type inner = array<(key, F.t)>
and type output = array<F.output>
and type error = error
Expand Down