-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Observable field initialization and dyn refactor #6
Open
AlexMouton
wants to merge
23
commits into
noble-ai:main
Choose a base branch
from
AlexMouton:axm-init-refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lidations must complete before dynamic behavior beings....could be too strict.
…Latest so we dont get hung up waiting for each element to emit before one can emit.
…lows instead of either waiting for init to finish, or steping on init immediately with a switchSequenced dyn
…xisting array, so that initialization can execute for that element.
Summary: Test Plan:
…ick, usually what you want
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to address the existing Issues.
Added an "init" field to Dyn so that each Field maintains a static first value, an Observable of the initial validation of any set value, and the Observable<Observable> for user changes. Init is required to complete before user dynamic changes begin.
This also refactors Either and Vector to be more similar and simpler. And attacks Array for a lot of reasons as well.
A