Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Support For Environment Proxy (http, https, no_proxy) #73

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+146 −106
Open

Full Support For Environment Proxy (http, https, no_proxy) #73

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d8f568b
Reflecting Dockerfile-netbootxyz changes
Mionsz Oct 7, 2024
88f97d5
HTTP and HTTPS proxy agents added
Mionsz Oct 7, 2024
c908234
Dockerfile code improvements and labeles added.
Mionsz Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Dockerfile code improvements and labeles added. 
Dockerfile code improvements and labeles added.
The improvements include using bash as default shell
for bettter error detection while performing install
and start of container.

Signed-off-by: Milosz Linkiewicz <[email protected]>
  • Loading branch information
@Mionsz
Mionsz committed Oct 7, 2024
commit c90823481e0230edf7ff0e4a1941b015f7633f9d
34 changes: 22 additions & 12 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,21 @@
FROM alpine:3.18

# set version label
ARG BUILD_DATE
ARG VERSION
ARG WEBAPP_VERSION
LABEL build_version="netboot.xyz version: ${VERSION} Build-date: ${BUILD_DATE}"
LABEL maintainer="antonym"
ARG BUILD_DATE="10/7/2024"
ARG VERSION="0.7.3"
ARG WEBAPP_VERSION="0.7.3"

LABEL org.opencontainers.image.authors="[email protected]"
LABEL org.opencontainers.image.url="https://github.com/netbootxyz/webapp"
LABEL org.opencontainers.image.title="NetBoot.xyz WebApp"
LABEL org.opencontainers.image.description="NetBoot.xyz WebApp: A NodeJS helper application for managing local deployments of netboot.xyz"
LABEL org.opencontainers.image.documentation="https://netboot.xyz/docs/docker"
LABEL org.opencontainers.image.version="${WEBAPP_VERSION}"
LABEL org.opencontainers.image.vendor="https://NetBoot.xyz"
LABEL org.opencontainers.image.licenses="Apache-2.0 license"

RUN apk add --no-cache bash
SHELL ["/bin/bash", "-e", "-o", "pipefail", "-c"]

RUN \
apk upgrade --no-cache && \
Expand All @@ -26,15 +36,13 @@ RUN \
supervisor \
syslog-ng \
tar \
tftp-hpa

RUN \
tftp-hpa && \
groupmod -g 1000 users && \
useradd -u 911 -U -d /config -s /bin/false nbxyz && \
usermod -G users nbxyz && \
mkdir /app \
/config \
/defaults
/defaults

COPY . /app

Expand All @@ -43,10 +51,12 @@ RUN \

ENV TFTPD_OPTS=''

EXPOSE 3000
EXPOSE 8080
EXPOSE 69/UDP 80/TCP 3000/TCP 8080/TCP
VOLUME ["/assets", "/config"]

COPY root/ /
CMD ["/start.sh"]
SHELL ["/bin/bash", "-c"]

# default command
CMD ["sh","/start.sh"]
ENTRYPOINT ["/start.sh"]