Full Support For Environment Proxy (http, https, no_proxy) #73
+146
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1e06ab to
72e5725
Compare
Fiooodooor
approved these changes
Oct 5, 2024
Mionsz
commented
Oct 7, 2024
vangorra
suggested changes
Oct 7, 2024
Reflecting Dockerfile-netbootxyz changes. Split the `start.sh` entrypoint file: - init.sh - prepares environment and directories on first run - start.sh - entrypoint script that runs supervisord and init.sh Made basic set of parameters (ports) configurable. Now the `default` file need to be templated before first run. Minor fixes due to supervisor failing. Added proxy settings from environment pass to WebApplication Signed-off-by: Milosz Linkiewicz <[email protected]>
HTTP and HTTPS proxy agents added. Now every link connection before cration is checked against environment variables: - http_proxy/HTTP_PROXY, - https_proxy/HTTPS_PROXY, - no_proxy/NO_PROXY, It is determined if connection should be routed throug proxy server. This includes: - DownloaderHelper. - Socket fetch. - Devgetbrowser method. Fix to Readdirp handling after migration to v4.0.0. Signed-off-by: Milosz Linkiewicz <[email protected]>
Dockerfile code improvements and labeles added. The improvements include using bash as default shell for bettter error detection while performing install and start of container. Signed-off-by: Milosz Linkiewicz <[email protected]>
|
I've changed it as you mentioned. IF you find some time I would be grateful for a review :). BTW the project if really awesome! |
|
@antonym @vangorra @thelamer ping and review request. @cp-whatcha could you check if this works for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full http_proxy https_proxy, no_proxy suupport:
Support for http_proxy, https_proxyh and no_proxy environment variables implemented. This include reading variables from process environment, comparing request_url with no_proxy cidr's and names, and of course setting and redirecting requests using proxy or corporate proxy services. This does not impact by any means the DHCP and TFTP services - only webapp.
Environments read for comparision:
http_proxy||HTTP_PROXYhttps_proxt||HTTPS_PROXYno_proxy||NO_PROXYImplemented and/or extended:
One method for each approach getProxyAgentFromUrl().
Almost no changes to the code are needed.
This fully resolves: #66