Skip to content

Commit

Permalink
pythonGH-115978: Disable *readv() and *writev() on WASI (pythonGH…
Browse files Browse the repository at this point in the history
…-116228)

Wasmtime doesn't implement these functions in a way to pass test_posix (bytecodealliance/wasmtime#7830).
(cherry picked from commit 5dc8c84)

Co-authored-by: Brett Cannon <[email protected]>
  • Loading branch information
brettcannon authored and miss-islington committed Mar 2, 2024
1 parent 90f75e1 commit d561b05
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Disable preadv(), readv(), pwritev(), and writev() on WASI.

Under wasmtime for WASI 0.2, these functions don't pass test_posix
(https://github.com/bytecodealliance/wasmtime/issues/7830).
9 changes: 9 additions & 0 deletions Tools/wasm/config.site-wasm32-wasi
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,12 @@ ac_cv_header_netpacket_packet_h=no

# Disable int-conversion for wask-sdk as it triggers an error from version 17.
ac_cv_disable_int_conversion=yes

# preadv(), readv(), pwritev(), and writev() under wasmtime's WASI 0.2 support
# do not use more than the first buffer provided, failing under test_posix.
# Since wasmtime will not be changing this behaviour, disable the functions.
# https://github.com/bytecodealliance/wasmtime/issues/7830
ac_cv_func_preadv=no
ac_cv_func_readv=no
ac_cv_func_pwritev=no
ac_cv_func_writev=no

0 comments on commit d561b05

Please sign in to comment.