Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off preadv(), readv(), pwritev(), and writev() under WASI #115978

Closed
brettcannon opened this issue Feb 26, 2024 · 0 comments
Closed

Turn off preadv(), readv(), pwritev(), and writev() under WASI #115978

brettcannon opened this issue Feb 26, 2024 · 0 comments
Labels
3.11 only security fixes 3.12 bugs and security fixes 3.13 bugs and security fixes OS-wasi type-bug An unexpected behavior, bug, or error

Comments

@brettcannon
Copy link
Member

brettcannon commented Feb 26, 2024

Bug report

Bug description:

The POSIX functions preadv(), readv(), pwritev(), and writev() don't work as expected under WASI 0.2 on wasmtime. Since there are no plans to change that as their semantics are still POSIX-compliant, we should turn them off for WASI via https://github.com/python/cpython/blob/main/Tools/wasm/config.site-wasm32-wasi .

CPython versions tested on:

CPython main branch

Operating systems tested on:

Other

Linked PRs

@brettcannon brettcannon added type-bug An unexpected behavior, bug, or error OS-wasi 3.11 only security fixes 3.12 bugs and security fixes 3.13 bugs and security fixes labels Feb 26, 2024
brettcannon added a commit to brettcannon/cpython that referenced this issue Mar 1, 2024
Wasmtime doesn't implement them in a way to pass test_posix (bytecodealliance/wasmtime#7830).

This fix allows running under WASI 0.2 primitives for wasmtime.
brettcannon added a commit that referenced this issue Mar 2, 2024
Wasmtime doesn't implement these functions in a way to pass test_posix (bytecodealliance/wasmtime#7830).
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Mar 2, 2024
…-116228)

Wasmtime doesn't implement these functions in a way to pass test_posix (bytecodealliance/wasmtime#7830).
(cherry picked from commit 5dc8c84)

Co-authored-by: Brett Cannon <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Mar 2, 2024
…-116228)

Wasmtime doesn't implement these functions in a way to pass test_posix (bytecodealliance/wasmtime#7830).
(cherry picked from commit 5dc8c84)

Co-authored-by: Brett Cannon <[email protected]>
brettcannon added a commit that referenced this issue Mar 2, 2024
…) (GH-116231)

GH-115978: Disable `*readv()` and `*writev()` on WASI (GH-116228)

Wasmtime doesn't implement these functions in a way to pass test_posix (bytecodealliance/wasmtime#7830).
(cherry picked from commit 5dc8c84)

Co-authored-by: Brett Cannon <[email protected]>
brettcannon added a commit that referenced this issue Mar 2, 2024
…) (GH-116232)

GH-115978: Disable `*readv()` and `*writev()` on WASI (GH-116228)

Wasmtime doesn't implement these functions in a way to pass test_posix (bytecodealliance/wasmtime#7830).
(cherry picked from commit 5dc8c84)

Co-authored-by: Brett Cannon <[email protected]>
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this issue Mar 4, 2024
…-116228)

Wasmtime doesn't implement these functions in a way to pass test_posix (bytecodealliance/wasmtime#7830).
adorilson pushed a commit to adorilson/cpython that referenced this issue Mar 25, 2024
…-116228)

Wasmtime doesn't implement these functions in a way to pass test_posix (bytecodealliance/wasmtime#7830).
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
…-116228)

Wasmtime doesn't implement these functions in a way to pass test_posix (bytecodealliance/wasmtime#7830).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.11 only security fixes 3.12 bugs and security fixes 3.13 bugs and security fixes OS-wasi type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

1 participant