made changes to AlterUser to accept maxUserConnections #723
+9
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmontes11
requested changes
Jul 18, 2024
|
@AayushVinayDev it would be great if you could add a test to prove that this functionallity works as expected. Also, make sure you rebase with |
|
This PR is stale because it has been open 60 days with no activity. |
|
This PR is stale because it has been open 60 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to address the issue reported in #685.
To handle the users more dynamically, I've extended the AlterUser() to accept maxUserConnections. For this I've also made maxUserConnections mutable.
Please let me know of my shortcomings :D
I'll be happy to tweak this further if needed.