Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] modifying users? #685

Closed
pasztorl opened this issue Jun 13, 2024 · 4 comments · Fixed by #918
Closed

[Feature] modifying users? #685

pasztorl opened this issue Jun 13, 2024 · 4 comments · Fixed by #918
Labels
feature good first issue Good for newcomers help wanted Extra attention is needed sql

Comments

@pasztorl
Copy link

If I create an User object the maxUserConnections become immutable. So If I want to adjust this setting I need to recreate the user. I think this is not so good in prod environment because when I delete the user the application can't connect to it, so it will be a downtime while the new user not created by the operator. So can you please consider to manage the users more dynamically?
Thanks!
@mmontes11 mmontes11 added the sql label Jun 25, 2024
@mmontes11
Copy link
Member

Hey there!

Fair enough! We have significantly improved the SQL object reconciliation in the last release, managing the updates of the User password, we could extend the ALTER USER statement used for reconciliation and also update the max connections.

For making this usable, we also need to make the maxConnections mutable, as you pointed out.

Contributions welcome!

@mmontes11 mmontes11 added help wanted Extra attention is needed good first issue Good for newcomers labels Jun 25, 2024
@AayushVinayDev
Copy link

Hi @mmontes11 @pasztorl can i contribute to this?

@AayushVinayDev AayushVinayDev mentioned this issue Jul 17, 2024
Open
@mmontes11
Copy link
Member

Thanks for your PR @AayushVinayDev ! I've left some comments

@AayushVinayDev
Copy link

@mmontes11 Heyy!! Sorry about the delay, was busy with finals. I've made some changes as suggested, I'll commit them and write the tests when given the green signal. : )

@hedgieinsocks hedgieinsocks mentioned this issue Oct 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature good first issue Good for newcomers help wanted Extra attention is needed sql
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make maxUserConnections mutable hedgieinsocks/mariadb-operator
3 participants
@mmontes11 @pasztorl @AayushVinayDev