Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add arch to binary and image cache paths #13539

Merged
merged 7 commits into from
Feb 10, 2022
Merged

add arch to binary and image cache paths #13539

merged 7 commits into from
Feb 10, 2022

Conversation

sharifelgamal
Copy link
Collaborator

This path adds an extra directory to the cache baths for important minikube binary and image cache paths. This will allow users to run multiple arch binaries without corrupting their cache. Note that this does not affect preloads in any way.

Fixes #9593
Fixes #12274

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 1, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2022
@sharifelgamal
Copy link
Collaborator Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 3, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13539) |
+----------------+----------+---------------------+
| minikube start | 44.3s    | 44.4s               |
| enable ingress | 28.7s    | 29.7s               |
+----------------+----------+---------------------+

Times for minikube start: 45.7s 44.9s 43.5s 43.0s 44.5s
Times for minikube (PR 13539) start: 45.0s 44.2s 43.9s 44.0s 44.9s

Times for minikube ingress: 29.6s 29.5s 25.6s 25.6s 33.1s
Times for minikube (PR 13539) ingress: 29.0s 30.0s 29.6s 30.1s 30.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13539) |
+----------------+----------+---------------------+
| minikube start | 26.0s    | 25.8s               |
| enable ingress | 35.1s    | 23.0s               |
+----------------+----------+---------------------+

Times for minikube start: 27.0s 25.8s 25.7s 25.9s 25.8s
Times for minikube (PR 13539) start: 26.1s 25.7s 25.4s 26.5s 25.2s

Times for minikube ingress: 83.4s 22.9s 22.9s 23.9s 22.4s
Times for minikube (PR 13539) ingress: 22.9s 22.9s 23.9s 22.9s 22.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13539) |
+----------------+----------+---------------------+
| minikube start | 39.8s    | 42.7s               |
| enable ingress | 25.3s    | 23.3s               |
+----------------+----------+---------------------+

Times for minikube ingress: 24.4s 23.4s 29.4s 24.4s 24.9s
Times for minikube (PR 13539) ingress: 23.4s 21.4s 18.9s 29.4s 23.4s

Times for minikube (PR 13539) start: 41.0s 44.8s 46.2s 41.0s 40.5s
Times for minikube start: 31.0s 41.1s 41.2s 41.0s 44.9s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux TestFunctional/serial/ComponentHealth (gopogh) 0.00 (chart)
Docker_macOS TestDownloadOnly/v1.16.0/kubectl (gopogh) 0.00 (chart)
Docker_macOS TestDownloadOnly/v1.23.2/kubectl (gopogh) 0.00 (chart)
Docker_macOS TestDownloadOnly/v1.23.3-rc.0/kubectl (gopogh) 0.00 (chart)
Docker_Windows TestDownloadOnly/v1.16.0/kubectl (gopogh) 0.00 (chart)
Docker_Windows TestDownloadOnly/v1.23.2/kubectl (gopogh) 0.00 (chart)
Docker_Windows TestDownloadOnly/v1.23.3-rc.0/kubectl (gopogh) 0.00 (chart)
Hyperkit_macOS TestDownloadOnly/v1.16.0/kubectl (gopogh) 0.00 (chart)
Hyperkit_macOS TestDownloadOnly/v1.23.2/kubectl (gopogh) 0.00 (chart)
Hyperkit_macOS TestDownloadOnly/v1.23.3-rc.0/kubectl (gopogh) 0.00 (chart)
Hyper-V_Windows TestDownloadOnly/v1.16.0/kubectl (gopogh) 0.00 (chart)
Hyper-V_Windows TestDownloadOnly/v1.23.2/kubectl (gopogh) 0.00 (chart)
Hyper-V_Windows TestDownloadOnly/v1.23.3-rc.0/kubectl (gopogh) 0.00 (chart)
none_Linux TestDownloadOnly/v1.16.0/binaries (gopogh) 0.00 (chart)
none_Linux TestDownloadOnly/v1.23.2/binaries (gopogh) 0.00 (chart)
none_Linux TestDownloadOnly/v1.23.3-rc.0/binaries (gopogh) 0.00 (chart)
Docker_Linux_containerd TestPause/serial/Pause (gopogh) 2.13 (chart)
Docker_Linux_containerd TestNoKubernetes/serial/Start (gopogh) 6.56 (chart)
KVM_Linux TestDockerFlags (gopogh) 7.07 (chart)
Hyper-V_Windows TestErrorSpam/setup (gopogh) 10.29 (chart)
KVM_Linux TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 11.11 (chart)
KVM_Linux TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 11.11 (chart)
KVM_Linux TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 11.11 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/SecondStart (gopogh) 19.05 (chart)
Docker_macOS TestAddons/parallel/MetricsServer (gopogh) 21.05 (chart)
Docker_macOS TestNoKubernetes/serial/Start (gopogh) 21.74 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/FirstStart (gopogh) 22.50 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/custom-weave/Start (gopogh) 28.30 (chart)
Docker_Windows TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 42.42 (chart)
Docker_Windows TestNetworkPlugins/group/kindnet/Start (gopogh) 47.06 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@afbjorklund
Copy link
Collaborator

afbjorklund commented Feb 3, 2022 •
edited
Loading

We might have to include the "iso" here as well, right @klaases ?

Otherwise we have to rename the "minikube.iso" artifact instead.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13539) |
+----------------+----------+---------------------+
| minikube start | 44.9s    | 45.1s               |
| enable ingress | 29.3s    | 28.9s               |
+----------------+----------+---------------------+

Times for minikube start: 46.5s 44.3s 45.3s 44.6s 44.1s
Times for minikube (PR 13539) start: 42.6s 44.5s 44.4s 49.3s 44.8s

Times for minikube ingress: 28.6s 29.1s 30.1s 30.0s 28.5s
Times for minikube (PR 13539) ingress: 32.1s 28.6s 29.1s 27.5s 27.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13539) |
+----------------+----------+---------------------+
| minikube start | 27.1s    | 25.6s               |
| enable ingress | 22.5s    | 22.9s               |
+----------------+----------+---------------------+

Times for minikube start: 30.5s 25.6s 26.0s 27.2s 26.1s
Times for minikube (PR 13539) start: 25.1s 25.7s 25.4s 26.8s 25.0s

Times for minikube ingress: 23.4s 22.4s 21.9s 23.0s 21.9s
Times for minikube (PR 13539) ingress: 23.9s 22.9s 23.9s 21.9s 22.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13539) |
+----------------+----------+---------------------+
| minikube start | 38.9s    | 44.3s               |
| enable ingress | 32.8s    | 22.8s               |
+----------------+----------+---------------------+

Times for minikube start: 30.5s 41.8s 40.4s 40.5s 41.3s
Times for minikube (PR 13539) start: 41.3s 45.1s 45.8s 45.4s 43.7s

Times for minikube ingress: 23.4s 53.4s 28.4s 34.4s 24.4s
Times for minikube (PR 13539) ingress: 22.9s 18.9s 21.0s 21.4s 30.0s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_containerd TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 8.57 (chart)
KVM_Linux_containerd TestStartStop/group/embed-certs/serial/EnableAddonWhileActive (gopogh) 8.57 (chart)
KVM_Linux_containerd TestStartStop/group/embed-certs/serial/FirstStart (gopogh) 8.57 (chart)
KVM_Linux_containerd TestForceSystemdEnv (gopogh) 9.52 (chart)
Docker_Linux TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 14.00 (chart)
KVM_Linux_containerd TestNetworkPlugins/group/flannel/Start (gopogh) 19.05 (chart)
Docker_Linux TestNetworkPlugins/group/cilium/Start (gopogh) 23.00 (chart)
Docker_macOS TestStartStop/group/newest-cni/serial/Stop (gopogh) 24.71 (chart)
Docker_macOS TestAddons/parallel/MetricsServer (gopogh) 26.21 (chart)
Docker_Linux_containerd TestAddons/Setup (gopogh) 26.58 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 26.58 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 26.58 (chart)
Docker_Linux_containerd TestJSONOutput/start/Audit (gopogh) 26.58 (chart)
Docker_Linux_containerd TestJSONOutput/start/Command (gopogh) 26.58 (chart)
Docker_Linux_containerd TestMultiNode/serial/AddNode (gopogh) 26.58 (chart)
Docker_Linux_containerd TestMultiNode/serial/DeleteNode (gopogh) 26.58 (chart)
Docker_Linux_containerd TestMultiNode/serial/FreshStart2Nodes (gopogh) 26.58 (chart)
Docker_Linux_containerd TestMultiNode/serial/ProfileList (gopogh) 26.58 (chart)
Docker_Linux_containerd TestMultiNode/serial/RestartKeepsNodes (gopogh) 26.58 (chart)
Docker_Linux_containerd TestMultiNode/serial/StartAfterStop (gopogh) 26.58 (chart)
Docker_Linux_containerd TestMultiNode/serial/StopNode (gopogh) 26.58 (chart)
Docker_Linux_containerd TestPreload (gopogh) 26.58 (chart)
Docker_Linux TestAddons/parallel/Registry (gopogh) 27.00 (chart)
Docker_Linux TestFunctional/parallel/PersistentVolumeClaim (gopogh) 27.00 (chart)
Docker_Linux TestMultiNode/serial/DeployApp2Nodes (gopogh) 27.00 (chart)
Docker_Linux TestMultiNode/serial/PingHostFrom2Pods (gopogh) 27.00 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/auto/DNS (gopogh) 27.78 (chart)
Docker_Linux_containerd TestMultiNode/serial/RestartMultiNode (gopogh) 27.85 (chart)
Docker_Linux TestFunctional/parallel/DashboardCmd (gopogh) 28.00 (chart)
Docker_Linux_containerd TestOffline (gopogh) 30.38 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13539) |
+----------------+----------+---------------------+
| minikube start | 52.7s    | 52.7s               |
| enable ingress | 28.6s    | 28.3s               |
+----------------+----------+---------------------+

Times for minikube start: 55.1s 52.4s 52.4s 52.1s 51.5s
Times for minikube (PR 13539) start: 52.7s 52.2s 52.6s 53.0s 53.0s

Times for minikube (PR 13539) ingress: 29.6s 25.6s 28.5s 28.6s 29.1s
Times for minikube ingress: 28.6s 29.5s 25.5s 30.1s 29.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13539) |
+----------------+----------+---------------------+
| minikube start | 27.2s    | 26.3s               |
| enable ingress | 23.3s    | 22.2s               |
+----------------+----------+---------------------+

Times for minikube start: 30.4s 26.0s 27.3s 26.0s 26.3s
Times for minikube (PR 13539) start: 26.4s 26.4s 26.3s 26.2s 26.2s

Times for minikube (PR 13539) ingress: 21.9s 21.9s 22.0s 22.4s 22.9s
Times for minikube ingress: 21.4s 23.4s 22.9s 25.9s 22.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13539) |
+----------------+----------+---------------------+
| minikube start | 42.1s    | 44.2s               |
| enable ingress | 26.9s    | 22.4s               |
+----------------+----------+---------------------+

Times for minikube start: 35.4s 45.5s 42.1s 45.7s 41.7s
Times for minikube (PR 13539) start: 45.2s 42.1s 43.8s 45.0s 44.7s

Times for minikube (PR 13539) ingress: 18.9s 23.4s 29.9s 19.9s 19.9s
Times for minikube ingress: 18.9s 50.4s 23.4s 18.9s 22.9s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux TestRunningBinaryUpgrade (gopogh) 4.83 (chart)
Docker_Linux_containerd TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 6.09 (chart)
Docker_Linux_containerd TestStoppedBinaryUpgrade/Upgrade (gopogh) 6.09 (chart)
KVM_Linux TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 6.21 (chart)
KVM_Linux TestStoppedBinaryUpgrade/Upgrade (gopogh) 6.21 (chart)
Hyper-V_Windows TestErrorSpam/setup (gopogh) 9.09 (chart)
Docker_Linux TestPause/serial/Pause (gopogh) 9.85 (chart)
KVM_Linux_containerd TestPause/serial/SecondStartNoReconfiguration (gopogh) 11.63 (chart)
Hyperkit_macOS TestFunctional/parallel/DashboardCmd (gopogh) 15.75 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/FirstStart (gopogh) 21.88 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/custom-weave/Start (gopogh) 27.27 (chart)
Docker_macOS TestAddons/parallel/MetricsServer (gopogh) 37.59 (chart)
Docker_Linux TestNetworkPlugins/group/kindnet/Start (gopogh) 49.62 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 59.60 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 66.92 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 76.14 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/bridge/DNS (gopogh) 78.57 (chart)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 82.71 (chart)
Docker_Linux TestNetworkPlugins/group/bridge/DNS (gopogh) 85.71 (chart)
Docker_Linux TestNetworkPlugins/group/kubenet/DNS (gopogh) 86.47 (chart)
Docker_macOS TestDownloadOnly/v1.16.0/preload-exists (gopogh) 99.22 (chart)
Hyper-V_Windows TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/RestartKeepsNodes (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit d11e45a into kubernetes:master Feb 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [medyagh,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nixpanic nixpanic mentioned this pull request Mar 16, 2022
Merged
nixpanic added a commit to nixpanic/ceph-csi that referenced this pull request Mar 16, 2022
@nixpanic
ci: add GOARCH to path for copying kubectl
9abeec2 
minikube 1.25.2 moved the downloaded kubectl and other binaries to a new
subdir; it now includes runtime.GOARCH as an extra component.

See-also: kubernetes/minikube#13539
Signed-off-by: Niels de Vos <[email protected]>
@nixpanic nixpanic mentioned this pull request Mar 16, 2022
Merged
mergify bot pushed a commit to ceph/ceph-csi that referenced this pull request Mar 16, 2022
@nixpanic @mergify
ci: add GOARCH to path for copying kubectl
1101ec0 
minikube 1.25.2 moved the downloaded kubectl and other binaries to a new
subdir; it now includes runtime.GOARCH as an extra component.

See-also: kubernetes/minikube#13539
Signed-off-by: Niels de Vos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afbjorklund afbjorklund afbjorklund left review comments

@medyagh medyagh medyagh approved these changes

@blueelvis blueelvis Awaiting requested review from blueelvis

@klaases klaases Awaiting requested review from klaases

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
5 participants
@sharifelgamal @minikube-pr-bot @afbjorklund @k8s-ci-robot @medyagh