Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add arch to binary and image cache paths #13539

Merged
merged 7 commits into from
Feb 10, 2022
Merged

add arch to binary and image cache paths #13539

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fc6efd9
add arch to binary cache path
sharifelgamal Feb 1, 2022
9d76d0c
add arch to image and kicbase cache path
sharifelgamal Feb 1, 2022
5635ca7
Update pkg/minikube/detect/detect.go
sharifelgamal Feb 3, 2022
25b7614
Merge branch 'master' of github.com:kubernetes/minikube into arch-binary
sharifelgamal Feb 3, 2022
89213fa
Merge branch 'arch-binary' of github.com:sharifelgamal/minikube into …
sharifelgamal Feb 3, 2022
f74ea16
add arch to iso cache path, fix download only tests
sharifelgamal Feb 3, 2022
a1e273e
Merge branch 'master' of github.com:kubernetes/minikube into arch-binary
sharifelgamal Feb 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update pkg/minikube/detect/detect.go 
Co-authored-by: Medya Ghazizadeh <[email protected]>
  • Loading branch information
@sharifelgamal @medyagh
sharifelgamal and medyagh authored Feb 3, 2022
commit 5635ca72123d28e44585f3e0543b66ffe6c6f6b7
2 changes: 1 addition & 1 deletion pkg/minikube/detect/detect.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ func GithubActionRunner() bool {
return os.Getenv("GITHUB_ACTIONS") == "true"
}

// ImageCacheDir returns the path to the container image cache directory for the current architecture
// ImageCacheDir returns the path to the container image cache directory in minikube home folder for the current architecture
func ImageCacheDir() string {
return filepath.Join(localpath.MakeMiniPath("cache", "images"), runtime.GOARCH)
}
Expand Down