Update Japanese translation (Line 900-950) #12880

yosshy · 2021-11-07T13:24:06Z

/hold for japanese developer's review
/assign @atoato88
/cc @YuikoTakada @t-inu

k8s-ci-robot · 2021-11-07T13:24:14Z

Hi @yosshy. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

minikube-bot · 2021-11-07T13:30:06Z

Can one of the admins verify this patch?

s-kawamura-w664

Would you please confirm my comments.
/cc

s-kawamura-w664 · 2021-11-08T09:25:04Z

translations/ja.json

-	"logdir set failed": "logdir の値を設定するのに失敗しました",
-	"max time to wait per Kubernetes core services to be healthy.": "Kubernetes の core サービスが正常に稼働するまで待つ最大時間",
-	"max time to wait per Kubernetes or host to be healthy.": "",
+	"list displays all valid default settings for PROPERTY_NAME\nAcceptable fields: \\n\\n": "list は PROPERTY_NAME 用の有効なデフォルト設定を全て表示します。\n受け入れ可能なフィールド:\\n\\n",


This message will be for minikube config defalults PROPERTY_NAME.

そのため、「リストには、PROPERTY_NAME用の有効な．．．」とする方が意味は通じると思います。
「全て表示」という訳もありますので、"list"の訳として無理に「リストには」を含めずに削除しても良い様に思います。

色々コードを追っかけると、有効なデフォルト値を標準出力に出力するコマンドのメッセージのようです。
その方向で修正します。

s-kawamura-w664 · 2021-11-08T09:27:03Z

translations/ja.json

-	"reloads images previously added using the 'cache add' subcommand": "",
+	"pause containers": "コンテナーを一時停止させます",
+	"preload extraction failed: \\\"No space left on device\\\"": "プリロードの展開に失敗しました: 「デバイスに空きスペースがありません」",
+	"profile sets the current minikube profile, or gets the current profile if no arguments are provided.  This is used to run and manage multiple minikube instance.  You can return to the default minikube profile by running `minikube profile default`": "profile は現在の minikube プロファイルを設定します (profil に引数を指定しない場合、現在のプロファイルを取得します)。このコマンドは複数の minikube インスタンスを管理するのに使用されます。'minikube profile default' でデフォルトの minikube プロファイルを返します",


「profil に引数を」を「profileに引数を」へ。

すいません。修正します。

yosshy

@s-kawamura-w664 レビューありがとうございます。

yosshy · 2021-11-09T06:27:30Z

translations/ja.json

-	"logdir set failed": "logdir の値を設定するのに失敗しました",
-	"max time to wait per Kubernetes core services to be healthy.": "Kubernetes の core サービスが正常に稼働するまで待つ最大時間",
-	"max time to wait per Kubernetes or host to be healthy.": "",
+	"list displays all valid default settings for PROPERTY_NAME\nAcceptable fields: \\n\\n": "list は PROPERTY_NAME 用の有効なデフォルト設定を全て表示します。\n受け入れ可能なフィールド:\\n\\n",


色々コードを追っかけると、有効なデフォルト値を標準出力に出力するコマンドのメッセージのようです。
その方向で修正します。

yosshy · 2021-11-09T06:28:24Z

translations/ja.json

-	"reloads images previously added using the 'cache add' subcommand": "",
+	"pause containers": "コンテナーを一時停止させます",
+	"preload extraction failed: \\\"No space left on device\\\"": "プリロードの展開に失敗しました: 「デバイスに空きスペースがありません」",
+	"profile sets the current minikube profile, or gets the current profile if no arguments are provided.  This is used to run and manage multiple minikube instance.  You can return to the default minikube profile by running `minikube profile default`": "profile は現在の minikube プロファイルを設定します (profil に引数を指定しない場合、現在のプロファイルを取得します)。このコマンドは複数の minikube インスタンスを管理するのに使用されます。'minikube profile default' でデフォルトの minikube プロファイルを返します",


すいません。修正します。

translations/ja.json

Nov 9, 2021 · 2021-11-09T07:35:04Z

translations/ja.json

-	"numa node is only supported on k8s v1.18 and later": "",
-	"output layout (EXPERIMENTAL, JSON only): 'nodes' or 'cluster'": "",
+	"network to run minikube with. Now it is used by docker/podman and KVM drivers. If left empty, minikube will create a new network.": "minikube を実行するネットワーク。現時点では docker/podman と KVM ドライバーで使用されます。空の場合、minikube は新しいネットワークを作成します。",
+	"none driver does not support multi-node clusters": "none ドライバーはマルチクラスターをサポートしていません",


multi-node clusters とあるので、マルチノードクラスターが正確ではないでしょうか。

確かにそうですね。修正します。

translations/ja.json

yosshy

@t-inu レビューありがとうございます。

yosshy · 2021-11-09T11:09:44Z

translations/ja.json

-	"numa node is only supported on k8s v1.18 and later": "",
-	"output layout (EXPERIMENTAL, JSON only): 'nodes' or 'cluster'": "",
+	"network to run minikube with. Now it is used by docker/podman and KVM drivers. If left empty, minikube will create a new network.": "minikube を実行するネットワーク。現時点では docker/podman と KVM ドライバーで使用されます。空の場合、minikube は新しいネットワークを作成します。",
+	"none driver does not support multi-node clusters": "none ドライバーはマルチクラスターをサポートしていません",


確かにそうですね。修正します。

Nov 10, 2021 · 2021-11-10T07:05:30Z

I confirmed that all my comments were reflected.
LGTM

yosshy reacted with heart emoji

s-kawamura-w664 · 2021-11-11T06:11:45Z

I reviewed your updates. LGTM.

linux-foundation-easycla · 2021-11-13T07:56:09Z

The committers are authorized under a signed CLA.

✅ Akira YOSHIYAMA (4232dec)

yosshy · 2021-11-13T07:58:10Z

@t-inu @s-kawamura-w664
漢数字の「二」を「 2 」に修正しました。お手数ですが、再度ご確認をお願いいたします。

s-kawamura-w664 · 2021-11-15T06:22:47Z

漢数字の「二」を「 2 」に修正しました。お手数ですが、再度ご確認をお願いいたします。

Good fix.
LGTM

yosshy · 2021-11-15T13:04:37Z

@atoato88 could you review this?

atoato88 · 2021-11-16T00:50:06Z

/lgtm as Japanese reveiw.

atoato88 · 2021-11-16T00:52:00Z

Huh, no lgtm label is attached?

/lgtm

k8s-ci-robot · 2021-11-16T00:52:52Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: atoato88, yosshy
To complete the pull request process, please assign spowelljr after the PR has been reviewed.
You can assign the PR to them by writing /assign @spowelljr in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

yosshy · 2021-11-16T00:55:19Z

/unhold
@atoato88 @s-kawamura-w664 @t-inu thanks for your review.
@spowelljr would you merge it?

yosshy · 2021-11-16T01:00:19Z

/assign @spowelljr

spowelljr · 2021-11-16T13:52:27Z

Hi @yosshy, Kubernetes added this new EasyCLA check and it says you're missing authorization. Could you please go to this comment (#12880 (comment)) and go through the authorize steps, thanks!

yosshy · 2021-11-20T22:50:15Z

@spowelljr Finally, I got authorized from EasyCLA. Would you merge it?

k8s-ci-robot assigned atoato88 Nov 7, 2021

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2021

k8s-ci-robot requested review from t-inu and YuikoTakada November 7, 2021 13:24

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 7, 2021

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 7, 2021

s-kawamura-w664 reviewed Nov 8, 2021

View reviewed changes

k8s-ci-robot requested a review from s-kawamura-w664 November 8, 2021 09:32

yosshy commented Nov 9, 2021

View reviewed changes

yosshy force-pushed the japanese-translation5 branch from e573e47 to bafe9f8 Compare November 9, 2021 06:34

yosshy changed the title ~~Update Japanese translation (Line 896-946)~~ Update Japanese translation (Line 900-950) Nov 9, 2021

Nov 9, 2021

View reviewed changes

yosshy commented Nov 9, 2021

View reviewed changes

yosshy force-pushed the japanese-translation5 branch from 8e76c89 to 6195d03 Compare November 9, 2021 11:18

Update Japanese translation (Line 900-950)

4232dec

yosshy force-pushed the japanese-translation5 branch from 6195d03 to 4232dec Compare November 13, 2021 07:56

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2021

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2021

k8s-ci-robot assigned spowelljr Nov 16, 2021

spowelljr merged commit 522343b into kubernetes:master Nov 21, 2021

yosshy deleted the japanese-translation5 branch November 21, 2021 01:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Japanese translation (Line 900-950) #12880

Update Japanese translation (Line 900-950) #12880

yosshy commented Nov 7, 2021

k8s-ci-robot commented Nov 7, 2021

minikube-bot commented Nov 7, 2021

s-kawamura-w664 left a comment

s-kawamura-w664 Nov 8, 2021

yosshy Nov 9, 2021

s-kawamura-w664 Nov 8, 2021

yosshy Nov 9, 2021

yosshy left a comment

yosshy Nov 9, 2021

yosshy Nov 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

細かい点のコメントが多いですが、レビューしました。

Nov 9, 2021

yosshy Nov 9, 2021

yosshy left a comment

yosshy Nov 9, 2021

Nov 10, 2021

s-kawamura-w664 commented Nov 11, 2021

linux-foundation-easycla bot commented Nov 13, 2021 •

edited

Loading

yosshy commented Nov 13, 2021

s-kawamura-w664 commented Nov 15, 2021

yosshy commented Nov 15, 2021

atoato88 commented Nov 16, 2021

atoato88 commented Nov 16, 2021

k8s-ci-robot commented Nov 16, 2021

yosshy commented Nov 16, 2021

yosshy commented Nov 16, 2021

spowelljr commented Nov 16, 2021

yosshy commented Nov 20, 2021

Update Japanese translation (Line 900-950) #12880

Update Japanese translation (Line 900-950) #12880

Conversation

yosshy commented Nov 7, 2021

k8s-ci-robot commented Nov 7, 2021

minikube-bot commented Nov 7, 2021

s-kawamura-w664 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yosshy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yosshy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

s-kawamura-w664 commented Nov 11, 2021

linux-foundation-easycla bot commented Nov 13, 2021 • edited Loading

yosshy commented Nov 13, 2021

s-kawamura-w664 commented Nov 15, 2021

yosshy commented Nov 15, 2021

atoato88 commented Nov 16, 2021

atoato88 commented Nov 16, 2021

k8s-ci-robot commented Nov 16, 2021

yosshy commented Nov 16, 2021

yosshy commented Nov 16, 2021

spowelljr commented Nov 16, 2021

yosshy commented Nov 20, 2021

linux-foundation-easycla bot commented Nov 13, 2021 •

edited

Loading