Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #12659, utilize absolute path when tilde starts ssh-key path #12672

Merged
merged 4 commits into from
Oct 7, 2021
Merged

fix for #12659, utilize absolute path when tilde starts ssh-key path #12672

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c27326c
fix for #12659, rendor absolute path when tilde starts ssh-key path
marcvelasco Oct 7, 2021
a827379
remove comment before absolute path function to fix lint errors
marcvelasco Oct 7, 2021
4f5524f
changes for comments to the PR, use os.UserHomeDir and strings.haspre…
marcvelasco Oct 7, 2021
a48e875
return error if unable to get os.UserHomeDir in ssh-key when resolvin…
marcvelasco Oct 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
return error if unable to get os.UserHomeDir in ssh-key when resolvin… 
…g absolute path
  • Loading branch information
@marcvelasco
marcvelasco committed Oct 7, 2021
commit a48e875ec1aac525e7216d3f77dc36aad3b8e171
2 changes: 1 addition & 1 deletion pkg/minikube/registry/drvs/ssh/ssh.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func configure(cc config.ClusterConfig, n config.Node) (interface{}, error) {
if strings.HasPrefix(cc.SSHKey, "~") {
dirname, err := os.UserHomeDir()
if err != nil {
return nil, errors.Errorf("Error determining path to ssh key")
return nil, errors.Errorf("Error determining path to ssh key: %v", err)
}
d.SSHKey = filepath.Join(dirname, cc.SSHKey[1:])
} else {
Expand Down