fix for #12659, utilize absolute path when tilde starts ssh-key path #12672
Conversation
|
Hi @marcvelasco. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Can one of the admins verify this patch? |
…fix, move package order
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marcvelasco, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #12659 , when using a relative path with ~ the path would not be recognized correctly if used with an equal sign.
Behavior is as currently working in GO per golang/go#4140
Solution here is to use the user home directory and joining to the relative path when a relative path is used like: minikube -p test start --driver=ssh --ssh-key=~/.ssh/id_rsa --ssh-ip-address=mytestkube
Let me know if any comments or suggested changes, thanks!