Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stack to legacy apis #183

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Add Stack to legacy apis #183

merged 1 commit into from
Apr 4, 2023

Conversation

delanym
Copy link
Contributor

@delanym delanym commented Apr 3, 2023

For #182

https://docs.oracle.com/en/java/javase/20/docs/api/java.base/java/util/Stack.html
Suggested replacement is Deque, introduced in Java 6

Can I suggest adding some formatting config/automatic formatting so i don't have to manually satisfy checkstyle pedantic requirements.

Also, I couldn't build the annotation module - set to source/target Java 6 - until I change this to Java 8.

@gaul gaul mentioned this pull request Apr 4, 2023
@gaul gaul merged commit 718cfec into gaul:master Apr 4, 2023
@gaul
Copy link
Owner

gaul commented Apr 4, 2023

Thank you for your contribution @delanym! I don't understand the Java version issue but perhaps it is related to using a very recent Java version? #171 suggests a similar change although I believe this intent is to get local variable type annotations.

@delanym delanym deleted the issue-182 branch April 4, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants