Require Java 8 for compilation and execution #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bumps the source level and target to Java 8. As a side-effect, the checks for sun.misc.BASE64* are removed, as we can no longer test them. Signed-off-by: Robert Varga <[email protected]>
gaul
requested changes
Feb 16, 2023
| <version>8</version> | ||
| <comment>Prefer java.util.Base64.Encoder.encodeToString(byte[])</comment> | ||
| </violation> | ||
|
|
There was a problem hiding this comment.
We should keep the violation but not test it. The tests still reference this so I think maybe you did the opposite?
This reverts the previous patch.
|
Could you explain this a little more? By compiling with Java 1.8 as a dependency, does this allow @SuppressModernizer to apply to local variables? Is this all the needs to be done to resolve #155? |
|
@rovarga Could you explain your motivations for this PR? Does it allow @SuppressModernizer to apply to local variables? If so can you add a test? |
|
Closing as per #155 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the source level and target to Java 8. As a side-effect, the checks for sun.misc.BASE64* are removed, as we can no longer test them.