Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stub method shared tests #458

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

Stub method shared tests #458

Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
c203058
move define/remove method to setup/teardown
nitishr Jan 3, 2020
36888e8
replace module_eval with send
nitishr Jan 3, 2020
c455732
prep to DRY by using send instead of direct invocation
nitishr Jan 3, 2020
d2362c5
DRY up public, protected and private checks
nitishr Jan 3, 2020
26de50e
Prep to DRY - use send & extract visibility to a var
nitishr Jan 3, 2020
6fe3702
DRY up Module public, protected and private checks
nitishr Jan 3, 2020
fec664a
prep to DRY by making assert methods near identical
nitishr Jan 3, 2020
9c47db1
DRY up assert_snapshot_unchanged_on_stubbing*
nitishr Jan 3, 2020
90570ec
inline delegating methods
nitishr Jan 3, 2020
32562f1
rename assert_snapshot_unchanged_on_stubbing_method
nitishr Jan 3, 2020
2e425af
extract & reuse StubInstanceMethodSharedTests
nitishr Jan 3, 2020
0d024d4
allow instantiation to be parameterized by subclassing
nitishr Jan 3, 2020
44037fe
reuse StubInstanceMethodSharedTests in StubInstanceMethodDefinedOnCla…
nitishr Jan 3, 2020
388c608
reuse StubInstanceMethodSharedTests in StubInstanceMethodDefinedOnMod…
nitishr Jan 3, 2020
b8505d1
reuse StubInstanceMethodSharedTests in StubInstanceMethodDefinedOnSup…
nitishr Jan 3, 2020
60036df
more expressive name: stubbed_module -> method_owner
nitishr Jan 3, 2020
e9cfc66
split StubInstanceMethodDefinedOnKernelModuleTest into two
nitishr Jan 3, 2020
eef3880
return stubbed instance instead of stubbed class
nitishr Jan 3, 2020
a84b186
reuse StubInstanceMethodSharedTests in StubInstanceMethodDefinedOnSin…
nitishr Jan 3, 2020
adc1d2f
check aliased method stubbing if stub_aliased_method
nitishr Jan 3, 2020
bffb23d
reuse StubInstanceMethodSharedTests in StubInstanceMethodDefinedOnCla…
nitishr Jan 3, 2020
1180f77
reuse StubInstanceMethodSharedTests in StubMethodDefinedOnModuleAndAl…
nitishr Jan 3, 2020
ba0617b
reuse StubInstanceMethodSharedTests in StubClassMethod*Test
nitishr Jan 5, 2020
6d3b047
allow stub_owner to be different from stubbed_instance
nitishr Jan 5, 2020
0ea322e
split superclass test into super & child
nitishr Jan 5, 2020
6a0bbc3
remove 'instance' qualifier from shared tests
nitishr Jan 5, 2020
060ebb7
reuse StubMethodSharedTests in StubModuleMethodTest
nitishr Jan 3, 2020
1b5af22
reuse StubMethodSharedTests in StubAnyInstanceMethodTest
nitishr Jan 5, 2020
fdc2e2b
use shared tests for method private in owning module
nitishr Jan 5, 2020
620ff24
use shared tests for AnyInstance superclass checks
nitishr Jan 6, 2020
99ca183
delete test_should_be_able_to_stub_a_superclass_method
nitishr Jan 6, 2020
aad1b3f
extract assert_passed_with_snapshot_unchanged
nitishr Jan 6, 2020
18c8c49
stubbed_instance -> callee, stub_owner -> stubbee
nitishr Jan 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
DRY up Module public, protected and private checks
  • Loading branch information
@nitishr
nitishr committed Feb 16, 2020
commit 6fe37026e348a5986ed1dc7c9fe7b45463a7fbb3
37 changes: 10 additions & 27 deletions test/acceptance/stub_instance_method_defined_on_kernel_module_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,50 +29,33 @@ def test_should_stub_private_method_and_leave_it_unchanged_after_test
end

def test_should_stub_public_module_method_and_leave_it_unchanged_after_test
visibility = :public
Kernel.send(visibility, :my_instance_method)
mod = Module.new
assert_snapshot_unchanged(mod) do
test_result = run_as_test do
mod.stubs(:my_instance_method).returns(:new_return_value)
assert_method_visibility mod, :my_instance_method, visibility
assert_equal :new_return_value, mod.send(:my_instance_method)
end
assert_passed(test_result)
end
assert_equal :original_return_value, mod.send(:my_instance_method)
assert_snapshot_unchanged_on_stubbing_module_method(:public)
end

def test_should_stub_protected_module_method_and_leave_it_unchanged_after_test
Kernel.send(:protected, :my_instance_method)
mod = Module.new
assert_snapshot_unchanged(mod) do
test_result = run_as_test do
mod.stubs(:my_instance_method).returns(:new_return_value)
assert_method_visibility mod, :my_instance_method, :protected
assert_equal :new_return_value, mod.send(:my_instance_method)
end
assert_passed(test_result)
end
assert_equal :original_return_value, mod.send(:my_instance_method)
assert_snapshot_unchanged_on_stubbing_module_method(:protected)
end

def test_should_stub_private_module_method_and_leave_it_unchanged_after_test
Kernel.send(:private, :my_instance_method)
assert_snapshot_unchanged_on_stubbing_module_method(:private)
end

private

def assert_snapshot_unchanged_on_stubbing_module_method(visibility)
Kernel.send(visibility, :my_instance_method)
mod = Module.new
assert_snapshot_unchanged(mod) do
test_result = run_as_test do
mod.stubs(:my_instance_method).returns(:new_return_value)
assert_method_visibility mod, :my_instance_method, :private
assert_method_visibility mod, :my_instance_method, visibility
assert_equal :new_return_value, mod.send(:my_instance_method)
end
assert_passed(test_result)
end
assert_equal :original_return_value, mod.send(:my_instance_method)
end

private

def assert_snapshot_unchanged_on_stubbing
instance = Class.new.new
assert_snapshot_unchanged(instance) do
Expand Down