Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stub method shared tests #458

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

Stub method shared tests #458

Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
c203058
move define/remove method to setup/teardown
nitishr Jan 3, 2020
36888e8
replace module_eval with send
nitishr Jan 3, 2020
c455732
prep to DRY by using send instead of direct invocation
nitishr Jan 3, 2020
d2362c5
DRY up public, protected and private checks
nitishr Jan 3, 2020
26de50e
Prep to DRY - use send & extract visibility to a var
nitishr Jan 3, 2020
6fe3702
DRY up Module public, protected and private checks
nitishr Jan 3, 2020
fec664a
prep to DRY by making assert methods near identical
nitishr Jan 3, 2020
9c47db1
DRY up assert_snapshot_unchanged_on_stubbing*
nitishr Jan 3, 2020
90570ec
inline delegating methods
nitishr Jan 3, 2020
32562f1
rename assert_snapshot_unchanged_on_stubbing_method
nitishr Jan 3, 2020
2e425af
extract & reuse StubInstanceMethodSharedTests
nitishr Jan 3, 2020
0d024d4
allow instantiation to be parameterized by subclassing
nitishr Jan 3, 2020
44037fe
reuse StubInstanceMethodSharedTests in StubInstanceMethodDefinedOnCla…
nitishr Jan 3, 2020
388c608
reuse StubInstanceMethodSharedTests in StubInstanceMethodDefinedOnMod…
nitishr Jan 3, 2020
b8505d1
reuse StubInstanceMethodSharedTests in StubInstanceMethodDefinedOnSup…
nitishr Jan 3, 2020
60036df
more expressive name: stubbed_module -> method_owner
nitishr Jan 3, 2020
e9cfc66
split StubInstanceMethodDefinedOnKernelModuleTest into two
nitishr Jan 3, 2020
eef3880
return stubbed instance instead of stubbed class
nitishr Jan 3, 2020
a84b186
reuse StubInstanceMethodSharedTests in StubInstanceMethodDefinedOnSin…
nitishr Jan 3, 2020
adc1d2f
check aliased method stubbing if stub_aliased_method
nitishr Jan 3, 2020
bffb23d
reuse StubInstanceMethodSharedTests in StubInstanceMethodDefinedOnCla…
nitishr Jan 3, 2020
1180f77
reuse StubInstanceMethodSharedTests in StubMethodDefinedOnModuleAndAl…
nitishr Jan 3, 2020
ba0617b
reuse StubInstanceMethodSharedTests in StubClassMethod*Test
nitishr Jan 5, 2020
6d3b047
allow stub_owner to be different from stubbed_instance
nitishr Jan 5, 2020
0ea322e
split superclass test into super & child
nitishr Jan 5, 2020
6a0bbc3
remove 'instance' qualifier from shared tests
nitishr Jan 5, 2020
060ebb7
reuse StubMethodSharedTests in StubModuleMethodTest
nitishr Jan 3, 2020
1b5af22
reuse StubMethodSharedTests in StubAnyInstanceMethodTest
nitishr Jan 5, 2020
fdc2e2b
use shared tests for method private in owning module
nitishr Jan 5, 2020
620ff24
use shared tests for AnyInstance superclass checks
nitishr Jan 6, 2020
99ca183
delete test_should_be_able_to_stub_a_superclass_method
nitishr Jan 6, 2020
aad1b3f
extract assert_passed_with_snapshot_unchanged
nitishr Jan 6, 2020
18c8c49
stubbed_instance -> callee, stub_owner -> stubbee
nitishr Jan 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
split superclass test into super & child
  • Loading branch information
@nitishr
nitishr committed Feb 16, 2020
commit 0ea322e2e6fbc9cf47f00341eb2daa482a9cba73
40 changes: 17 additions & 23 deletions test/acceptance/stub_class_method_defined_on_superclass_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
require File.expand_path('../stub_instance_method_shared_tests', __FILE__)

class StubClassMethodDefinedOnSuperclassTest < Mocha::TestCase
include StubInstanceMethodSharedTests
include StubMethodSharedTests

def method_owner
stubbed_instance.superclass.singleton_class
Expand All @@ -11,27 +11,6 @@ def stubbed_instance
@stubbed_instance ||= Class.new(Class.new)
end

# rubocop:disable Lint/DuplicateMethods
def test_should_stub_method_on_superclass_and_leave_it_unchanged_after_test
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Covered by https://github.com/freerange/mocha/pull/458/files#diff-159b146fcc6bec630f27565fd54ded75R64-R78

superklass = Class.new do
class << self
def my_class_method
:original_return_value
end
public :my_class_method
end
end
klass = Class.new(superklass)
assert_snapshot_unchanged(klass) do
test_result = run_as_test do
superklass.stubs(:my_class_method).returns(:new_return_value)
assert_equal :new_return_value, klass.my_class_method
end
assert_passed(test_result)
end
assert_equal :original_return_value, klass.my_class_method
end

def test_stub_on_earliest_receiver_should_take_priority
superklass = Class.new do
class << self
Expand Down Expand Up @@ -80,5 +59,20 @@ def self.my_class_method; end
'- expected exactly once, invoked never: superklass.my_class_method(any_parameters)'
], test_result.failure_message_lines
end
# rubocop:enable Lint/DuplicateMethods
end

class StubSuperclassClassMethodDefinedOnSuperclassTest < Mocha::TestCase
include StubMethodSharedTests

def method_owner
stubbed_instance.superclass.singleton_class
end

def stubbed_instance
@stubbed_instance ||= Class.new(Class.new)
end

def stub_owner
stubbed_instance.superclass
end
end