Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ps:restore logging #4262

Merged
merged 5 commits into from
Dec 20, 2020
Merged

Improve ps:restore logging #4262

merged 5 commits into from
Dec 20, 2020

Conversation

josegonzalez
Copy link
Member

This should help investigate the issue in #4259.

Without the logging additions, it's a bit more difficult to figure out why a ps:restore is skipping the restore of an app.
This logging change makes it easier to figure out what is breaking where when running commands in parallel.
It's not super useful most of the time.
This was forgotten in the ps plugin rewrite.
They don't need to be exported as they are only used within this plugin.
@josegonzalez josegonzalez force-pushed the 4259-better-restore-logging branch from 3990fc9 to 5743044 Compare December 20, 2020 09:15
@josegonzalez josegonzalez merged commit a6a0e03 into master Dec 20, 2020
@josegonzalez josegonzalez deleted the 4259-better-restore-logging branch December 20, 2020 18:51
josegonzalez pushed a commit that referenced this pull request Dec 23, 2020
# History

## 0.22.3

Install/update via the bootstrap script:

```shell
wget https://raw.githubusercontent.com/dokku/dokku/v0.22.3/bootstrap.sh
sudo DOKKU_TAG=v0.22.3 bash bootstrap.sh
```

### Bug Fixes

- #4268: @josegonzalez Properly parse flags for logs command
- #4264: @josegonzalez Correct argument handling when setting the `--app` flag
- #4252: @magikid Allow symbolic links for certificate and key files

### New Features

- #4270: @josegonzalez Allow renaming old applications to new format
- #4261: @josegonzalez Add remove by fingerprint and json format output to ssh-keys plugin
- #4262: @josegonzalez Improve ps:restore logging
- #4263: @josegonzalez Bump the dokku client formula on release

### Documentation

- #4253: @guettli Highlight the default build method used by Dokku
- #4250: @rlnd1 Update upgrading.md
- #4249: @guettli Fix typo in zero downtime docs
- #4247: @josegonzalez Clarify the domain name setting in the docs

### Tests

- #4269: @josegonzalez Rename duplicate test
- #4266: @josegonzalez Update junit test files when a bats retry is successful
- #4265: @josegonzalez Retry failing and skipped tests once
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant