Allow symbolic links for certificate and key files #4252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This corrects an issue where if a symbolic link was given to the `certs:add` command, an error would be thrown even though the file was valid. Issue: dokku#4251
|
Does this add the actual file underneath or a symlink to the original cert? I'm torn on which is the "correct" behavior. |
|
I've been fiddling around with this all afternoon and the PR as it currently is written only adds the symlink and not the file underneath. Since it copies the file into the $APP_DIR/tls folder and set nginx to read from that, I don't see that it makes much difference either way. |
josegonzalez
pushed a commit
that referenced
this pull request
Dec 23, 2020
# History ## 0.22.3 Install/update via the bootstrap script: ```shell wget https://raw.githubusercontent.com/dokku/dokku/v0.22.3/bootstrap.sh sudo DOKKU_TAG=v0.22.3 bash bootstrap.sh ``` ### Bug Fixes - #4268: @josegonzalez Properly parse flags for logs command - #4264: @josegonzalez Correct argument handling when setting the `--app` flag - #4252: @magikid Allow symbolic links for certificate and key files ### New Features - #4270: @josegonzalez Allow renaming old applications to new format - #4261: @josegonzalez Add remove by fingerprint and json format output to ssh-keys plugin - #4262: @josegonzalez Improve ps:restore logging - #4263: @josegonzalez Bump the dokku client formula on release ### Documentation - #4253: @guettli Highlight the default build method used by Dokku - #4250: @rlnd1 Update upgrading.md - #4249: @guettli Fix typo in zero downtime docs - #4247: @josegonzalez Clarify the domain name setting in the docs ### Tests - #4269: @josegonzalez Rename duplicate test - #4266: @josegonzalez Update junit test files when a bats retry is successful - #4265: @josegonzalez Retry failing and skipped tests once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects an issue where if a symbolic link was given to the
certs:addcommand, an error would be thrown even though the file wasvalid.
Issue: #4251