Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add convenience method on AbstractBlock to resolve ordered list type keyword #469

Closed
mojavelinux opened this issue Jun 30, 2013 · 1 comment
Closed

Add convenience method on AbstractBlock to resolve ordered list type keyword #469

mojavelinux opened this issue Jun 30, 2013 · 1 comment
Assignees
@mojavelinux
Labels
enhancement
Milestone
v0.1.4

Comments

@mojavelinux
Copy link
Member

Add a convenience method on AbstractBlock to replace this lookup with something more readable:

Asciidoctor::ORDERED_LIST_KEYWORDS[@style]

Perhaps something like:

ordered_list_type(@style)
@ghost ghost assigned mojavelinux Jun 30, 2013
@mojavelinux
Copy link
Member Author

I decided to go with:

list_marker_keyword(list_type = nil)

It uses the style instance variable if list_type is nil.

mojavelinux added a commit that referenced this issue Jul 2, 2013
@mojavelinux
Merge pull request #473 from mojavelinux/ordered-list-numeration
b26dafd 
resolves #469, #364, #472 list improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
enhancement
Projects
None yet
Milestone
v0.1.4
Development

No branches or pull requests
1 participant
@mojavelinux