Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Rule]: Implicit and explicit roles #789

Closed
shunguoy opened this issue Apr 5, 2022 · 2 comments · Fixed by #862
Closed

[New Rule]: Implicit and explicit roles #789

shunguoy opened this issue Apr 5, 2022 · 2 comments · Fixed by #862
Assignees
@shunguoy
Labels
development engine Issues in the accessibility-checker-engine component enhancement New feature or request Ready for QA SME Discuss with subject matter experts

Comments

@shunguoy
Copy link
Contributor

shunguoy commented Apr 5, 2022

Rule description

The rule checks if a role that exists implicitly is assigned explicitly. For example .

Relevant requirement(s)

4.1.1 Parsing

High-level approach and rule scope

Detect the elements with explicit roles to see if the same roles are explicitly assigned

Ruleset and failure level

WCAG 2.0, WCAG 2.1, IBM

Failure level

Recommendation

Different failure level

No response

Failure cases

No response
@shunguoy shunguoy added enhancement New feature or request engine Issues in the accessibility-checker-engine component SME Discuss with subject matter experts development labels Apr 5, 2022
@shunguoy shunguoy self-assigned this Apr 5, 2022
@shunguoy shunguoy mentioned this issue Apr 5, 2022
Closed
shunguoy added a commit that referenced this issue Apr 5, 2022
@shunguoy
initial role implementation #789
a3581fb
shunguoy added a commit that referenced this issue Apr 6, 2022
@shunguoy
aria test cases #789
9746012
shunguoy added a commit that referenced this issue Apr 7, 2022
@shunguoy
Update Copyright notice for the referenced test cases #789
8d35f6e
shunguoy added a commit that referenced this issue Apr 7, 2022
@shunguoy
Update aria definition to add deprecated indicator #789
0cf139c
shunguoy added a commit that referenced this issue Apr 7, 2022
@shunguoy
add test cases for implicit/explicit overlapping rule #789
d078a95
shunguoy added a commit that referenced this issue Apr 7, 2022
@shunguoy
clean up rule logic for implicit/explicit role #789
181bb4c
shunguoy added a commit that referenced this issue Apr 8, 2022
@shunguoy
update test to remove compound customer cases #789
7ec3728
shunguoy added a commit that referenced this issue Apr 8, 2022
@shunguoy
Update rules, test case, and message file name for redundant rule #789
3f8bb1e
@maryjom
Copy link
Contributor

maryjom commented Apr 8, 2022

@shunguoy Please add a link to the boxnote that explains what help is needed.

@shunguoy
Copy link
Contributor Author

updated https://ibm.ent.box.com/notes/941065935316. the branch is aria-789

@shunguoy shunguoy mentioned this issue Apr 12, 2022
Closed
shunguoy added a commit that referenced this issue Apr 13, 2022
@shunguoy
update baseline for accessibility checker for build issue #789
ee034eb
shunguoy added a commit that referenced this issue Apr 14, 2022
@shunguoy
update baseline for accessibility-checker #789
89ec077
@shunguoy shunguoy mentioned this issue Apr 18, 2022
Closed
shunguoy added a commit that referenced this issue Apr 18, 2022
@shunguoy
update rule logic and test cases for various aria rules #789
6f30ebe
shunguoy added a commit that referenced this issue Apr 19, 2022
@shunguoy
fix duplicated reporting for tr, td & th element within a table/tree/…
946dd7f 
…treegrid #789
This was referenced Apr 19, 2022
Closed
Merged
shunguoy added a commit that referenced this issue Apr 19, 2022
@shunguoy
remove duplicated/conflicting reporting #789
5ee22d2
shunguoy added a commit that referenced this issue Apr 20, 2022
@shunguoy
fix baseline issues related to the rule changes #789
f221857
@tombrunet tombrunet mentioned this issue May 4, 2022
Merged
tombrunet added a commit that referenced this issue May 5, 2022
@tombrunet @shunguoy
@maryjom @philljenkins @drjoho @ErickRenteria
Aria rules combined (#862)
d319e0d 
* remove 'menu' from the deprecated element list #754

* update aria definition for native equivalents

* update rule id for ARIA/native conflict case. #754

* update conflict and overlapping attribute list #754

* conflict rule logic #754

* update direct names and rule logic #754

* rule logic and test #754

* add aria overlap files #754

* update rule logic for overlapping rule #754

* update test cases #754

* initial role implementation #789

* role overlap logic # 789

* update the return code #754

* aria test cases #789

* Update Copyright notice for the referenced test cases #789

* Update aria definition to add deprecated indicator #789

* fixed a bug in rule definition and updated the test cases accordingly #754

* add test cases for implicit/explicit overlapping rule #789

* clean up rule logic for implicit/explicit role #789

* update test to remove compound customer cases #789

* add rule message file placeholder and rule placeholder #800

* update rule messages for the deprecated rule #800

* Update rules, test case, and message file name for redundant rule #789

* update aria definition for deprecated roles and attributes #800

* Update aria definition with deprecated roles #800

* Update aria_role_redundant.html

Create help text to describe the issue of redundant roles and how to fix it.

* initial logic for deprecated aria roles/attributes #800

* update deprecated rules #800

* update the rule logic #754

* update existing test cases for deprecated roles/attributes #800

* update test cases for deprecated rule #800

* update baseline for accessibility checker for build issue #789

* update baseline for accessibility-checker #789

* update rule logic and test cases for various aria rules #789

* fix duplicated reporting for tr, td & th element within a table/tree/treegrid #789

* remove duplicated/conflicting reporting #789

* Help changes for 785 and 754

* Update help for 787

* Update help for 787

* fix baseline issues related to the rule changes #789

* Updated help for 787

* Consistent help for 785 and 787

* rename the rule name to aria_attribute_redundant #754

* Updated redundant attributes 787

* initial rule change #756

* Updated help for 804 deprecated

* Update help for 804 HTML

* Update help for 804 ARIA

* fix input roles for name from author/content #756

* Update 804 deprecated 804 formatting

* change level from violation to recommendation #800

* reset karma.conf

* Undo Karma conf change

* Remove debug statements

* Fix baseline

* Unneeded changes

* Karma browser update

* update config

* update config

* update

* karma config 2 update

* Karma conf tweaks

* update attribute redundant rule

* update redundant rule messages

* Fix reason codes

* path

Co-authored-by: Shunguo Yan <[email protected]>
Co-authored-by: maryjom <[email protected]>
Co-authored-by: Phill Jenkins <[email protected]>
Co-authored-by: drjoho <[email protected]>
Co-authored-by: eirckr <[email protected]>
Co-authored-by: Erick Renteria <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shunguoy shunguoy

Labels
development engine Issues in the accessibility-checker-engine component enhancement New feature or request Ready for QA SME Discuss with subject matter experts
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Aria rules combined IBMa/equal-access
2 participants
@maryjom @shunguoy