update td, th, tr allowances when within a table/grid/treegrid #372
Comments
|
As of June 1
|
|
@carmacleod @philljenkins We created a new rule for this one, but then we updated the allowed ARIA roles, so we end up with two errors. Which error do you think we should remove? Note that the first one even triggers when the role is redundant (e.g., cell on a td) whereas the second will not trigger when redundant. The second seems more consistent with the note that this case should be a warning. |
|
As an FYI, we have received some feedback that allowing explicit declaring of implicit roles on tables and their children should be reduced to a warning, or not reported. e.g., table role=grid > tr > td role=gridcell this is specifically due to some browsers still dropping table semantics due to CSS styling. I don't know if this helps or hinders the decision here, but as this popped up in my github notifications, I wanted to let you know that we were going to clarify this in an upcoming update to these rules. |
|
@tombrunet I think we should remove the first rule and keep the 2nd. We don't want to trigger on explicit declaring of implicit roles, although we should discuss whether those should be "needs review". |
|
Triage: |
|
#721 covers updated ARIA attributes but doesn't cover users explicitly specifying a role that is implicitly available. The second case needs to be considered in a different rule. |
|
close as fixed per #789 |
|
Validated |
Per ARIA in HTML when used within a
role=table, grid, treegridthetd,tr, andthelements should not be allowed any explicitly set role, as that would break the a11y mappings of the table, grid or treegrid.td in role=table
td in role=grid
td in role=treegrid
tr in role=table
tr in role=grid
tr in role=treegrid
th in role=table
th in role=grid
th in role=treegrid
expectations:
<td>'s ancestor table element has role=table, grid or treegrid - then no allowed role.<th>'s ancestor table element has role=table, grid or treegrid - then no allowed role.<tr>'s ancestor table element has role=table, grid or treegrid - then no allowed role.cell,gridcell,row,rowheader,columnheaderare found on these elements - then those should produce warnings as being unnecessaryif a td, tr, or th are used within a table with no set role, thus it should be an implicit role=table (regardless of what browser heuristics may do) - then no allowed role
td within a table testcase
th within a table testcase
tr within a table testcase
If td, tr, or th are used within a table where it's role is overwritten by a role not mentioned above (e.g., role=none, article, etc), then these elements can continue to allow any role. the checker already meets this expectation
The text was updated successfully, but these errors were encountered: