Page MenuHomePhabricator
Create Task
Maniphest T96881

Don't show the "results from other projects" box if empty
Closed, ResolvedPublic
Actions

Description

In https://it.wikipedia.org/w/index.php?title=Speciale%3ARicerca&search=Rabi+Samuel+Israelita&go=Vai the interwiki search finds no results from sister projects, yet the box is shown nevertheless.

That's slightly distracting.

Details

SubjectRepoBranchLines +/-
Do not output interwiki search results box when there's no resultmediawiki/coremaster+10 -6
Perform interwiki searches with a multi-searchmediawiki/extensions/CirrusSearchmaster+1 K -632
Return null when getInterwikiResults()mediawiki/extensions/CirrusSearchmaster+8 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

Nemo_bis created this task.Apr 22 2015, 4:43 PM
Nemo_bis raised the priority of this task from to Medium.
Nemo_bis updated the task description. (Show Details)
Nemo_bis added a project: MediaWiki-Search.
Nemo_bis subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 22 2015, 4:43 PM
Nemo_bis added a subtask: T46420: Restore interwiki (sister projects) results in search queries.Apr 22 2015, 4:45 PM
Aklapper added a project: good first task.Jul 16 2015, 1:43 PM

Code is in showInterwiki() in ./includes/specials/SpecialSearch.php if anyone wants to give this a shot.

Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptJul 16 2015, 1:43 PM
01tonythomas claimed this task.Aug 9 2015, 5:47 AM
01tonythomas set Security to None.
01tonythomas subscribed.
gerritbot subscribed.Sep 17 2015, 7:20 AM

Change 239037 had a related patch set uploaded (by Nemo bis):
Do not output interwiki search results box when there's no result

https://gerrit.wikimedia.org/r/239037

gerritbot added a project: Patch-For-Review.Sep 17 2015, 7:20 AM
gerritbot added a comment.Sep 17 2015, 9:04 AM

Change 239048 had a related patch set uploaded (by Nemo bis):
Return null when getInterwikiResults()

https://gerrit.wikimedia.org/r/239048

gerritbot added a comment.Oct 11 2016, 8:01 PM

Change 313318 had a related patch set uploaded (by EBernhardson):
[WIP] Perform interwiki searches with a multi-search

https://gerrit.wikimedia.org/r/313318

Restricted Application added a project: Discovery-Search. · View Herald TranscriptOct 11 2016, 8:01 PM
Restricted Application added a subscriber: TerraCodes. · View Herald Transcript
debt edited projects, added Discovery-Search (Current work); removed Discovery-Search.Oct 12 2016, 7:26 PM
debt added a parent task: T146179: Enable cross-wiki backend search functionality on it.wikipedia.
debt moved this task from Incoming to not in use - please delete on the Discovery-Search (Current work) board.
EBernhardson moved this task from not in use - please delete to Needs review on the Discovery-Search (Current work) board.Oct 12 2016, 9:02 PM
EBernhardson claimed this task.Oct 17 2016, 5:01 PM
gerritbot added a comment.Oct 17 2016, 5:08 PM

Change 239048 abandoned by EBernhardson:
Return null when getInterwikiResults()

Reason:
issue is being resolved in previously mentioned patch

https://gerrit.wikimedia.org/r/239048

gerritbot added a comment.Oct 20 2016, 10:11 AM

Change 313318 merged by jenkins-bot:
Perform interwiki searches with a multi-search

https://gerrit.wikimedia.org/r/313318

EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Oct 24 2016, 3:27 PM
debt closed this task as Resolved.Oct 27 2016, 7:55 PM
gerritbot added a comment.Dec 15 2016, 7:13 PM

Change 239037 abandoned by EBernhardson:
Do not output interwiki search results box when there's no result

Reason:
fixed via a larger refactor of SpecialSearch into widgets.

https://gerrit.wikimedia.org/r/239037

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits