Page MenuHomePhabricator
Create Task
Maniphest T91805

T7. Flow support for the mediawiki.feedback form
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
• Mattflaschen-WMF
Authored By
Quiddity
Mar 6 2015, 7:50 PM
Tags
Referenced Files
F57180: Screenshot_from_2015-03-06_11:35:44.png
Mar 6 2015, 7:50 PM
F57182: Screenshot_from_2015-03-06_11:16:22.png
Mar 6 2015, 7:50 PM
F57179: Screenshot_from_2015-03-06_11:36:01.png
Mar 6 2015, 7:50 PM
Subscribers
Aklapper
EBernhardson
• Elitre
gerritbot
Jdforrester-WMF
Legoktm
• Mattflaschen-WMF
View All 9 Subscribers

Description

VisualEditor has a feedback-form built in. Flow needs to support it.

Screenshot_from_2015-03-06_11:35:44.png (778×907 px, 168 KB)

Screenshot_from_2015-03-06_11:36:01.png (778×907 px, 145 KB)

This currently results in this edit:
https://www.mediawiki.org/w/index.php?title=VisualEditor/Feedback&diff=1435862&oldid=1433363

Screenshot_from_2015-03-06_11:16:22.png (1×1 px, 223 KB)

which the CLs then have to manually cut&paste into LQT.

The form should result in a Flow Post that includes:

  • the user-entered Title,
  • the user-entered Post,
  • and adds the automated useragent details (e.g. :<small>User agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:36.0) Gecko/20100101 Firefox/36.0</small>) to the post (top or bottom)

See also (or possibly duplicate of? but hey, screenshots!) :

Details

SubjectRepoBranchLines +/-
Add pluggable talk page poster and use it for mediawiki.feedbackmediawiki/corewmf/1.25wmf24+305 -39
Add Flow MessagePostermediawiki/extensions/Flowwmf/1.25wmf24+69 -0
Add pluggable talk page poster and use it for mediawiki.feedbackmediawiki/coremaster+305 -39
Add Flow MessagePostermediawiki/extensions/Flowmaster+69 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Quiddity created this task.Mar 6 2015, 7:50 PM
Quiddity raised the priority of this task from to Needs Triage.
Quiddity updated the task description. (Show Details)
Quiddity added projects: StructuredDiscussions, VisualEditor, Collaboration-Team-Triage.
Quiddity added subscribers: Quiddity, • Elitre.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 6 2015, 7:50 PM
Jdforrester-WMF subscribed.Mar 6 2015, 7:50 PM

This is just T59989: S2. Flow API: Let code add a new topic with action=edit&section=new.

Jdforrester-WMF renamed this task from Flow support for VisualEditor's mediawiki.feedback form to Flow support for the mediawiki.feedback form.Mar 6 2015, 11:14 PM
Jdforrester-WMF added a project: MediaWiki-General.
Jdforrester-WMF set Security to None.

Also, nothing VE-specific; this is MediaWiki core's code that Flow doesn't work with. :-)

• Elitre added a comment.Mar 9 2015, 4:52 PM

Doesn't this (or 59989) block https://phabricator.wikimedia.org/T91768 ?

EBernhardson closed this task as a duplicate of T59989: S2. Flow API: Let code add a new topic with action=edit&section=new.Mar 9 2015, 5:44 PM
• Mattflaschen-WMF reopened this task as Open.Mar 11 2015, 11:19 PM
• Mattflaschen-WMF added subscribers: Legoktm, • Mattflaschen-WMF.

We decided (with advice from @Legoktm) not to rely on the shim for now. We'll address this directly, probably with some kind of plugin/hook approach (since mediawiki.feedback is in core and Flow is an extension).

Let's estimate this tomorrow at standup.

• Mattflaschen-WMF mentioned this in T59989: S2. Flow API: Let code add a new topic with action=edit&section=new.Mar 11 2015, 11:20 PM
• Mattflaschen-WMF added a parent task: T92303: Convert LQT pages on MediaWiki.org to Flow (tracking).
• Mattflaschen-WMF mentioned this in T90383: give willing people an easy way to volunteer their user talk pages as a testing ground for Flow.Mar 11 2015, 11:27 PM
EBernhardson edited a custom field.Mar 12 2015, 5:43 PM
EBernhardson subscribed.

Implement some sort of plugability that allows Flow to integrate into the core js

EBernhardson triaged this task as Medium priority.Mar 12 2015, 5:44 PM
EBernhardson added a project: Collaboration-Team-Sprint-S-2015-03-25.
EBernhardson claimed this task.Mar 12 2015, 9:21 PM
EBernhardson removed EBernhardson as the assignee of this task.
EBernhardson moved this task from Sprint S - ends March 25 to In Development on the Collaboration-Team-Sprint-S-2015-03-25 board.
EBernhardson moved this task from In Development to Sprint S - ends March 25 on the Collaboration-Team-Sprint-S-2015-03-25 board.
Ricordisamoa subscribed.Mar 17 2015, 1:37 AM
Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.Mar 18 2015, 2:06 AM
• Mattflaschen-WMF claimed this task.Mar 20 2015, 6:19 PM
• DannyH moved this task from Untriaged to Team discussion on the Collaboration-Team-Triage board.Mar 24 2015, 11:06 PM
• Mattflaschen-WMF added a parent task: T89880: Improvements to mediawiki.feedback (tracking).Mar 24 2015, 11:34 PM
• DannyH moved this task from Team discussion to Sprint T (temporary for meeting) on the Collaboration-Team-Triage board.Mar 25 2015, 6:25 PM
• DannyH renamed this task from Flow support for the mediawiki.feedback form to T7. Flow support for the mediawiki.feedback form.Mar 25 2015, 7:33 PM
• DannyH raised the priority of this task from Medium to High.
• DannyH edited projects, added Collaboration-Team-Sprint-T-2015-04-08; removed Collaboration-Team-Triage.
gerritbot subscribed.Mar 31 2015, 3:30 AM

Change 200801 had a related patch set uploaded (by Mattflaschen):
Add pluggable talk page poster and use it for mediawiki.feedback

https://gerrit.wikimedia.org/r/200801

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMar 31 2015, 3:30 AM
gerritbot added a project: Patch-For-Review.Mar 31 2015, 3:30 AM
• Mattflaschen-WMF moved this task from Sprint T (temporary for meeting) to Untriaged on the Collaboration-Team-Triage board.Mar 31 2015, 3:34 AM
gerritbot added a comment.Apr 1 2015, 5:30 PM

Change 201234 had a related patch set uploaded (by Mattflaschen):
Add Flow MessagePoster

https://gerrit.wikimedia.org/r/201234

EBernhardson moved this task from Sprint T - ends April 8 to Needs Code Review on the Collaboration-Team-Sprint-T-2015-04-08 board.Apr 6 2015, 5:38 PM
EBernhardson moved this task from Needs Code Review to Code Review Started on the Collaboration-Team-Sprint-T-2015-04-08 board.
gerritbot added a comment.Apr 6 2015, 10:14 PM

Change 200801 merged by jenkins-bot:
Add pluggable talk page poster and use it for mediawiki.feedback

https://gerrit.wikimedia.org/r/200801

• Mattflaschen-WMF mentioned this in rMW061b987f1cb9: Add pluggable talk page poster and use it for mediawiki.feedback.Apr 6 2015, 10:14 PM
gerritbot added a comment.Apr 6 2015, 10:20 PM

Change 201234 merged by jenkins-bot:
Add Flow MessagePoster

https://gerrit.wikimedia.org/r/201234

Diffusion mentioned this in rMEXTb7814aaa00c5: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Apr 6 2015, 10:21 PM
• Mattflaschen-WMF mentioned this in rEFLW8a26cfd40b8a: Add Flow MessagePoster.Apr 6 2015, 10:21 PM
gerritbot added a comment.Apr 6 2015, 10:22 PM

Change 202258 had a related patch set uploaded (by EBernhardson):
Add pluggable talk page poster and use it for mediawiki.feedback

https://gerrit.wikimedia.org/r/202258

gerritbot added a comment.Apr 6 2015, 10:23 PM

Change 202259 had a related patch set uploaded (by EBernhardson):
Add Flow MessagePoster

https://gerrit.wikimedia.org/r/202259

gerritbot added a comment.Apr 6 2015, 10:29 PM

Change 202259 merged by EBernhardson:
Add Flow MessagePoster

https://gerrit.wikimedia.org/r/202259

EBernhardson mentioned this in rEFLW49ffd141e0a8: Add Flow MessagePoster.Apr 6 2015, 10:29 PM
• Mattflaschen-WMF closed this task as Resolved.Apr 7 2015, 12:03 AM
• Mattflaschen-WMF moved this task from Code Review Started to Done on the Collaboration-Team-Sprint-T-2015-04-08 board.Apr 7 2015, 12:13 AM
gerritbot added a comment.Apr 7 2015, 3:05 PM

Change 202258 merged by jenkins-bot:
Add pluggable talk page poster and use it for mediawiki.feedback

https://gerrit.wikimedia.org/r/202258

EBernhardson mentioned this in rMWbcc20e231010: Add pluggable talk page poster and use it for mediawiki.feedback.Apr 7 2015, 3:06 PM
• DannyH moved this task from Untriaged to Resolved on the Collaboration-Team-Triage board.Apr 7 2015, 5:47 PM
Jdforrester-WMF moved this task from TR6: Visual diffs to FY 18-19 Q3/Q4 on the VisualEditor board.Apr 8 2015, 10:49 AM
Jdforrester-WMF removed a project: Patch-For-Review.Sep 1 2015, 10:53 PM
Quiddity mentioned this in T111590: Allow cross-wiki target for MediaWiki's feedback tool.Sep 5 2015, 12:42 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits