Page MenuHomePhabricator
Create Task
Maniphest T57934

VisualEditor inspector for SyntaxHighlight is too tiny with no resize option
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

screenshot

While we can't yet just click into a <source> SyntaxHighlight extension chunk and edit it, I notice we can now click a "<>" button that opens a plaintext editor for the contents. Awesome!

Unfortunately the popup box for this seems really small, and there doesn't appear to be any way to resize it (no resize handles or zoom button that I can find).

Especially for editing source code blocks, being able to bump the size waaay up would be very helpful.

Version: unspecified
Severity: normal
URL: https://www.mediawiki.org/wiki/Manual:CORS?veaction=edit

Attached:

Screen_Shot_2013-10-20_at_5.02.16_AM.png (427×566 px, 61 KB)

Details

Reference
bz55934
SubjectRepoBranchLines +/-
Use dialog for editing block level syntax highlightsmediawiki/extensions/SyntaxHighlight_GeSHimaster+343 -97
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 2:19 AM
• bzimport added projects: Browser-Support-Firefox, VisualEditor-EditingTools.
• bzimport set Reference to bz55934.
• brooke created this task.Oct 20 2013, 12:10 PM
Jdforrester-WMF added a project: VisualEditor.Nov 24 2014, 4:07 PM
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Nov 24 2014, 4:15 PM
Jdforrester-WMF renamed this task from VisualEditor: Inspector for editing syntax-highlight extension contents is really tiny, can't be sized to Inspector for editing syntax-highlight extension contents is really tiny, can't be resized.Apr 20 2015, 7:40 PM
Jdforrester-WMF lowered the priority of this task from Low to Lowest.
Jdforrester-WMF added a project: SyntaxHighlight.
Jdforrester-WMF set Security to None.
Krinkle added a comment.Jun 26 2015, 8:33 AM

That inspector shown in that screenshot is not one from the SyntaxHighlight extension. Rather, it's the default dialog VisualEditor provides to allow editing of unknown MediaWiki tags (e.g. ones not registered elsewhere with a dedicated interface for known attributes and validating of values).

The SyntaxHighlight dialog or VisualEditor was merged only a few days ago:
T45126: Create a VisualEditor plugin tool to add/edit SyntaxHighlight blocks

It'll be deployed in wmf12 next week. Here's a screenshot from beta:

Screen Shot 2015-06-26 at 09.23.06.png (854×1 px, 64 KB)

http://en.wikipedia.beta.wmflabs.org/wiki/Python?veaction=edit

Which.. is also not very big. Keeping this task unresolved for now.

A few ideas:

  • Button to turn dialog into "full page" size.
  • By default, inner height unrestricted (however large the textarea is, autogrowing when changing it). With outer height providing scroll overflow based on browser window size.
  • Or; default to OOjs UI "large" or "larger" size at least.
Krinkle renamed this task from Inspector for editing syntax-highlight extension contents is really tiny, can't be resized to VisualEditor inspector for SyntaxHighlight is too tiny with no resize option.Jun 26 2015, 8:34 AM
Krinkle moved this task from Backlog to Accepted on the SyntaxHighlight board.Jun 26 2015, 8:36 AM
gerritbot subscribed.Oct 20 2015, 2:22 PM

Change 247567 had a related patch set uploaded (by Esanders):
Use dialog for editing block level syntax highlights

https://gerrit.wikimedia.org/r/247567

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 20 2015, 2:22 PM
gerritbot added a project: Patch-For-Review.Oct 20 2015, 2:22 PM
gerritbot added a comment.Oct 22 2015, 3:47 PM

Change 247567 merged by jenkins-bot:
Use dialog for editing block level syntax highlights

https://gerrit.wikimedia.org/r/247567

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-27_(1.27.0-wmf.4)).Oct 22 2015, 4:00 PM
Jdforrester-WMF closed this task as Resolved.Oct 22 2015, 4:23 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from Freezer to Blocked on the VisualEditor board.Oct 31 2015, 12:11 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits