⚓ T42478 AbuseFilter needs regression tests

Subject	Repo	Branch	Lines +/-
Add PHPUnit tests for various generic functions	mediawiki/extensions/AbuseFilter	master	+1 K -0
Add phpunit tests for creating and editing filters	mediawiki/extensions/AbuseFilter	master	+686 -0
Add tests for filter consequences	mediawiki/extensions/AbuseFilter	master	+774 -0

Status	Assigned	Task
Resolved	Daimona	T201193 Code coverage is low in AbuseFilter, Aim to increase to 50%
Resolved	Daimona	T42478 AbuseFilter needs regression tests
Resolved	Daimona	T193596 Abstract out parts of AbuseFilterViewEdit that deal with saving a filter

• bzimport raised the priority of this task from to Low.Nov 22 2014, 1:08 AM

• bzimport added a project: AbuseFilter.

• bzimport set Reference to bz40478.

• bzimport added a subscriber: Unknown Object (MLST).

scfc created this task.Sep 24 2012, 2:53 PM

Would this kind of test help us prevent unwanted side effects of changes such as T52107?

(In reply to comment #1)

Would this kind of test help us prevent unwanted side effects of changes such
as T52107?

and T54053...

• werdna unsubscribed.Dec 10 2014, 6:17 PM

He7d3r updated the task description. (Show Details)May 23 2015, 6:50 PM

He7d3r added a project: MediaWiki-Core-Tests.

He7d3r set Security to None.

He7d3r mentioned this in T100069: added_lines include whitespace at the beginning.

He7d3r updated the task description. (Show Details)

He7d3r updated the task description. (Show Details)May 25 2015, 2:49 AM

He7d3r mentioned this in T100249: AbuseFilter adds spaces before "added_lines", causing many false positives.

He7d3r mentioned this in T74329: "added_lines" is not in "new_wikitext" anymore and causes false positives.

He7d3r mentioned this in T100892: Notify SOMEONE that an abusefilter had a sudden increase in the number of logs.May 30 2015, 1:36 PM

matej_suchanek mentioned this in T106136: Wikidata edits are not tagged by AbuseFilter on item creations.Jul 17 2015, 12:46 PM

Krinkle removed a project: MediaWiki-Core-Tests.Jan 12 2017, 11:04 PM

Krinkle updated the task description. (Show Details)

Krinkle removed a subscriber: • wikibugs-l-list.

Huji subscribed.Jan 13 2017, 1:46 AM

He7d3r mentioned this in T178010: missing character equivalencies: ÈÉÊẼÌÍÏÓÒÔÕ∅Q̃ÚŰÜŨ.Nov 21 2017, 6:29 PM

Daimona awarded a token.Mar 23 2018, 8:35 PM

Daimona subscribed.

matej_suchanek raised the priority of this task from Low to High.Apr 6 2018, 9:36 AM

matej_suchanek added a project: Test-Coverage.

Yeah, definitely time to think about this. I'm not familiar with phpunit but I'd love to give some help.

I think this needs a (much needed) overhaul of the way AbuseFilter is coded. Quoting @matej_suchanek from an email, the plan could be to split it to a new class (say, AbuseFilterRunner) and cover it with tests.

Huji closed subtask T193596: Abstract out parts of AbuseFilterViewEdit that deal with saving a filter as Resolved.Jul 2 2018, 10:23 PM

Change 443520 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] [WIP] Add phpunit tests for creating filters

https://gerrit.wikimedia.org/r/443520

gerritbot added a project: Patch-For-Review.Jul 2 2018, 11:21 PM

Change 444191 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] [WIP] Add PHPUnit tests for various generic functions

https://gerrit.wikimedia.org/r/444191

This is what I'm progressively try to add as tests:

Tests for all AFPUserVisibleException exceptions
Tests for filter validation
Tests for generic functions in AbuseFilter class
Complete tests where filters are created, actions are executed and consequences must be taken.

Apart from the latter, everything is under review right now.

Change 444442 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] [WIP] Add tests for filter consequences

https://gerrit.wikimedia.org/r/444442

I think the above patches will provide a really good test background to start with, and should accomplish the goal of this task. Then, they may be expanded progressively.

Change 444442 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Add tests for filter consequences

https://gerrit.wikimedia.org/r/444442

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)).Jul 18 2018, 5:01 AM

Daimona updated the task description. (Show Details)Jul 18 2018, 7:15 AM

Change 443520 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Add phpunit tests for creating and editing filters

https://gerrit.wikimedia.org/r/443520

Huji updated the task description. (Show Details)Jul 24 2018, 4:04 PM

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)); removed MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)).Jul 24 2018, 5:00 PM

Daimona updated the task description. (Show Details)Aug 2 2018, 10:04 AM

Huji added a parent task: T201193: Code coverage is low in AbuseFilter, Aim to increase to 50%.Aug 3 2018, 6:19 PM

Huji mentioned this in T201193: Code coverage is low in AbuseFilter, Aim to increase to 50%.

Change 444191 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Add PHPUnit tests for various generic functions