InvalidArgumentException: Scalar parameter must be a string, number, Stringable, or MessageSpecifier; got bool (via SpecialNotifications/SubscribedNewCommentPresentationModel)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Ammarpad
	Oct 26 2024, 1:05 PM

Description

Error

service.version: 1.43.0-wmf.28
trace.id: 0263dfd6-201d-4b7c-bf84-24b6d70c7bde
Find trace.id in Logstash

labels.normalized_message

[{reqId}] {exception_url}   InvalidArgumentException: Scalar parameter must be a string, number, Stringable, or MessageSpecifier; got bool

Frame	Location	Call
from	/srv/mediawiki/php-1.43.0-wmf.28/includes/libs/Message/ScalarParam.php(52)
#0	/srv/mediawiki/php-1.43.0-wmf.28/includes/Message/Message.php(1344)	Wikimedia\Message\ScalarParam->__construct(string, bool)
#1	/srv/mediawiki/php-1.43.0-wmf.28/includes/Message/Message.php(857)	MediaWiki\Message\Message::plaintextParam(bool)
#2	/srv/mediawiki/php-1.43.0-wmf.28/extensions/DiscussionTools/includes/Notifications/SubscribedNewCommentPresentationModel.php(99)	MediaWiki\Message\Message->plaintextParams(bool)
#3	/srv/mediawiki/php-1.43.0-wmf.28/extensions/Echo/includes/Formatters/SpecialNotificationsFormatter.php(54)	MediaWiki\Extension\DiscussionTools\Notifications\SubscribedNewCommentPresentationModel->getHeaderMessage()
#4	/srv/mediawiki/php-1.43.0-wmf.28/extensions/Echo/includes/Formatters/EchoEventFormatter.php(77)	MediaWiki\Extension\Notifications\Formatters\SpecialNotificationsFormatter->formatModel(MediaWiki\Extension\DiscussionTools\Notifications\SubscribedNewCommentPresentationModel)
#5	/srv/mediawiki/php-1.43.0-wmf.28/extensions/Echo/includes/DataOutputFormatter.php(204)	MediaWiki\Extension\Notifications\Formatters\EchoEventFormatter->format(MediaWiki\Extension\Notifications\Model\Event)
#6	/srv/mediawiki/php-1.43.0-wmf.28/extensions/Echo/includes/DataOutputFormatter.php(164)	MediaWiki\Extension\Notifications\DataOutputFormatter::formatNotification(MediaWiki\Extension\Notifications\Model\Event, MediaWiki\User\User, string, LanguageEn)
#7	/srv/mediawiki/php-1.43.0-wmf.28/extensions/Echo/includes/Special/SpecialNotifications.php(71)	MediaWiki\Extension\Notifications\DataOutputFormatter::formatOutput(MediaWiki\Extension\Notifications\Model\Notification, string, MediaWiki\User\User, LanguageEn)
#8	/srv/mediawiki/php-1.43.0-wmf.28/includes/specialpage/SpecialPage.php(728)	MediaWiki\Extension\Notifications\Special\SpecialNotifications->execute(null)
#9	/srv/mediawiki/php-1.43.0-wmf.28/includes/specialpage/SpecialPageFactory.php(1726)	MediaWiki\SpecialPage\SpecialPage->run(null)
#10	/srv/mediawiki/php-1.43.0-wmf.28/includes/actions/ActionEntryPoint.php(504)	MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, MediaWiki\Context\RequestContext)
#11	/srv/mediawiki/php-1.43.0-wmf.28/includes/actions/ActionEntryPoint.php(146)	MediaWiki\Actions\ActionEntryPoint->performRequest()
#12	/srv/mediawiki/php-1.43.0-wmf.28/includes/MediaWikiEntryPoint.php(200)	MediaWiki\Actions\ActionEntryPoint->execute()
#13	/srv/mediawiki/php-1.43.0-wmf.28/index.php(58)	MediaWiki\MediaWikiEntryPoint->run()
#14	/srv/mediawiki/w/index.php(3)	require(string)
#15	{main}

Impact

Special:Notifications fatal for users who get notified about a comment that happened in a section where the section title (or revision that introduced/edited the section title) was suppressed/hidden.

Notes

Details

Request URL: https://en.wikipedia.org/wiki/Special:Notifications

Subject	Repo	Branch	Lines +/-
Handle hidden revision in more places	mediawiki/extensions/DiscussionTools	REL1_43	+15 -5
Handle hidden revision in more places	mediawiki/extensions/DiscussionTools	master	+15 -5
Notifications: Handle suppressed topic titles in notification	mediawiki/extensions/DiscussionTools	REL1_43	+10 -5
Notifications: Handle suppressed topic titles in notification	mediawiki/extensions/DiscussionTools	master	+10 -5

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T378876 InvalidArgumentException: Scalar parameter must be a string, number, Stringable, or MessageSpecifier (October 2024)
		Resolved	PRODUCTION ERROR	Ammarpad	T378261 InvalidArgumentException: Scalar parameter must be a string, number, Stringable, or MessageSpecifier; got bool (via SpecialNotifications/SubscribedNewCommentPresentationModel)

Event Timeline

Ammarpad created this task.Oct 26 2024, 1:05 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 26 2024, 1:05 PM

Ammarpad moved this task from Untriaged to Oct 2024 on the Wikimedia-production-error board.Oct 26 2024, 1:18 PM

Ammarpad mentioned this in T378133: InvalidArgumentException: Scalar parameter must be a string, number, Stringable, or MessageSpecifier; got bool (via SpecialPasswordPolicies).

Ammarpad claimed this task.Oct 26 2024, 1:27 PM

Ammarpad merged a task: T378265: [81e1b4c9-b3f2-480a-88bf-0e5a0f4fb121] 2024-10-26 14:51:04: "InvalidArgumentException" on Special:Notifications (wikipedia_es).Oct 26 2024, 3:20 PM

Ammarpad added a subscriber: Ezarate.

Umherirrender renamed this task from InvalidArgumentException: Scalar parameter must be a string, number, Stringable, or MessageSpecifier; got bool to InvalidArgumentException: Scalar parameter must be a string, number, Stringable, or MessageSpecifier; got bool (via SpecialNotifications/SubscribedNewCommentPresentationModel).Oct 26 2024, 3:46 PM

Change #1083328 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/extensions/DiscussionTools@master] Notifications: Handle suppressed topic titles in notification

https://gerrit.wikimedia.org/r/1083328

gerritbot added a project: Patch-For-Review.Oct 26 2024, 3:59 PM

Change #1083328 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Notifications: Handle suppressed topic titles in notification

https://gerrit.wikimedia.org/r/1083328

Maintenance_bot removed a project: Patch-For-Review.Oct 26 2024, 10:30 PM

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.1; 2024-10-29).Oct 26 2024, 11:00 PM

Change #1083373 had a related patch set uploaded (by Bartosz Dziewoński; author: Ammarpad):

[mediawiki/extensions/DiscussionTools@REL1_43] Notifications: Handle suppressed topic titles in notification

https://gerrit.wikimedia.org/r/1083373

gerritbot added a project: Patch-For-Review.Oct 26 2024, 11:13 PM

Change #1083373 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@REL1_43] Notifications: Handle suppressed topic titles in notification

https://gerrit.wikimedia.org/r/1083373

Maintenance_bot removed a project: Patch-For-Review.Oct 26 2024, 11:30 PM

matmarex closed this task as Resolved.Oct 27 2024, 1:20 AM

matmarex added a project: MW-1.43-notes.

matmarex subscribed.

I am having the same issue: [90265f1c-0e5b-4252-8544-18b078989362] 2024-10-27 22:07:14: Excepción grave de tipo "InvalidArgumentException" nothing is solved

The patch has been merged thus resolving. It will get deployed next week.

Ammarpad merged a task: T378682: Notifications broken for some users on fr.wikipedia.org.Oct 31 2024, 8:50 AM

Ammarpad added subscribers: Pic-Sou, matej_suchanek.

Ammarpad mentioned this in T378799: InvalidArgumentException: Scalar parameter must be a string, number, Stringable, or MessageSpecifier; got bool (via Formatters/EchoEditUserPagePresentationModel).Nov 1 2024, 8:29 AM

Still happening, but in different place

Still happening, same place (Special:Notifications) in eswiki

In T378261#10285778, @Ezarate wrote:

Still happening, same place (Special:Notifications) in eswiki

Note, the eswiki issue as of now is at T378799. Note that the error you'll see is actually the same, but the error origin is not.

matmarex added a parent task: T378876: InvalidArgumentException: Scalar parameter must be a string, number, Stringable, or MessageSpecifier (October 2024).Nov 2 2024, 12:00 PM

Aklapper merged a task: T378879: InvalidArgumentException: Scalar parameter must be a string, number, Stringable, or MessageSpecifier; got bool.Nov 2 2024, 7:57 PM

Aklapper added a subscriber: Tmagc.

Change #1086092 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/extensions/DiscussionTools@master] Handle hidden revision in more places

https://gerrit.wikimedia.org/r/1086092

gerritbot added a project: Patch-For-Review.Nov 2 2024, 9:07 PM

Michael subscribed.Nov 4 2024, 10:04 AM

Urbanecm_WMF added a parent task: T379021: InvalidArgumentException: Scalar parameter must be a string, number, Stringable, or MessageSpecifier; got bool (via RemovedTopicPresentationModel/DiscussionTools).Nov 4 2024, 7:07 PM

Urbanecm_WMF removed a parent task: T379021: InvalidArgumentException: Scalar parameter must be a string, number, Stringable, or MessageSpecifier; got bool (via RemovedTopicPresentationModel/DiscussionTools).

Urbanecm_WMF merged a task: T379021: InvalidArgumentException: Scalar parameter must be a string, number, Stringable, or MessageSpecifier; got bool (via RemovedTopicPresentationModel/DiscussionTools).

Urbanecm_WMF subscribed.

Change #1086092 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Handle hidden revision in more places

https://gerrit.wikimedia.org/r/1086092

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.2; 2024-11-05); removed MW-1.44-notes (1.44.0-wmf.1; 2024-10-29).Nov 4 2024, 11:00 PM

Should be fixed for real this time. Thanks for the patch for this and the other issues, @Ammarpad.

Change #1087263 had a related patch set uploaded (by Bartosz Dziewoński; author: Ammarpad):

[mediawiki/extensions/DiscussionTools@REL1_43] Handle hidden revision in more places

https://gerrit.wikimedia.org/r/1087263

Change #1087263 merged by jenkins-bot: