Page MenuHomePhabricator
Create Task
Maniphest T370593

Moving a page always marks it as unreviewed
Closed, ResolvedPublicBUG REPORT
Actions

Description

Reported by @Pppery on Discord

Steps to replicate the issue (include links if applicable):

  • Create a page in mainspace
  • New page patroller marks it as reviewed
  • Non-autopatrolled moves the page to another title in mainspace

What happens?:

  • Page is automatically marked as unreviewed during the page move

What should have happened instead?:

  • Page keeps its reviewed/unreviewed status, except for special cases such as autopatrolled, redirect flipping to article, etc.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

SubjectRepoBranchLines +/-
Do not unreview pages when they are movedmediawiki/extensions/PageTriagewmf/1.43.0-wmf.14+73 -12
Do not unreview pages when they are movedmediawiki/extensions/PageTriagemaster+73 -12
Customize query in gerrit

Related Objects

Event Timeline

Novem_Linguae created this task.Jul 21 2024, 6:03 AM
Restricted Application added a project: Moderator-Tools-Team. · View Herald TranscriptJul 21 2024, 6:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Novem_Linguae updated the task description. (Show Details)Jul 21 2024, 6:07 AM
Novem_Linguae moved this task from Backlog to Other bugs on the PageTriage board.
Soda added a comment.Jul 21 2024, 7:29 AM

This is indeed a regression caused by the linked patch, however, I'm a bit uneasy fixing this due to the existence of T159028 (cc @Pppery who mentioned this in the NPP Discord). Maybe we could get a consensus that implementing T159028 is no longer desirable?

Novem_Linguae added a comment.Jul 21 2024, 8:59 AM

Maybe it'd be a good idea to go back to the status quo ante behavior immediately. Then once that fire is out, we can take our time and potentially re-RFC the issue.

Soda added a comment.Jul 21 2024, 9:55 AM
In T370593#10000626, @Novem_Linguae wrote:

Maybe it'd be a good idea to go back to the status quo ante behavior immediately. Then once that fire is out, we can take our time and potentially re-RFC the issue.

Sounds good, I'll write up a patch to fix this. I've also started a discussion about the other task at VPP.

gerritbot added a comment.Jul 21 2024, 12:23 PM

Change #1055577 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/PageTriage@master] Do not unreview pages when they are moved

https://gerrit.wikimedia.org/r/1055577

gerritbot added a project: Patch-For-Review.Jul 21 2024, 12:23 PM
Soda triaged this task as High priority.Jul 21 2024, 1:52 PM
Soda added a subscriber: jsn.sherman.

Triaging this as high, since this is adding quite a few old pages into the queue. @jsn.sherman could y'all take a look at the linked patch :)

Wrt to T159028, we can always revert this patch if there is consensus.

jsn.sherman edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.Jul 22 2024, 1:20 PM
jsn.sherman moved this task from Ready to Eng review on the Moderator-Tools-Team (Kanban) board.
jsn.sherman moved this task from Eng review to QA on the Moderator-Tools-Team (Kanban) board.Jul 22 2024, 1:42 PM
gerritbot added a comment.Jul 22 2024, 1:46 PM

Change #1055941 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/PageTriage@wmf/1.43.0-wmf.14] Do not unreview pages when they are moved

https://gerrit.wikimedia.org/r/1055941

gerritbot added a comment.Jul 22 2024, 2:26 PM

Change #1055577 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Do not unreview pages when they are moved

https://gerrit.wikimedia.org/r/1055577

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.15; 2024-07-23).Jul 22 2024, 3:00 PM
gerritbot added a comment.Jul 22 2024, 8:50 PM

Change #1055941 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@wmf/1.43.0-wmf.14] Do not unreview pages when they are moved

https://gerrit.wikimedia.org/r/1055941

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.14; 2024-07-16); removed MW-1.43-notes (1.43.0-wmf.15; 2024-07-23).Jul 22 2024, 9:00 PM
Stashbot added a comment.Jul 22 2024, 9:10 PM

Mentioned in SAL (#wikimedia-operations) [2024-07-22T21:10:06Z] <catrope@deploy1002> Started scap sync-world: Backport for [[gerrit:1055941|Do not unreview pages when they are moved (T370593)]]

Stashbot added a comment.Jul 22 2024, 9:12 PM

Mentioned in SAL (#wikimedia-operations) [2024-07-22T21:12:32Z] <catrope@deploy1002> catrope, soda: Backport for [[gerrit:1055941|Do not unreview pages when they are moved (T370593)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Jul 22 2024, 9:30 PM

Mentioned in SAL (#wikimedia-operations) [2024-07-22T21:30:34Z] <catrope@deploy1002> Finished scap: Backport for [[gerrit:1055941|Do not unreview pages when they are moved (T370593)]] (duration: 20m 27s)

Maintenance_bot removed a project: Patch-For-Review.Jul 22 2024, 9:32 PM
Pppery closed this task as Resolved.Jul 22 2024, 10:06 PM
Pppery claimed this task.
Pppery reassigned this task from Pppery to Soda.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits