Change #1069115 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] chore: remove migrateCommunityConfig maint script and tests

https://gerrit.wikimedia.org/r/1069115

Change #1069115 abandoned by Michael Große:

[mediawiki/extensions/GrowthExperiments@master] chore: remove migrateCommunityConfig maint script and tests

Reason:

Abandoning for now. We'll define a more consistent approach to supporting 3rd parties, and probably remove this script after 1.43 has been released.

https://gerrit.wikimedia.org/r/1069115

Change #1087520 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] [tests] Mentorship: Test with CommunityConfiguration

https://gerrit.wikimedia.org/r/1087520

This would've prevented T379094: TypeError: Argument 1 passed to MediaWiki\Extension\CommunityConfiguration\Provider\AbstractProvider::normalizeTopLevelConfigData() must be an instance of stdClass, array given, called in /srv/mediawiki/php-1.44.0-wmf.1/extensi. We should do this ASAP, to avoid other similar bugs. Moving to Up Next.

Change #1087520 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] [tests] Mentorship: Test with CommunityConfiguration

https://gerrit.wikimedia.org/r/1087520

Change #1087870 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] extension.json: Use community configuration by default

https://gerrit.wikimedia.org/r/1087870

A great deal of the PHPUnit failures is this:

10:06:29 1) Wikibase\Search\Elastic\Tests\EntitySearchElasticFulltextTest::testSearchElastic with data set "search_de-ch" (array('Wien', 'de-ch', array(0, 120)), '/workspace/src/extensions/Wik...pected')
10:06:29 RuntimeException: Database backend disabled

This is because CommunityConfiguration is always trying to load the database. I wanted to know why that doesn't happen for legacy CC, which is also accessing pages. It turns out WikiPageConfigLoader has the following code:

private function fetchConfig( LinkTarget $configPage, int $flags ) {
	if ( $configPage->isExternal() ) {
		// Irrelevant in this case
	} else {
		$revision = $this->isTestWithStorageDisabled
			? null
			: $this->revisionLookup->getRevisionByTitle( $configPage, 0, $flags );
		if ( !$revision ) {
			// The configuration page does not exist. Pretend it does not configure anything
			// specific (failure mode and empty-page behavior is equal, see T325236).
			return StatusValue::newGood( $this->configValidatorFactory
				->newConfigValidator( $configPage )
				->getDefaultContent()
			);
		}
	}
}

Essentially, WikiPageConfigLoader skips the database layer entirely if the storage is disabled. Since we're dealing with the same problem in this task and returning the default proved to be successful for legacy CC, let's do that again. In CommunityConfiguration world, this would be a change to WikiPageStore::fetchJsonBlob().

Let's implement the same thing in CommunityConfiguration and see where it takes us.

Change #1092316 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/CommunityConfiguration@master] WikiPageStore: Do not access DB when running without a storage backend

https://gerrit.wikimedia.org/r/1092316

Change #1092331 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] [tests] HelpPanelTest: Override CC2.0 variables correctly

https://gerrit.wikimedia.org/r/1092331

Change #1094377 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/CommunityConfiguration@master] Introduce CommunityConfigurationTestHelpers

https://gerrit.wikimedia.org/r/1094377

Change #1094378 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] [tests] Migrate PersonalizedPraiseHooksTest to CC2.0

https://gerrit.wikimedia.org/r/1094378

Change #1087870 abandoned by Urbanecm:

[mediawiki/extensions/GrowthExperiments@master] extension.json: Use community configuration by default

https://gerrit.wikimedia.org/r/1087870

Considering we're nearing the end of the sprint, I decided to clarify this ticket's purpose. Here, the goal is to switch the use CommunityConfiguration feature flag to true by default, ensuring most tests (and all new ones) are using CommunityConfiguration. However, it is acceptable to pin certain tests to the old system. Fully fixing all tests is tracked in T380586: [EPIC] Ensure GrowthExperiments CI pipeline is using CommunityConfiguration to run tests.

Change #1092331 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] HelpPanel: Inject $config and $wikiConfig correctly

https://gerrit.wikimedia.org/r/1092331

This should be all ready for code review. Once patches uploaded here get merged, using CC should be the default. There will be few other tests to follow-up on:

• ComputedUserImpactLookupTest (T380580)
• selenium tests (T380581)
• ApiStructureTest (T380585)

Change #1092316 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] WikiPageStore: Do not access DB when running without a storage backend

https://gerrit.wikimedia.org/r/1092316

Change #1094377 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] Introduce CommunityConfigurationTestHelpers

https://gerrit.wikimedia.org/r/1094377

Change #1094378 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] [tests] Migrate most testcases to CC2.0

https://gerrit.wikimedia.org/r/1094378

Finally. Moving to QA.