Page MenuHomePhabricator

Update copy for typography settings
Closed, ResolvedPublic2 Estimated Story Points

Description

Background

We would like to finalize the copy for the typography settings menu

Acceptance criteria

  • Update copy to the following:

Screenshot 2023-11-22 at 8.54.07 AM.png (874×472 px, 41 KB)

Screenshot 2023-11-22 at 8.55.24 AM.png (604×342 px, 33 KB)

Screenshot 2023-11-22 at 8.53.54 AM.png (174×584 px, 22 KB)

Rationale

"Appearance" is already in use and translatable. It creates some ambiguity with the existing appearance menu in settings and gadgets, but those areas are already very confusing, and there's no reason not to use the label in this prominent place because it's being misused in less prominent places.

Fo the typographic settings, Text was the clearest label that has the most literal reference to the function.

The word "standard" is used as a gentle nudge showing that these are the WMF-recommended settings.

We didn't use "dark mode" or "light mode" because "dark" has a lot of value-laden connotations in the languages we speak and would presumably be so for other languages as well. Night/day is a very translatable label that we assume has less fraught value connotations across languages.

QA Results - Beta

ACStatusDetails
1T351867#9376162

Event Timeline

ovasileva created this task.
ovasileva set the point value for this task to 2.Nov 27 2023, 6:50 PM

Change 977773 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] i18n: Update copy

https://gerrit.wikimedia.org/r/977773

Change 977773 merged by jenkins-bot:

[mediawiki/skins/Vector@master] i18n: Update copy

https://gerrit.wikimedia.org/r/977773

Edtadros subscribed.

Test Result - Beta

Status:
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

❓ Update copy to the examples in the description
The color options are not present, and the order of the existing options is switched. I can see the order not being a big deal, but is the color supposed to be implemented yet? Is there a url param I would need to enable it?

screenshot 302.png (392×460 px, 32 KB)

screenshot 301.png (449×525 px, 32 KB)

screenshot 300.png (578×549 px, 44 KB)

Change 979179 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Put font size control before limited width control

https://gerrit.wikimedia.org/r/979179

Change 979179 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Put font size control before limited width control

https://gerrit.wikimedia.org/r/979179

Test Result - Beta

Status:
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ Update copy to the examples in the description
The color options are not present, and the order of the existing options is switched. I can see the order not being a big deal, but is the color supposed to be implemented yet? Is there a url param I would need to enable it?

screenshot 310.png (313×497 px, 32 KB)

screenshot 309.png (363×259 px, 18 KB)

screenshot 308.png (417×509 px, 40 KB)

Copy and order are correct. Resolving.

Test Result - en.wikipedia.org

Status:
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ Update copy to the examples in the description

Screenshot 2024-01-04 at 9.29.23 AM.png (343×239 px, 17 KB)

This matches beta cluster, but I notice the heading of the menu is "Theme" not "Appearance". Was this overlooked?

Jdlrobson added a project: Verified.

Checked with Justin and this was missed so I've gone ahead and created T354371.