| Jdlrobson | |
| Nov 21 2023, 12:24 AM |
| F41864746: image.png | |
| Feb 12 2024, 10:29 AM |
| F41522393: Screenshot 2023-11-20 at 4.35.44 PM.png | |
| Nov 21 2023, 12:36 AM |
| F41522395: Screenshot 2023-11-20 at 4.36.19 PM.png | |
| Nov 21 2023, 12:36 AM |
The mediawiki.icon module is used in Extension:Wikibase and Extension:UploadWizard. The only purpose of this module is to serve 2 icons. These extensions should stop using the module and use .cdx-mixin-css-icon() and cdxIconDownTriangle icon instead (using transform to rotate where needed).
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | BUG REPORT | Ebrahim | T351681 Deprecate mediawiki.icon ResourceLoader module and use Codex mixin instead. | ||
| Resolved | Ebrahim | T357271 [CLIENT] Stop using deprecated mediawiki.icon ResourceLoader module in Wikibase Client and use Codex mixin instead. |
Change 975920 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/core@master] mediawiki.icon: Deprecate module in favor of Codex mixin
Change 975920 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.icon: Deprecate module in favor of Codex mixin
Change #1062456 had a related patch set uploaded (by Ebrahim; author: Ebrahim):
[mediawiki/core@master] Remove use of a deprecated module from collapsibleFooter
Change #1062456 merged by jenkins-bot:
[mediawiki/core@master] Remove use of a deprecated module from collapsibleFooter
Change #1065246 had a related patch set uploaded (by Ebrahim; author: Ebrahim):
[mediawiki/extensions/Wikibase@master] Remove use of mediawiki.icon
I tried to approach UploadWizard one also but each time have failed on finding where exactly where it's used there exactly, can someone familiar with UploadWizard details help here just like the helpful comment about Wikibase in T357271, thanks
Change #1065246 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove use of mediawiki.icon
Change #1065257 had a related patch set uploaded (by Ebrahim; author: Ebrahim):
[mediawiki/extensions/UploadWizard@master] Remove use of mediawiki.icon
UploadWizard wasn't actually using this at all now I see, guess there was some historical use of it there that are long gone with OOUI-fication of the UploadWizard UI years ago which are gone for years.
Change #1065264 had a related patch set uploaded (by Ebrahim; author: Ebrahim):
[mediawiki/extensions/MediaUploader@master] Remove use of mediawiki.icon
Change #1065257 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Remove use of mediawiki.icon
Change #1065264 merged by jenkins-bot:
[mediawiki/extensions/MediaUploader@master] Remove use of mediawiki.icon
Change #1065630 had a related patch set uploaded (by Ebrahim; author: Ebrahim):
[mediawiki/core@master] Remove mediawiki.icon
Change #1065630 merged by jenkins-bot:
[mediawiki/core@master] Remove deprecated `mediawiki.icon` module
I noticed two regressions on edit pages (at the very bottom):
Another issue is that in the text « This page is a member of 42 hidden categories (help): », the space before « (help) » sort of gets removed, i.e. the text is displayed as « categories(help) ».
It is due to the "display: flex" CSS that is applied to the containing <p>.
Interestingly, the "pages transcluded" section just above doesn't have the issue, although it uses the same markup and CSS.
These are indeed overlooked since the change,
"Wikidata entities used in this page" one is fixed, can be seen in beta cluster I think and should be in the next release.
Filed an issue for Live preview one, T373286
Filed another for that whitespaces, T373287
Closing this one as there isn't anything to do here, unless, we decide to revert the change completely which is an option also but I hope not needed
Uploaded https://gerrit.wikimedia.org/r/1066438 to fix both issues, that's at least my solution which isn't perfect but should be good enough for now.
About this case in particular:
I noticed that the problem occurs in two steps: