Page MenuHomePhabricator

Extra right padding inside notifications dropdown while it's loading
Closed, ResolvedPublic

Description

I've seen this also affect notifications as well as they are loading.

image.png (505×1 px, 48 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Same as the other task, this is caused by the addition of scrollbar-gutter rules in OOUI. However, the gutter should only be shown on elements that are potentially scrollable, and the notification list while loading is not. Echo is doing something funny here to make OOUI think it is.

Bonus bug: the scrollbar is always shown, even when there are very few notifications.

image.png (1×1 px, 73 KB)

Change 975260 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/Echo@master] Fix unnecessary scrollbars on notifications popup

https://gerrit.wikimedia.org/r/975260

Change 975260 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Fix unnecessary scrollbars on notifications popup

https://gerrit.wikimedia.org/r/975260