Page MenuHomePhabricator

Extra right padding inside username autocompletion dropdown
Closed, ResolvedPublic

Description

image.png (301×585 px, 30 KB)

Could be an OOUI regression as we haven't touched this code in a while...

Event Timeline

Looks like this is caused by scrollbar-gutter: stable.

Note that we disable clipping in CSS in this widget:

.ve-ui-completionWidget .oo-ui-popupWidget-body {
	/* The contained MenuSelectWidget is already clipped (T330401) */
	/* TODO: This could be done in JS if OO.ui.ClippableElement provided a way to disable clipping */
	overflow: hidden !important; /* stylelint-disable-line declaration-no-important */
}

Change 975063 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] CompletionWidget: Fix scrollable-gutter in CSS-disabled clippable element

https://gerrit.wikimedia.org/r/975063

Change 975063 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] CompletionWidget: Fix scrollable-gutter in CSS-disabled clippable element

https://gerrit.wikimedia.org/r/975063

I've seen this also affect notifications as well as they are loading.

Change 975309 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (5b5119dd8)

https://gerrit.wikimedia.org/r/975309

Change 975309 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (5b5119dd8)

https://gerrit.wikimedia.org/r/975309

EAkinloose subscribed.

Tested on desktop and mobile(bug irreproducible)

Before:

Screenshot 2023-11-20 at 23.19.25.png (528×622 px, 47 KB)

After:

Screenshot 2023-11-20 at 23.18.35.png (412×978 px, 37 KB)