Use expression builder instead of raw SQL in Wikistories
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Maintenance_bot
	Nov 10 2023, 4:18 PM

Description

Now that T210206: Deprecate raw SQL conditions for IDatabase methods (select, insert, etc.) is done, this extension should migrate away from building and passing around raw SQL to expression builders.

It improves readability and security of the code and is more aligned with industry practices easing onboarding.

For more information check T210206 and T350075.

Calls to Database::addQuotes(), ::buildLike(), ::makeList() indicate that raw SQL is being built and passed around.

QA Results - Beta

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T350956 here

Details

	Subject	Repo	Branch	Lines +/-
	Replace raw SQL with expr function	mediawiki/extensions/Wikistories	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T350075 Migrate raw SQL building in conditions to expression builder in WMF-deployed extensions
		Resolved		SBisson	T350956 Use expression builder instead of raw SQL in Wikistories

Event Timeline

Maintenance_bot created this task.Nov 10 2023, 4:18 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 10 2023, 4:18 PM

Ladsgroup added a project: Wikistories.Nov 10 2023, 5:05 PM

SBisson triaged this task as Medium priority.Nov 17 2023, 4:43 PM

SBisson added a project: Inuka-Team (Kanban).

SBisson moved this task from Backlog to Ready for Dev on the Inuka-Team (Kanban) board.

SBisson claimed this task.Nov 27 2023, 3:49 PM

SBisson moved this task from Ready for Dev to Dev on the Inuka-Team (Kanban) board.

Change 977727 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/Wikistories@master] Replace raw SQL with exp function

https://gerrit.wikimedia.org/r/977727

gerritbot added a project: Patch-For-Review.Nov 27 2023, 3:55 PM

SBisson moved this task from Dev to Code Review on the Inuka-Team (Kanban) board.Nov 27 2023, 3:55 PM

Change 977727 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Replace raw SQL with expr function

https://gerrit.wikimedia.org/r/977727

Maintenance_bot removed a project: Patch-For-Review.Nov 27 2023, 8:30 PM

Only small code maintenance to the filtering of Wikistories events on Special:RecentChanges. Should not change any behavior.

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.7; 2023-11-28).Nov 27 2023, 9:00 PM

@SBisson I did not come across any issue when doing regression testing except the one I just filed right now in T353552: Wikistories: Duplicate content when selecting the images. I will move this to design sign-off since the new task has been created. Thanks for all your work!

Status: ✅PASS
Environment: Beta: 1.42.0-alpha (5a95e4e)
OS: macOS Sonoma 14.2
Browser: Chrome 120, Firefox 120, Safari 17.2, Edge 120
Skins. mobile
Device: MBA M2
Emulated Device:: BrowserStack: iPhone 12, iPad, Galaxy S23, Pixel 8 Pro, iPhone 8
Test Links:
https://en.m.wikipedia.beta.wmflabs.org/wiki/Harry_Potter

✅AC1: https://phabricator.wikimedia.org/T350956

No other issue except the one below which I filed on T353552: Wikistories: Duplicate content when selecting the images

I also filed T353567: WikiStories: Mobile Desktop- Text Size box for mobile desktop issue

GMikesell-WMF updated the task description. (Show Details)Dec 15 2023, 9:18 PM

GMikesell-WMF moved this task from QA to Design sign off on the Inuka-Team (Kanban) board.

SGautam_WMF moved this task from Design sign off to Product sign off on the Inuka-Team (Kanban) board.Dec 19 2023, 11:53 AM

PWaigi-WMF closed this task as Resolved.Dec 21 2023, 9:44 AM

	F41602579: duplicate_content_images.webm
	Dec 15 2023, 9:17 PM

Use expression builder instead of raw SQL in WikistoriesClosed, ResolvedPublicActions