Page MenuHomePhabricator
Create Task
Maniphest T350857

🕷️ Improve e2e tests
Closed, ResolvedPublic
Actions

Description

Find a better way to reset the state of the test entity after (successful 2xx) DELETE requests
See Muhammad's gerrit comment

Details

SubjectRepoBranchLines +/-
REST: Improve DELETE e2e testsmediawiki/extensions/Wikibasemaster+67 -87
REST: Improve DELETE e2e testsmediawiki/extensions/Wikibasemaster+44 -28
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ollie.Shotton_WMDE created this task.Nov 9 2023, 11:25 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 9 2023, 11:25 AM
hashar mentioned this in T350978: search/extra-analysis and wmf-jvm-utils fail on CI under Java 8 and Java 11.Nov 10 2023, 4:34 PM
Muhammad_Yasser_Jazirahly_WMDE claimed this task.Nov 11 2023, 12:02 PM
Muhammad_Yasser_Jazirahly_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 7) board.
gerritbot added a comment.Nov 12 2023, 2:10 PM

Change 973404 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Improve DELETE e2e tests

https://gerrit.wikimedia.org/r/973404

gerritbot added a project: Patch-For-Review.Nov 12 2023, 2:10 PM
Ifrahkhanyaree_WMDE moved this task from Sprint 7 to Sprint 8 on the Wikibase Product Platform Team WPP board.Nov 15 2023, 9:38 AM
Ifrahkhanyaree_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 8); removed Wikibase Product Platform Team WPP (Sprint 7).
Ifrahkhanyaree_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 8) board.
gerritbot added a comment.Nov 16 2023, 5:16 PM

Change 975048 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Improve DELETE e2e tests

https://gerrit.wikimedia.org/r/975048

Muhammad_Yasser_Jazirahly_WMDE updated Other Assignee, added: Ollie.Shotton_WMDE.Nov 19 2023, 10:58 AM
Muhammad_Yasser_Jazirahly_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform Team WPP (Sprint 8) board.
gerritbot added a comment.Nov 20 2023, 10:45 AM

Change 973404 abandoned by Muhammad Jaziraly:

[mediawiki/extensions/Wikibase@master] REST: Improve DELETE e2e tests

Reason:

- better way to do it here: Ic5edcac151108e2b6c34a89d49bf70718bcf633a

https://gerrit.wikimedia.org/r/973404

Muhammad_Yasser_Jazirahly_WMDE reassigned this task from Muhammad_Yasser_Jazirahly_WMDE to Ollie.Shotton_WMDE.Nov 20 2023, 10:46 AM
Muhammad_Yasser_Jazirahly_WMDE updated Other Assignee, removed: Ollie.Shotton_WMDE.
Muhammad_Yasser_Jazirahly_WMDE subscribed.
Jakob_WMDE claimed this task.Nov 22 2023, 4:12 PM
Jakob_WMDE moved this task from Peer Review to Doing on the Wikibase Product Platform Team WPP (Sprint 8) board.
Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform Team WPP (Sprint 8) board.Nov 22 2023, 5:42 PM
gerritbot added a comment.Nov 23 2023, 2:31 PM

Change 975048 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Improve DELETE e2e tests

https://gerrit.wikimedia.org/r/975048

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.7; 2023-11-28).Nov 23 2023, 3:00 PM
Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform Team WPP (Sprint 8) board.Nov 23 2023, 3:08 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 23 2023, 3:10 PM
Ifrahkhanyaree_WMDE closed this task as Resolved.Nov 28 2023, 2:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits